diff mbox series

config/gcn/mkoffload.c – remove unused static vars

Message ID e0299f84-1fa5-87fb-cdf1-ecdadf942326@codesourcery.com
State New
Headers show
Series config/gcn/mkoffload.c – remove unused static vars | expand

Commit Message

Tobias Burnus Nov. 25, 2019, 2:17 p.m. UTC 
The compiler warns that funcs_tail and vars_tails are unused – they, 
funcs_ids/var_ids and struct id_map seem to be a copy-n-paste leftovers 
from gcc/config/nvptx/mkoffload.c.

Additionally, COMMENT_PREFIX does not seem to be used anywhere. (In the 
whole of GCC, it appears twice – in this file and in 
gcc/config/nvptx/mkoffload.c; in either file, only once and only as 
#define.)

OK for the trunk?

Cheers,

Tobias

Comments

Andrew Stubbs Nov. 25, 2019, 2:19 p.m. UTC | #1 
On 25/11/2019 14:17, Tobias Burnus wrote:
> The compiler warns that funcs_tail and vars_tails are unused – they, 
> funcs_ids/var_ids and struct id_map seem to be a copy-n-paste leftovers 
> from gcc/config/nvptx/mkoffload.c.
> 
> Additionally, COMMENT_PREFIX does not seem to be used anywhere. (In the 
> whole of GCC, it appears twice – in this file and in 
> gcc/config/nvptx/mkoffload.c; in either file, only once and only as 
> #define.)
> 
> OK for the trunk?

That's probably accurate reasoning.

OK.

Andrew
diff mbox series

Patch

2019-11-25  Tobias Burnus  <tobias@codesourcery.com>

	* config/gcn/mkoffload.c (COMMENT_PREFIX, struct id_map,
	func_ids, funcs_tail, var_ids, vars_tail) Remove unused
	definitions.

diff --git a/gcc/config/gcn/mkoffload.c b/gcc/config/gcn/mkoffload.c
index 40b56375b75..b5a2870057c 100644
--- a/gcc/config/gcn/mkoffload.c
+++ b/gcc/config/gcn/mkoffload.c
@@ -36,17 +36,6 @@ 
 
 const char tool_name[] = "gcn mkoffload";
 
-#define COMMENT_PREFIX "#"
-
-struct id_map
-{
-  id_map *next;
-  char *gcn_name;
-};
-
-static id_map *func_ids, **funcs_tail = &func_ids;
-static id_map *var_ids, **vars_tail = &var_ids;
-
 /* Files to unlink.  */
 static const char *gcn_s1_name;
 static const char *gcn_s2_name;