ixgbevf: Removing limit of 10 entries for unicast filter list
diff mbox series

Message ID 20191125095533.40157-1-radoslawx.tyl@intel.com
State Superseded
Headers show
Series
  • ixgbevf: Removing limit of 10 entries for unicast filter list
Related show

Commit Message

Radoslaw Tyl Nov. 25, 2019, 9:55 a.m. UTC
Currently, though the FDB entry is added to VF, it does not appear in
RAR filters. VF driver allows add only 10 entries. Attempting to add
another causes an error. This patch removed limitation and allow use of
all free RAR entries for the FDB if needed.

Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Paul Menzel Nov. 25, 2019, 11:19 a.m. UTC | #1
Dear Radoslaw,


Thank you for your patch.

Some small nit-picks.

Use imperative mood in the subject line:

> Remove limit of 10 entries for unicast filter list

On 2019-11-25 10:55, Radoslaw Tyl wrote:
> Currently, though the FDB entry is added to VF, it does not appear in
> RAR filters. VF driver allows add only 10 entries. Attempting to add

VF driver only allows to add 10 entries.
VF driver only allows 10 entries.

> another causes an error. This patch removed limitation and allow use of

s/removed/removes the/
allow*s*

> all free RAR entries for the FDB if needed.

So, the check is added in commit 46ec20ff7d (ixgbevf: Add macvlan support
in the set rx mode op). Greg, could you please enlighten us for the
reasoning for the ten entries limit? Radoslaw, why do you think the limit
can be safely removed?

Radoslaw, please add

> Fixes: 46ec20ff7d ("ixgbevf: Add macvlan support in the set rx mode op")

to the commit message.

> Signed-off-by: Radoslaw Tyl <radoslawx.tyl@intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index 076f2da36f27..64ec0e7c64b4 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -2081,11 +2081,6 @@ static int ixgbevf_write_uc_addr_list(struct net_device *netdev)
>  	struct ixgbe_hw *hw = &adapter->hw;
>  	int count = 0;
>  
> -	if ((netdev_uc_count(netdev)) > 10) {
> -		pr_err("Too many unicast filters - No Space\n");
> -		return -ENOSPC;
> -	}
> -
>  	if (!netdev_uc_empty(netdev)) {
>  		struct netdev_hw_addr *ha;


Kind regards,

Paul

Patch
diff mbox series

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 076f2da36f27..64ec0e7c64b4 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -2081,11 +2081,6 @@  static int ixgbevf_write_uc_addr_list(struct net_device *netdev)
 	struct ixgbe_hw *hw = &adapter->hw;
 	int count = 0;
 
-	if ((netdev_uc_count(netdev)) > 10) {
-		pr_err("Too many unicast filters - No Space\n");
-		return -ENOSPC;
-	}
-
 	if (!netdev_uc_empty(netdev)) {
 		struct netdev_hw_addr *ha;