Patchwork [U-Boot,1/3] nand: Remove static modifier from common functions

login
register
mail settings
Submitter Simon Schwarz
Date Oct. 16, 2011, 10:50 a.m.
Message ID <1318762212-6763-2-git-send-email-simonschwarzcor@gmail.com>
Download mbox | patch
Permalink /patch/120026/
State Superseded
Headers show

Comments

Simon Schwarz - Oct. 16, 2011, 10:50 a.m.
Removed static modifiers from functions that were often duplicated in
SPL implementations.

Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
Cc: scottwood@freescale.com
Cc: s-paulraj@ti.com
Cc: albert.u.boot@aribaud.net
---
Changes V2:
nothing
---
 drivers/mtd/nand/nand_base.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
Scott Wood - Oct. 28, 2011, 8:45 p.m.
On 10/16/2011 05:50 AM, Simon Schwarz wrote:
> Removed static modifiers from functions that were often duplicated in
> SPL implementations.
> 
> Signed-off-by: Simon Schwarz <simonschwarzcor@gmail.com>
> Cc: scottwood@freescale.com
> Cc: s-paulraj@ti.com
> Cc: albert.u.boot@aribaud.net
> ---
> Changes V2:
> nothing
> ---
>  drivers/mtd/nand/nand_base.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Ideally the prototypes would be added in the same patch, but it's not
worth respinning over, especially since U-Boot doesn't appear to enable
-Wmissing-prototypes.

Acked-by: Scott Wood <scottwood@freescale.com>

Will this be taken via an ARM tree due to patch 3/3?

-Scott

Patch

diff --git a/drivers/mtd/nand/nand_base.c b/drivers/mtd/nand/nand_base.c
index e7dfcb1..109d2cf 100644
--- a/drivers/mtd/nand/nand_base.c
+++ b/drivers/mtd/nand/nand_base.c
@@ -133,7 +133,7 @@  static void nand_release_device (struct mtd_info *mtd)
  *
  * Default read function for 8bit buswith
  */
-static uint8_t nand_read_byte(struct mtd_info *mtd)
+uint8_t nand_read_byte(struct mtd_info *mtd)
 {
 	struct nand_chip *chip = mtd->priv;
 	return readb(chip->IO_ADDR_R);
@@ -196,7 +196,7 @@  static void nand_select_chip(struct mtd_info *mtd, int chipnr)
  *
  * Default write function for 8bit buswith
  */
-static void nand_write_buf(struct mtd_info *mtd, const uint8_t *buf, int len)
+void nand_write_buf(struct mtd_info *mtd, const uint8_t *buf, int len)
 {
 	int i;
 	struct nand_chip *chip = mtd->priv;
@@ -249,7 +249,7 @@  static int nand_verify_buf(struct mtd_info *mtd, const uint8_t *buf, int len)
  *
  * Default write function for 16bit buswith
  */
-static void nand_write_buf16(struct mtd_info *mtd, const uint8_t *buf, int len)
+void nand_write_buf16(struct mtd_info *mtd, const uint8_t *buf, int len)
 {
 	int i;
 	struct nand_chip *chip = mtd->priv;