Patchwork [2/2] m48t59: fix write access

login
register
mail settings
Submitter Blue Swirl
Date Oct. 15, 2011, 1:51 p.m.
Message ID <CAAu8pHubD_Zg-d_RUThHdVJD5r_JDp1_r0wMD49jW8wiCPzXPQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/119973/
State New
Headers show

Comments

Blue Swirl - Oct. 15, 2011, 1:51 p.m.
Fix incorrect order of arguments, letting writes to NVRAM succeed.

It looks like guests never write to the device, only read from it, since the bug
originates back to 819385c58b319d9f80d676cefaed0610118f03ac.

Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
 hw/m48t59.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

     default:

Patch

diff --git a/hw/m48t59.c b/hw/m48t59.c
index dba5796..a77937e 100644
--- a/hw/m48t59.c
+++ b/hw/m48t59.c
@@ -491,7 +491,7 @@  static void NVRAM_writeb (void *opaque, uint32_t
addr, uint32_t val)
         NVRAM->addr |= val << 8;
         break;
     case 3:
-        m48t59_write(NVRAM, val, NVRAM->addr);
+        m48t59_write(NVRAM, NVRAM->addr, val);
         NVRAM->addr = 0x0000;
         break;