[1/2] dt-bindings: hwmon/pmbus: Add UCD90320 power sequencer
diff mbox series

Message ID 20191122222542.29661-2-wrightj@linux.vnet.ibm.com
State Changes Requested
Headers show
Series
  • hwmon: Add UCD90320 power sequencer chip
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

Jim Wright Nov. 22, 2019, 10:25 p.m. UTC
From: Jim Wright <jlwright@us.ibm.com>

Document the UCD90320 device tree binding.

Signed-off-by: Jim Wright <jlwright@us.ibm.com>
---
 .../devicetree/bindings/hwmon/pmbus/ucd90320.txt    | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt

Comments

Rob Herring Dec. 4, 2019, 10:59 p.m. UTC | #1
On Fri, Nov 22, 2019 at 04:25:41PM -0600, Jim Wright wrote:
> From: Jim Wright <jlwright@us.ibm.com>
> 
> Document the UCD90320 device tree binding.
> 
> Signed-off-by: Jim Wright <jlwright@us.ibm.com>
> ---
>  .../devicetree/bindings/hwmon/pmbus/ucd90320.txt    | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt

Can you make this a schema. See 
Documentation/devicetree/writing-schema.rst.

> 
> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
> new file mode 100644
> index 000000000000..e1c1057c6292
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
> @@ -0,0 +1,13 @@
> +UCD90320 power sequencer
> +-------------------------
> +
> +Requires node properties:
> +- compatible : "ti,ucd90320"
> +- reg : the I2C address of the device. This is 0x11, 0x13, 0x17, 0x31, 0x33,
> +        0x37, 0x71, 0x73, or 0x77.
> +
> +Example:
> +	ucd90320@11 {
> +		compatible = "ti,ucd90320";
> +		reg = <0x11>;
> +	};
> -- 
> 2.17.1
>
Jim Wright Dec. 4, 2019, 11:32 p.m. UTC | #2
Hi Rob,

On 12/4/2019 4:59 PM, Rob Herring wrote:
> On Fri, Nov 22, 2019 at 04:25:41PM -0600, Jim Wright wrote:
>> From: Jim Wright <jlwright@us.ibm.com>
>>
>> Document the UCD90320 device tree binding.
>>
>> Signed-off-by: Jim Wright <jlwright@us.ibm.com>
>> ---
>>   .../devicetree/bindings/hwmon/pmbus/ucd90320.txt    | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
> Can you make this a schema. See
> Documentation/devicetree/writing-schema.rst.
Ok, will do and submit patch set revision.
Thanks for the review,
Jim Wright
>
>> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
>> new file mode 100644
>> index 000000000000..e1c1057c6292
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
>> @@ -0,0 +1,13 @@
>> +UCD90320 power sequencer
>> +-------------------------
>> +
>> +Requires node properties:
>> +- compatible : "ti,ucd90320"
>> +- reg : the I2C address of the device. This is 0x11, 0x13, 0x17, 0x31, 0x33,
>> +        0x37, 0x71, 0x73, or 0x77.
>> +
>> +Example:
>> +	ucd90320@11 {
>> +		compatible = "ti,ucd90320";
>> +		reg = <0x11>;
>> +	};
>> -- 
>> 2.17.1
>>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
new file mode 100644
index 000000000000..e1c1057c6292
--- /dev/null
+++ b/Documentation/devicetree/bindings/hwmon/pmbus/ucd90320.txt
@@ -0,0 +1,13 @@ 
+UCD90320 power sequencer
+-------------------------
+
+Requires node properties:
+- compatible : "ti,ucd90320"
+- reg : the I2C address of the device. This is 0x11, 0x13, 0x17, 0x31, 0x33,
+        0x37, 0x71, 0x73, or 0x77.
+
+Example:
+	ucd90320@11 {
+		compatible = "ti,ucd90320";
+		reg = <0x11>;
+	};