| Message ID | 1574424534-141265-1-git-send-email-chenwandun@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | nand: onenand: samsung: remove variable 'tmp' set but not used | expand |
On Fri, 2019-11-22 at 12:08:54 UTC, Chen Wandun wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > drivers/mtd/nand/onenand/samsung_mtd.c: In function s3c_onenand_check_lock_status: > drivers/mtd/nand/onenand/samsung_mtd.c:731:6: warning: variable tmp set but not used [-Wunused-but-set-variable] > > Signed-off-by: Chen Wandun <chenwandun@huawei.com> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. Miquel
Hello, Miquel Raynal <miquel.raynal@bootlin.com> wrote on Tue, 14 Jan 2020 18:08:49 +0100: > On Fri, 2019-11-22 at 12:08:54 UTC, Chen Wandun wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/mtd/nand/onenand/samsung_mtd.c: In function s3c_onenand_check_lock_status: > > drivers/mtd/nand/onenand/samsung_mtd.c:731:6: warning: variable tmp set but not used [-Wunused-but-set-variable] > > > > Signed-off-by: Chen Wandun <chenwandun@huawei.com> > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next, thanks. As an FYI, the subject prefix should have been "mtd: onenand: samsung:". I changed it before applying. Thanks, Miquèl
diff --git a/drivers/mtd/nand/onenand/samsung_mtd.c b/drivers/mtd/nand/onenand/samsung_mtd.c index 55e5536..3573b12 100644 --- a/drivers/mtd/nand/onenand/samsung_mtd.c +++ b/drivers/mtd/nand/onenand/samsung_mtd.c @@ -728,13 +728,12 @@ static void s3c_onenand_check_lock_status(struct mtd_info *mtd) struct onenand_chip *this = mtd->priv; struct device *dev = &onenand->pdev->dev; unsigned int block, end; - int tmp; end = this->chipsize >> this->erase_shift; for (block = 0; block < end; block++) { unsigned int mem_addr = onenand->mem_addr(block, 0, 0); - tmp = s3c_read_cmd(CMD_MAP_01(onenand, mem_addr)); + s3c_read_cmd(CMD_MAP_01(onenand, mem_addr)); if (s3c_read_reg(INT_ERR_STAT_OFFSET) & LOCKED_BLK) { dev_err(dev, "block %d is write-protected!\n", block);
Fixes gcc '-Wunused-but-set-variable' warning: drivers/mtd/nand/onenand/samsung_mtd.c: In function s3c_onenand_check_lock_status: drivers/mtd/nand/onenand/samsung_mtd.c:731:6: warning: variable tmp set but not used [-Wunused-but-set-variable] Signed-off-by: Chen Wandun <chenwandun@huawei.com> --- drivers/mtd/nand/onenand/samsung_mtd.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)