Message ID | 20191122061839.24904-1-hui.song_1@nxp.com |
---|---|
State | New |
Headers | show |
Series | [v1] gpio : mpc8xxx : ls1088a/ls1028a edge detection mode bug fixs. | expand |
On Fri, Nov 22, 2019 at 7:18 AM Hui Song <hui.song_1@nxp.com> wrote: > From: Song Hui <hui.song_1@nxp.com> > > On these boards, the irq_set_type must point one valid function pointer > that can correctly set both edge and falling edge. > > Signed-off-by: Song Hui <hui.song_1@nxp.com> Patch applied! Yours, Linus Walleij
>> From: Song Hui <hui.song_1@nxp.com> >> >> On these boards, the irq_set_type must point one valid function >> pointer >> that can correctly set both edge and falling edge. >> >> Signed-off-by: Song Hui <hui.song_1@nxp.com> > > Patch applied! > > Yours, > Linus Walleij mhh.. this bug should already be fixed in a better way with [1]: gpio: mpc8xxx: Don't overwrite default irq_set_type callback -michael [1] https://lore.kernel.org/lkml/CACRpkdZ5eWHEV-oN77QxH9X4DZRUB3zM=gP=+rM=ZLAX6Wxw9w@mail.gmail.com/
On Fri, Nov 22, 2019 at 2:08 PM Michael Walle <michael@walle.cc> wrote: > >> From: Song Hui <hui.song_1@nxp.com> > >> > >> On these boards, the irq_set_type must point one valid function > >> pointer > >> that can correctly set both edge and falling edge. > >> > >> Signed-off-by: Song Hui <hui.song_1@nxp.com> > > > > Patch applied! > > > > Yours, > > Linus Walleij > > mhh.. this bug should already be fixed in a better way with [1]: > gpio: mpc8xxx: Don't overwrite default irq_set_type callback OK I drop this patch. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c index 81f0f31..8ddb23b 100644 --- a/drivers/gpio/gpio-mpc8xxx.c +++ b/drivers/gpio/gpio-mpc8xxx.c @@ -296,6 +296,7 @@ static const struct mpc8xxx_gpio_devtype mpc512x_gpio_devtype = { static const struct mpc8xxx_gpio_devtype ls1028a_gpio_devtype = { .gpio_dir_in_init = ls1028a_gpio_dir_in_init, + .irq_set_type = mpc8xxx_irq_set_type, }; static const struct mpc8xxx_gpio_devtype mpc5125_gpio_devtype = {