[2/4] i2c: i2c-cros-ec-tunnel: Fix ACPI identifier
diff mbox series

Message ID 20191121140830.2.I68b9a92ed4def031c3f247d3b49996a2512d762d@changeid
State New
Headers show
Series
  • Convert cros-ec-i2c-tunnel to MFD Cell
Related show

Commit Message

Raul E Rangel Nov. 21, 2019, 9:10 p.m. UTC
The initial patch was using the incorrect identifier.

Signed-off-by: Raul E Rangel <rrangel@chromium.org>
---
There are currently no boards using the identifier so it's fine to
change it.

 drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Enric Balletbo i Serra Nov. 25, 2019, 4:23 p.m. UTC | #1
Hi Raul,

On 21/11/19 22:10, Raul E Rangel wrote:
> The initial patch was using the incorrect identifier.
> 
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> ---
> There are currently no boards using the identifier so it's fine to
> change it.
> 

Right, I don't see GOOG001A being used but also I don't see GOOG0012. Anyway,
for the CrOS EC side, the change looks good to me. I think this will go through
the I2C tree?

Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

Thanks,
 Enric

>  drivers/i2c/busses/i2c-cros-ec-tunnel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index ac2412755f0a..5d91e33eb600 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -299,7 +299,7 @@ static const struct of_device_id cros_ec_i2c_of_match[] = {
>  MODULE_DEVICE_TABLE(of, cros_ec_i2c_of_match);
>  
>  static const struct acpi_device_id cros_ec_i2c_tunnel_acpi_id[] = {
> -	{ "GOOG001A", 0 },
> +	{ "GOOG0012", 0 },
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(acpi, cros_ec_i2c_tunnel_acpi_id);
>
Raul E Rangel Nov. 25, 2019, 6:12 p.m. UTC | #2
On Mon, Nov 25, 2019 at 9:23 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Raul,
>
> On 21/11/19 22:10, Raul E Rangel wrote:
> > The initial patch was using the incorrect identifier.
> >
> > Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> > ---
> > There are currently no boards using the identifier so it's fine to
> > change it.
> >
>
> Right, I don't see GOOG001A being used but also I don't see GOOG0012. Anyway,
> for the CrOS EC side, the change looks good to me. I think this will go through
> the I2C tree?
>
Is you were curious, here is the firmware patch:
https://chromium-review.googlesource.com/c/chromiumos/third_party/coreboot/+/1928674

Patch
diff mbox series

diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
index ac2412755f0a..5d91e33eb600 100644
--- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
+++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
@@ -299,7 +299,7 @@  static const struct of_device_id cros_ec_i2c_of_match[] = {
 MODULE_DEVICE_TABLE(of, cros_ec_i2c_of_match);
 
 static const struct acpi_device_id cros_ec_i2c_tunnel_acpi_id[] = {
-	{ "GOOG001A", 0 },
+	{ "GOOG0012", 0 },
 	{ }
 };
 MODULE_DEVICE_TABLE(acpi, cros_ec_i2c_tunnel_acpi_id);