dt-bindings: Add vendor prefix for BeagleBoard.org
diff mbox series

Message ID 20191121190124.1936-1-jdk@ti.com
State Superseded
Headers show
Series
  • dt-bindings: Add vendor prefix for BeagleBoard.org
Related show

Checks

Context Check Description
robh/dt-meta-schema success
robh/checkpatch warning "total: 0 errors, 1 warnings, 8 lines checked"

Commit Message

Jason Kridner Nov. 21, 2019, 7:01 p.m. UTC
Add vendor prefix for BeagleBoard.org Foundation

Signed-off-by: Jason Kridner <jdk@ti.com>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring Nov. 21, 2019, 11:16 p.m. UTC | #1
On Thu, Nov 21, 2019 at 1:02 PM Jason Kridner <jkridner@gmail.com> wrote:
>
> Add vendor prefix for BeagleBoard.org Foundation
>
> Signed-off-by: Jason Kridner <jdk@ti.com>

Author and Sob emails don't match.

> ---
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 967e78c5ec0a..3e3d8e3c28d3 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -139,6 +139,8 @@ patternProperties:
>      description: Shenzhen AZW Technology Co., Ltd.
>    "^bananapi,.*":
>      description: BIPAI KEJI LIMITED
> +  "^beagleboard.org,.*":

'.' would need need to be escaped as this is a regex.

The '.' may cause some problems with schemas. We can adapt or just
drop the '.org'.

> +    description: BeagleBoard.org Foundation
>    "^bhf,.*":
>      description: Beckhoff Automation GmbH & Co. KG
>    "^bitmain,.*":
> --
> 2.17.1
>
Jason Kridner Nov. 21, 2019, 11:42 p.m. UTC | #2
On Thu, Nov 21, 2019 at 6:17 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Thu, Nov 21, 2019 at 1:02 PM Jason Kridner <jkridner@gmail.com> wrote:
> >
> > Add vendor prefix for BeagleBoard.org Foundation
> >
> > Signed-off-by: Jason Kridner <jdk@ti.com>
>
> Author and Sob emails don't match.

I'll set the from address to jdk@ti.com in another submission.

>
> > ---
> >  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > index 967e78c5ec0a..3e3d8e3c28d3 100644
> > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> > @@ -139,6 +139,8 @@ patternProperties:
> >      description: Shenzhen AZW Technology Co., Ltd.
> >    "^bananapi,.*":
> >      description: BIPAI KEJI LIMITED
> > +  "^beagleboard.org,.*":
>
> '.' would need need to be escaped as this is a regex.
>
> The '.' may cause some problems with schemas. We can adapt or just
> drop the '.org'.
>

I tried to run some YAML syntax checkers and they didn't like a
backslash ('\') before the period ('.').  YAML specification
documentation didn't specify how to escape a period.

My preference is to keep beagleboard.org, but, out of simplicity and
brevity, I can resubmit without it.

The device tree submission for BeagleBone AI will need to updated accordingly.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index 967e78c5ec0a..3e3d8e3c28d3 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -139,6 +139,8 @@  patternProperties:
     description: Shenzhen AZW Technology Co., Ltd.
   "^bananapi,.*":
     description: BIPAI KEJI LIMITED
+  "^beagleboard.org,.*":
+    description: BeagleBoard.org Foundation
   "^bhf,.*":
     description: Beckhoff Automation GmbH & Co. KG
   "^bitmain,.*":