[v2,1/2] dt-bindings: arm: Add Google Coral Edge TPU entry
diff mbox series

Message ID 20191121162520.10120-1-marco.franchi@nxp.com
State Superseded
Headers show
Series
  • [v2,1/2] dt-bindings: arm: Add Google Coral Edge TPU entry
Related show

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 7 lines checked"

Commit Message

Marco Antonio Franchi Nov. 21, 2019, 4:25 p.m. UTC
Add Google Coral Edge TPU, named as imx8mq-phanbell, to the
imx8mq supported devices.

Signed-off-by: Marco Franchi <marco.franchi@nxp.com>
---
Changes since v1:
- none

 Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam Nov. 21, 2019, 6:19 p.m. UTC | #1
On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
<marco.franchi@nxp.com> wrote:
>
> Add Google Coral Edge TPU, named as imx8mq-phanbell, to the
> imx8mq supported devices.
>
> Signed-off-by: Marco Franchi <marco.franchi@nxp.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Fabio Estevam Nov. 21, 2019, 6:22 p.m. UTC | #2
Hi Marco,

On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
<marco.franchi@nxp.com> wrote:
>
> This patch adds the device tree to support Google Coral Edge TPU,
> historicaly named as fsl-imx8mq-phanbell, a computer on module
> which can be used for AI/ML propose.
>
> It introduces a minimal enablement support for this module and
> was totally based on the NXP i.MX 8MQ EVK board and i.MX 8MQ Phanbell

Please remove the "totally based on the NXP i.MX 8MQ EVK board" as
they are different boards.

> +       memory@40000000 {
> +               device_type = "memory";
> +               reg = <0x00000000 0x40000000 0 0xc0000000>;

The memory size here does not match with the one used in the Google repo.

With these changes you can add:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Marco Franchi Nov. 22, 2019, 11:56 a.m. UTC | #3
Hi Fabio,

Em qui., 21 de nov. de 2019 às 15:22, Fabio Estevam
<festevam@gmail.com> escreveu:
>
> Hi Marco,
>
> On Thu, Nov 21, 2019 at 1:25 PM Marco Antonio Franchi
> <marco.franchi@nxp.com> wrote:
> >
> > This patch adds the device tree to support Google Coral Edge TPU,
> > historicaly named as fsl-imx8mq-phanbell, a computer on module
> > which can be used for AI/ML propose.
> >
> > It introduces a minimal enablement support for this module and
> > was totally based on the NXP i.MX 8MQ EVK board and i.MX 8MQ Phanbell
>
> Please remove the "totally based on the NXP i.MX 8MQ EVK board" as
> they are different boards.
>
> > +       memory@40000000 {
> > +               device_type = "memory";
> > +               reg = <0x00000000 0x40000000 0 0xc0000000>;
>
> The memory size here does not match with the one used in the Google repo.
Thanks.
>
> With these changes you can add:
>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
Ok, I will add it at the v3.

Best regards,
Marco

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index f79683a628f0..5d24bd3ecc81 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -284,6 +284,7 @@  properties:
           - enum:
               - boundary,imx8mq-nitrogen8m # i.MX8MQ NITROGEN Board
               - fsl,imx8mq-evk            # i.MX8MQ EVK Board
+              - google,imx8mq-phanbell    # Google Coral Edge TPU
               - purism,librem5-devkit     # Purism Librem5 devkit
               - solidrun,hummingboard-pulse # SolidRun Hummingboard Pulse
               - technexion,pico-pi-imx8m  # TechNexion PICO-PI-8M evk