| Message ID | 0102016e8e6136ac-bac25e80-77ca-4f33-b372-d724e95ad241-000000@eu-west-1.amazonses.com |
|---|---|
| State | Accepted |
| Commit | 66b3ccc8f7d82afc568e66092aa7630428ad7750 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot,v2,1/3] tools: checkpatch: Restore 'debug' and 'printf' to logFunctions list | expand |
On Thu, Nov 21, 2019 at 02:32:46PM +0000, James Byrne wrote: > The 'debug' and 'printf' functions were previously added to the list of > logFunctions in commit 0cab42110dbf ("checkpatch.pl: Add 'debug' to > the list of logFunctions") and commit 397bfd4642c1 ("checkpatch.pl: > Add 'printf' to logFunctions") but these additions were lost when newer > versions of checkpatch were pulled in from the upstream Linux > kernel version. > > This restores them so that you don't end up in a situation where > checkpatch will give a warning for "quoted string split across lines" > which you cannot fix without getting a warning for "line over 80 > characters" instead. > > Signed-off-by: James Byrne <james.byrne@origamienergy.com> Applied to u-boot/master, thanks!
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 6fcc66afb0..c2641bc995 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -464,6 +464,8 @@ our $logFunctions = qr{(?x: TP_printk| WARN(?:_RATELIMIT|_ONCE|)| panic| + debug| + printf| MODULE_[A-Z_]+| seq_vprintf|seq_printf|seq_puts )};
The 'debug' and 'printf' functions were previously added to the list of logFunctions in commit 0cab42110dbf ("checkpatch.pl: Add 'debug' to the list of logFunctions") and commit 397bfd4642c1 ("checkpatch.pl: Add 'printf' to logFunctions") but these additions were lost when newer versions of checkpatch were pulled in from the upstream Linux kernel version. This restores them so that you don't end up in a situation where checkpatch will give a warning for "quoted string split across lines" which you cannot fix without getting a warning for "line over 80 characters" instead. Signed-off-by: James Byrne <james.byrne@origamienergy.com> --- Changes in v2: None scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+)