| Message ID | 20191121142726.22856-3-TheSven73@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | tps6105x add devicetree and leds support | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Thu, 21 Nov 2019 09:27:26 -0500, Sven Van Asbroeck wrote: > The driver has been extended to optionally get its operational > mode, regulator init data and led naming from the devicetree. > > Tree: next-20191118 > Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com> > --- > .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++++++++++- > 1 file changed, 46 insertions(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
On Thu, 21 Nov 2019, Sven Van Asbroeck wrote: > The driver has been extended to optionally get its operational > mode, regulator init data and led naming from the devicetree. s/led/LED/ > Tree: next-20191118 Why is this in your commit message? > Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com> > --- > .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++++++++++- > 1 file changed, 46 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mfd/tps6105x.txt b/Documentation/devicetree/bindings/mfd/tps6105x.txt > index 93602c7a19c8..1fc9aa3ed882 100644 > --- a/Documentation/devicetree/bindings/mfd/tps6105x.txt > +++ b/Documentation/devicetree/bindings/mfd/tps6105x.txt > @@ -7,11 +7,56 @@ Required properties: > - compatible: "ti,tps61050" or "ti,tps61052" > - reg: Specifies the I2C slave address > > -Example: > +Optional sub-node: > + > +This subnode selects the chip's operational mode. > +There can be at most one single available subnode. > + > +- regulator: presence of this sub-node puts the chip in regulator mode. > + see Documentation/devicetree/bindings/regulator/regulator.txt > + > +- led: presence of this sub-node puts the chip in led mode. > + Optional properties: > + - function : see Documentation/devicetree/bindings/leds/common.txt > + - color : see Documentation/devicetree/bindings/leds/common.txt > + - label : see Documentation/devicetree/bindings/leds/common.txt > + (deprecated) Nit: Could you please use relative paths here. If you line up the ':', it would look slightly cleaner.
Hi Lee, thank you for the review. On Mon, Dec 9, 2019 at 7:32 AM Lee Jones <lee.jones@linaro.org> wrote: > > > Tree: next-20191118 > > Why is this in your commit message? I have been posting patches against various maintainer trees lately, which will not apply to mainline or next. So I have been including base tree information in the patch itself. Base-tree info on patches is high on developers' wish list, but not yet standardized. This was discussed at the 2019 kernel maintainers summit: https://lwn.net/Articles/803619/
On Mon, 09 Dec 2019, Sven Van Asbroeck wrote: > Hi Lee, thank you for the review. > > On Mon, Dec 9, 2019 at 7:32 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > > Tree: next-20191118 > > > > Why is this in your commit message? > > I have been posting patches against various maintainer trees lately, which > will not apply to mainline or next. So I have been including base tree > information in the patch itself. > > Base-tree info on patches is high on developers' wish list, but not yet > standardized. This was discussed at the 2019 kernel maintainers > summit: > https://lwn.net/Articles/803619/ NB: I haven't seen this discussion (or opened this link just yet). It's no problem to have it in the submission, but it would be better to have it *below* the '--' with the diff, such that if it is applied, it doesn't end up in the kernel's Git history.
On Tue, 10 Dec 2019, Lee Jones wrote: > On Mon, 09 Dec 2019, Sven Van Asbroeck wrote: > > > Hi Lee, thank you for the review. > > > > On Mon, Dec 9, 2019 at 7:32 AM Lee Jones <lee.jones@linaro.org> wrote: > > > > > > > Tree: next-20191118 > > > > > > Why is this in your commit message? > > > > I have been posting patches against various maintainer trees lately, which > > will not apply to mainline or next. So I have been including base tree > > information in the patch itself. > > > > Base-tree info on patches is high on developers' wish list, but not yet > > standardized. This was discussed at the 2019 kernel maintainers > > summit: > > https://lwn.net/Articles/803619/ > > NB: I haven't seen this discussion (or opened this link just yet). > > It's no problem to have it in the submission, but it would be better > to have it *below* the '--' with the diff, such that if it is applied, > it doesn't end up in the kernel's Git history. Obviously that was meant to be '---'.
diff --git a/Documentation/devicetree/bindings/mfd/tps6105x.txt b/Documentation/devicetree/bindings/mfd/tps6105x.txt index 93602c7a19c8..1fc9aa3ed882 100644 --- a/Documentation/devicetree/bindings/mfd/tps6105x.txt +++ b/Documentation/devicetree/bindings/mfd/tps6105x.txt @@ -7,11 +7,56 @@ Required properties: - compatible: "ti,tps61050" or "ti,tps61052" - reg: Specifies the I2C slave address -Example: +Optional sub-node: + +This subnode selects the chip's operational mode. +There can be at most one single available subnode. + +- regulator: presence of this sub-node puts the chip in regulator mode. + see Documentation/devicetree/bindings/regulator/regulator.txt + +- led: presence of this sub-node puts the chip in led mode. + Optional properties: + - function : see Documentation/devicetree/bindings/leds/common.txt + - color : see Documentation/devicetree/bindings/leds/common.txt + - label : see Documentation/devicetree/bindings/leds/common.txt + (deprecated) + +Example (GPIO operation only): + +i2c0 { + tps61052@33 { + compatible = "ti,tps61052"; + reg = <0x33>; + }; +}; + +Example (GPIO + regulator operation): i2c0 { tps61052@33 { compatible = "ti,tps61052"; reg = <0x33>; + + regulator { + regulator-min-microvolt = <5000000>; + regulator-max-microvolt = <5000000>; + regulator-always-on; + }; + }; +}; + +Example (GPIO + led operation): + +#include <dt-bindings/leds/common.h> + +i2c0 { + tps61052@33 { + compatible = "ti,tps61052"; + reg = <0x33>; + + led { + color = <LED_COLOR_ID_WHITE>; + }; }; };
The driver has been extended to optionally get its operational mode, regulator init data and led naming from the devicetree. Tree: next-20191118 Signed-off-by: Sven Van Asbroeck <TheSven73@gmail.com> --- .../devicetree/bindings/mfd/tps6105x.txt | 47 ++++++++++++++++++- 1 file changed, 46 insertions(+), 1 deletion(-)