[v2,07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
diff mbox series

Message ID 20191121102324.35225-8-jerry.huang@nxp.com
State Changes Requested
Headers show
Series
  • new board ls1028ardb introduced
Related show

Commit Message

Jerry Huang Nov. 21, 2019, 10:23 a.m. UTC
From: Jerry Huang <jerry.huang@nxp.com>

This package provides the firmware for LS1028ARDB DP (display port).

Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
---
changes since v1:
1. rename the package to fsl-qoriq-cadence-dp-fw
2. update DEVELOPERS
3. add the hash of package
4. modify the context fo config file to package name
5. re-write the makefile according to rule of buildroot
6. add the license message in makefile
---
 DEVELOPERS                                    |  3 +++
 package/freescale-qoriq/Config.in             |  2 ++
 .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
 .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
 .../fsl-qoriq-cadence-dp-fw.mk                | 24 +++++++++++++++++++
 5 files changed, 36 insertions(+)
 create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
 create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
 create mode 100644 package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk

Comments

Michael Walle Nov. 21, 2019, 10:42 a.m. UTC | #1
Am 2019-11-21 11:23, schrieb Changming Huang:
> From: Jerry Huang <jerry.huang@nxp.com>
> 
> This package provides the firmware for LS1028ARDB DP (display port).
> 
> Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> ---
> changes since v1:
> 1. rename the package to fsl-qoriq-cadence-dp-fw

All other firmware's in buildroot have a "-firmware" suffix.

> 2. update DEVELOPERS
> 3. add the hash of package
> 4. modify the context fo config file to package name
> 5. re-write the makefile according to rule of buildroot
> 6. add the license message in makefile
> ---
>  DEVELOPERS                                    |  3 +++
>  package/freescale-qoriq/Config.in             |  2 ++
>  .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
>  .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
>  .../fsl-qoriq-cadence-dp-fw.mk                | 24 +++++++++++++++++++
>  5 files changed, 36 insertions(+)
>  create mode 100644 
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>  create mode 100644
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
>  create mode 100644
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9fbe229eb7..b15115f507 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2545,3 +2545,6 @@ F:	package/qjson/
>  F:	package/quazip/
>  F:	package/shapelib/
>  F:	package/tinc/
> +
> +N:	Changming Huang <jerry.huang@nxp.com>
> +F:	package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
> diff --git a/package/freescale-qoriq/Config.in
> b/package/freescale-qoriq/Config.in
> index 51497c588e..89f575a344 100644
> --- a/package/freescale-qoriq/Config.in
> +++ b/package/freescale-qoriq/Config.in
> @@ -1,4 +1,6 @@
>  menu "Freescale QorIQ libraries"
>  	depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc
> 
> +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
> +
>  endmenu
> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> new file mode 100644
> index 0000000000..9259776750
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> +	bool "FSL QorIQ cadence DP firmware"
> +	help
> +	  FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> +	  link: 
> http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
> diff --git
> a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> new file mode 100644
> index 0000000000..bee912bee1
> --- /dev/null
> +++
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256
> 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> firmware-cadence-lsdk1909.bin
> diff --git
> a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> new file mode 100644
> index 0000000000..d0d112e25f
> --- /dev/null
> +++ 
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# fsl-qoriq-cadence-dp-fw
> +#
> +################################################################################
> +
> +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> +
> +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> +	cd $(@D); \
> +		sh
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE)
> --auto-accept;
> +endef
> +
> +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
> +	$(INSTALL) -D -m 0644
> $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin
> $(BINARIES_DIR)/ls1028a-dp-fw.bin
> +endef

IMHO this should be also installed into the target filesystem. So the 
driver can
request the firmware binary. I know that this is not how NXP handles 
that at the
moment. But in the end, that should be the way to go, esp. since 
rockchip seems
to have the same/similar DP-PHY with a corresponding driver upstream and 
they are
already loading the firmware via request_firmware().

> +
> +$(eval $(generic-package))

-michael
Michael Walle Nov. 21, 2019, 10:51 a.m. UTC | #2
Am 2019-11-21 11:23, schrieb Changming Huang:
> From: Jerry Huang <jerry.huang@nxp.com>
> 
> This package provides the firmware for LS1028ARDB DP (display port).
> 
> Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> ---
> changes since v1:
> 1. rename the package to fsl-qoriq-cadence-dp-fw
> 2. update DEVELOPERS
> 3. add the hash of package
> 4. modify the context fo config file to package name
> 5. re-write the makefile according to rule of buildroot
> 6. add the license message in makefile
> ---
>  DEVELOPERS                                    |  3 +++
>  package/freescale-qoriq/Config.in             |  2 ++
>  .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
>  .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
>  .../fsl-qoriq-cadence-dp-fw.mk                | 24 +++++++++++++++++++
>  5 files changed, 36 insertions(+)
>  create mode 100644 
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>  create mode 100644
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
>  create mode 100644
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9fbe229eb7..b15115f507 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2545,3 +2545,6 @@ F:	package/qjson/
>  F:	package/quazip/
>  F:	package/shapelib/
>  F:	package/tinc/
> +
> +N:	Changming Huang <jerry.huang@nxp.com>
> +F:	package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
> diff --git a/package/freescale-qoriq/Config.in
> b/package/freescale-qoriq/Config.in
> index 51497c588e..89f575a344 100644
> --- a/package/freescale-qoriq/Config.in
> +++ b/package/freescale-qoriq/Config.in
> @@ -1,4 +1,6 @@
>  menu "Freescale QorIQ libraries"
>  	depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc
> 
> +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
> +
>  endmenu
> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> new file mode 100644
> index 0000000000..9259776750
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> +	bool "FSL QorIQ cadence DP firmware"
> +	help
> +	  FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> +	  link: 
> http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
> diff --git
> a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> new file mode 100644
> index 0000000000..bee912bee1
> --- /dev/null
> +++
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256
> 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> firmware-cadence-lsdk1909.bin
> diff --git
> a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> new file mode 100644
> index 0000000000..d0d112e25f
> --- /dev/null
> +++ 
> b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# fsl-qoriq-cadence-dp-fw
> +#
> +################################################################################
> +
> +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> +
> +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> +	cd $(@D); \
> +		sh
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE)
> --auto-accept;
> +endef

There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that 
should be renamed and used here.

-michael
Jerry Huang Nov. 21, 2019, 11:04 a.m. UTC | #3
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Thursday, November 21, 2019 6:43 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot@busybox.net; geomatsi@gmail.com;
> matthew.weber@collins.com; thomas.petazzoni@bootlin.com
> Subject: [EXT] Re: [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Am 2019-11-21 11:23, schrieb Changming Huang:
> > From: Jerry Huang <jerry.huang@nxp.com>
> >
> > This package provides the firmware for LS1028ARDB DP (display port).
> >
> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> > ---
> > changes since v1:
> > 1. rename the package to fsl-qoriq-cadence-dp-fw
> 
> All other firmware's in buildroot have a "-firmware" suffix.
Because the name is too long if I use the full name "freescale-qoriq-cadence-dp-firmware",
So I used short name "fsl" prefix to replace freescale and "fw" suffix to release firmware.
If necessary, I can use the full name, instead of short name.

> > 2. update DEVELOPERS
> > 3. add the hash of package
> > 4. modify the context fo config file to package name 5. re-write the
> > makefile according to rule of buildroot 6. add the license message in
> > makefile
> > ---
> >  DEVELOPERS                                    |  3 +++
> >  package/freescale-qoriq/Config.in             |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
> >  .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw.mk                | 24
> +++++++++++++++++++
> >  5 files changed, 36 insertions(+)
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.hash
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 9fbe229eb7..b15115f507 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
> >  F:   package/quazip/
> >  F:   package/shapelib/
> >  F:   package/tinc/
> > +
> > +N:   Changming Huang <jerry.huang@nxp.com>
> > +F:   package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
> > diff --git a/package/freescale-qoriq/Config.in
> > b/package/freescale-qoriq/Config.in
> > index 51497c588e..89f575a344 100644
> > --- a/package/freescale-qoriq/Config.in
> > +++ b/package/freescale-qoriq/Config.in
> > @@ -1,4 +1,6 @@
> >  menu "Freescale QorIQ libraries"
> >       depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
> > BR2_powerpc
> >
> > +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
> > +
> >  endmenu
> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > new file mode 100644
> > index 0000000000..9259776750
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > @@ -0,0 +1,5 @@
> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> > +     bool "FSL QorIQ cadence DP firmware"
> > +     help
> > +       FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> > +       link:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.n
> >
> xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&amp;
> >
> data=02%7C01%7Cjerry.huang%40nxp.com%7Ca71c7361a8eb40680c9908d76e
> 6f8d1
> >
> e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370992977061416
> 81&amp;
> >
> sdata=cjWdcvyCKsIcw5qV5x%2BJEvVCiFuMeyBNprHm582rkws%3D&amp;reser
> ved=0
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > new file mode 100644
> > index 0000000000..bee912bee1
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256
> > 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> > firmware-cadence-lsdk1909.bin
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > new file mode 100644
> > index 0000000000..d0d112e25f
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > @@ -0,0 +1,24 @@
> >
> +###############################################################
> ######
> > +###########
> > +#
> > +# fsl-qoriq-cadence-dp-fw
> > +#
> >
> +###############################################################
> ######
> > +###########
> > +
> > +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> > +FSL_QORIQ_CADENCE_DP_FW_SITE =
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> >
> +nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&amp;data=02%7C01%7Cjerry.huang%
> 40n
> >
> +xp.com%7Ca71c7361a8eb40680c9908d76e6f8d1e%7C686ea1d3bc2b4c6fa92c
> d99c5
> >
> +c301635%7C0%7C0%7C637099297706141681&amp;sdata=N1ZBA4m%2F%2F
> CF7WjNa5j
> > +XkfrnIastkxjHwoSO8G9%2BZcnk%3D&amp;reserved=0
> > +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> > firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> > +     cd $(@D); \
> > +             sh
> >
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
> URCE)
> > --auto-accept;
> > +endef
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
> > +     $(INSTALL) -D -m 0644
> > $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin
> > $(BINARIES_DIR)/ls1028a-dp-fw.bin
> > +endef
> 
> IMHO this should be also installed into the target filesystem. So the driver can
> request the firmware binary. I know that this is not how NXP handles that at the
> moment. But in the end, that should be the way to go, esp. since rockchip seems
> to have the same/similar DP-PHY with a corresponding driver upstream and
> they are already loading the firmware via request_firmware().
Yes, this firmware can be into target filesystem, but the driver should be built as module.
If driver is built-in Linux kernel, we need to load this firmware before starting kernel.
Now ls1028ardb uses the build-in mode for DP driver, so I can't put it into target filesystem,
And load it in uboot prompt before starting kernel.

> > +
> > +$(eval $(generic-package))
> 
> -michael
Jerry Huang Nov. 21, 2019, 11:09 a.m. UTC | #4
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Thursday, November 21, 2019 6:52 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot@busybox.net; geomatsi@gmail.com;
> matthew.weber@collins.com; thomas.petazzoni@bootlin.com
> Subject: [EXT] Re: [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Am 2019-11-21 11:23, schrieb Changming Huang:
> > From: Jerry Huang <jerry.huang@nxp.com>
> >
> > This package provides the firmware for LS1028ARDB DP (display port).
> >
> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> > ---
> > changes since v1:
> > 1. rename the package to fsl-qoriq-cadence-dp-fw 2. update DEVELOPERS
> > 3. add the hash of package 4. modify the context fo config file to
> > package name 5. re-write the makefile according to rule of buildroot
> > 6. add the license message in makefile
> > ---
> >  DEVELOPERS                                    |  3 +++
> >  package/freescale-qoriq/Config.in             |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
> >  .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw.mk                | 24
> +++++++++++++++++++
> >  5 files changed, 36 insertions(+)
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.hash
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 9fbe229eb7..b15115f507 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
> >  F:   package/quazip/
> >  F:   package/shapelib/
> >  F:   package/tinc/
> > +
> > +N:   Changming Huang <jerry.huang@nxp.com>
> > +F:   package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
> > diff --git a/package/freescale-qoriq/Config.in
> > b/package/freescale-qoriq/Config.in
> > index 51497c588e..89f575a344 100644
> > --- a/package/freescale-qoriq/Config.in
> > +++ b/package/freescale-qoriq/Config.in
> > @@ -1,4 +1,6 @@
> >  menu "Freescale QorIQ libraries"
> >       depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
> > BR2_powerpc
> >
> > +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
> > +
> >  endmenu
> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > new file mode 100644
> > index 0000000000..9259776750
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > @@ -0,0 +1,5 @@
> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> > +     bool "FSL QorIQ cadence DP firmware"
> > +     help
> > +       FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> > +       link:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.n
> >
> xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&amp;
> >
> data=02%7C01%7Cjerry.huang%40nxp.com%7C8af29f72a8524b1f700608d76e7
> 0ce5
> >
> c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370993030840248
> 67&amp;
> >
> sdata=uSC8EhBphE5cLuUGjHWvGyRgNCs3kdPKUe3xBgAna3U%3D&amp;reserv
> ed=0
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > new file mode 100644
> > index 0000000000..bee912bee1
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256
> > 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> > firmware-cadence-lsdk1909.bin
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > new file mode 100644
> > index 0000000000..d0d112e25f
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > @@ -0,0 +1,24 @@
> >
> +###############################################################
> ######
> > +###########
> > +#
> > +# fsl-qoriq-cadence-dp-fw
> > +#
> >
> +###############################################################
> ######
> > +###########
> > +
> > +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> > +FSL_QORIQ_CADENCE_DP_FW_SITE =
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> >
> +nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&amp;data=02%7C01%7Cjerry.huang%
> 40n
> >
> +xp.com%7C8af29f72a8524b1f700608d76e70ce5c%7C686ea1d3bc2b4c6fa92c
> d99c5
> >
> +c301635%7C0%7C0%7C637099303084024867&amp;sdata=efvW3VQKOjQPq5
> 5%2BMpeu
> > +uARsbNMl0NV99IwR1ylN9vs%3D&amp;reserved=0
> > +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> > firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> > +     cd $(@D); \
> > +             sh
> >
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
> URCE)
> > --auto-accept;
> > +endef
> 
> There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
> should be renamed and used here.
It is ok for me.

Hi, Thomas,
How do you think about it?

> -michael
Jerry Huang Nov. 22, 2019, 10:40 a.m. UTC | #5
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Thursday, November 21, 2019 6:52 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot@busybox.net; geomatsi@gmail.com;
> matthew.weber@collins.com; thomas.petazzoni@bootlin.com
> Subject: [EXT] Re: [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Am 2019-11-21 11:23, schrieb Changming Huang:
> > From: Jerry Huang <jerry.huang@nxp.com>
> >
> > This package provides the firmware for LS1028ARDB DP (display port).
> >
> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> > ---
> > changes since v1:
> > 1. rename the package to fsl-qoriq-cadence-dp-fw 2. update DEVELOPERS
> > 3. add the hash of package 4. modify the context fo config file to
> > package name 5. re-write the makefile according to rule of buildroot
> > 6. add the license message in makefile
> > ---
> >  DEVELOPERS                                    |  3 +++
> >  package/freescale-qoriq/Config.in             |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
> >  .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw.mk                | 24
> +++++++++++++++++++
> >  5 files changed, 36 insertions(+)
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.hash
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 9fbe229eb7..b15115f507 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
> >  F:   package/quazip/
> >  F:   package/shapelib/
> >  F:   package/tinc/
> > +
> > +N:   Changming Huang <jerry.huang@nxp.com>
> > +F:   package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
> > diff --git a/package/freescale-qoriq/Config.in
> > b/package/freescale-qoriq/Config.in
> > index 51497c588e..89f575a344 100644
> > --- a/package/freescale-qoriq/Config.in
> > +++ b/package/freescale-qoriq/Config.in
> > @@ -1,4 +1,6 @@
> >  menu "Freescale QorIQ libraries"
> >       depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
> > BR2_powerpc
> >
> > +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
> > +
> >  endmenu
> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > new file mode 100644
> > index 0000000000..9259776750
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > @@ -0,0 +1,5 @@
> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> > +     bool "FSL QorIQ cadence DP firmware"
> > +     help
> > +       FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> > +       link:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.n
> >
> xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&amp;
> >
> data=02%7C01%7Cjerry.huang%40nxp.com%7C8af29f72a8524b1f700608d76e7
> 0ce5
> >
> c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370993030840248
> 67&amp;
> >
> sdata=uSC8EhBphE5cLuUGjHWvGyRgNCs3kdPKUe3xBgAna3U%3D&amp;reserv
> ed=0
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > new file mode 100644
> > index 0000000000..bee912bee1
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256
> > 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> > firmware-cadence-lsdk1909.bin
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > new file mode 100644
> > index 0000000000..d0d112e25f
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > @@ -0,0 +1,24 @@
> >
> +###############################################################
> ######
> > +###########
> > +#
> > +# fsl-qoriq-cadence-dp-fw
> > +#
> >
> +###############################################################
> ######
> > +###########
> > +
> > +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> > +FSL_QORIQ_CADENCE_DP_FW_SITE =
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> >
> +nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&amp;data=02%7C01%7Cjerry.huang%
> 40n
> >
> +xp.com%7C8af29f72a8524b1f700608d76e70ce5c%7C686ea1d3bc2b4c6fa92c
> d99c5
> >
> +c301635%7C0%7C0%7C637099303084024867&amp;sdata=efvW3VQKOjQPq5
> 5%2BMpeu
> > +uARsbNMl0NV99IwR1ylN9vs%3D&amp;reserved=0
> > +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> > firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> > +     cd $(@D); \
> > +             sh
> >
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
> URCE)
> > --auto-accept;
> > +endef
> 
> There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
> should be renamed and used here.

I changed this codes accordance with freescale-imx, create new option FREESCALE_QORIQ_EXTRACT_HELPER
Will post it to maillist marked "v3"

> -michael
Jerry Huang Nov. 22, 2019, 10:41 a.m. UTC | #6
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Thursday, November 21, 2019 6:43 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot@busybox.net; geomatsi@gmail.com;
> matthew.weber@collins.com; thomas.petazzoni@bootlin.com
> Subject: [EXT] Re: [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Am 2019-11-21 11:23, schrieb Changming Huang:
> > From: Jerry Huang <jerry.huang@nxp.com>
> >
> > This package provides the firmware for LS1028ARDB DP (display port).
> >
> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> > ---
> > changes since v1:
> > 1. rename the package to fsl-qoriq-cadence-dp-fw
> 
> All other firmware's in buildroot have a "-firmware" suffix.

Will use suffix "-firmware" in v3.

> > 2. update DEVELOPERS
> > 3. add the hash of package
> > 4. modify the context fo config file to package name 5. re-write the
> > makefile according to rule of buildroot 6. add the license message in
> > makefile
> > ---
> >  DEVELOPERS                                    |  3 +++
> >  package/freescale-qoriq/Config.in             |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw/Config.in         |  5 ++++
> >  .../fsl-qoriq-cadence-dp-fw.hash              |  2 ++
> >  .../fsl-qoriq-cadence-dp-fw.mk                | 24
> +++++++++++++++++++
> >  5 files changed, 36 insertions(+)
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.hash
> >  create mode 100644
> > package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-f
> > w.mk
> >
> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 9fbe229eb7..b15115f507 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
> >  F:   package/quazip/
> >  F:   package/shapelib/
> >  F:   package/tinc/
> > +
> > +N:   Changming Huang <jerry.huang@nxp.com>
> > +F:   package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
> > diff --git a/package/freescale-qoriq/Config.in
> > b/package/freescale-qoriq/Config.in
> > index 51497c588e..89f575a344 100644
> > --- a/package/freescale-qoriq/Config.in
> > +++ b/package/freescale-qoriq/Config.in
> > @@ -1,4 +1,6 @@
> >  menu "Freescale QorIQ libraries"
> >       depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 ||
> > BR2_powerpc
> >
> > +source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
> > +
> >  endmenu
> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > new file mode 100644
> > index 0000000000..9259776750
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > @@ -0,0 +1,5 @@
> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> > +     bool "FSL QorIQ cadence DP firmware"
> > +     help
> > +       FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> > +       link:
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.n
> >
> xp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&amp;
> >
> data=02%7C01%7Cjerry.huang%40nxp.com%7Ca71c7361a8eb40680c9908d76e
> 6f8d1
> >
> e%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370992977061416
> 81&amp;
> >
> sdata=cjWdcvyCKsIcw5qV5x%2BJEvVCiFuMeyBNprHm582rkws%3D&amp;reser
> ved=0
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > new file mode 100644
> > index 0000000000..bee912bee1
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256
> > 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> > firmware-cadence-lsdk1909.bin
> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > new file mode 100644
> > index 0000000000..d0d112e25f
> > --- /dev/null
> > +++
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > @@ -0,0 +1,24 @@
> >
> +###############################################################
> ######
> > +###########
> > +#
> > +# fsl-qoriq-cadence-dp-fw
> > +#
> >
> +###############################################################
> ######
> > +###########
> > +
> > +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> > +FSL_QORIQ_CADENCE_DP_FW_SITE =
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> >
> +nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&amp;data=02%7C01%7Cjerry.huang%
> 40n
> >
> +xp.com%7Ca71c7361a8eb40680c9908d76e6f8d1e%7C686ea1d3bc2b4c6fa92c
> d99c5
> >
> +c301635%7C0%7C0%7C637099297706141681&amp;sdata=N1ZBA4m%2F%2F
> CF7WjNa5j
> > +XkfrnIastkxjHwoSO8G9%2BZcnk%3D&amp;reserved=0
> > +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> > firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> > +     cd $(@D); \
> > +             sh
> >
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
> URCE)
> > --auto-accept;
> > +endef
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
> > +     $(INSTALL) -D -m 0644
> > $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin
> > $(BINARIES_DIR)/ls1028a-dp-fw.bin
> > +endef
> 
> IMHO this should be also installed into the target filesystem. So the driver can
> request the firmware binary. I know that this is not how NXP handles that at the
> moment. But in the end, that should be the way to go, esp. since rockchip seems
> to have the same/similar DP-PHY with a corresponding driver upstream and
> they are already loading the firmware via request_firmware().
> 
> > +
> > +$(eval $(generic-package))
> 
> -michael
Michael Walle Nov. 22, 2019, 11 a.m. UTC | #7
Hi,
>> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
>> > +     cd $(@D); \
>> > +             sh
>> >
>> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
>> URCE)
>> > --auto-accept;
>> > +endef
>> 
>> There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
>> should be renamed and used here.
> 
> I changed this codes accordance with freescale-imx, create new option
> FREESCALE_QORIQ_EXTRACT_HELPER

why FREESCALE_QORIQ_EXTRACT_HELPER? are there two different ones now?
Shouldn't it be just FREESCALE_EXTRACT_HELPER? and the definition of the 
macro should be moved out of the freescale-imx.mk?

or of course, there might be another subdirectory structure like:
packages/freescale/imx
packages/freescale/qoriq
pacakges/freescale/helper.mk

Or..

packages/freescale/fsl-imx-<package>
packages/freescale/fsl-qoriq-<package>
pacakges/freescale/helper.mk

And the macro might end up in the pacakges/freescale/helper.mk file.

TBH. I guess there have to be a cleanup before adding the qoriq stuff. 
Thomas? Matthew?

-michael
Thomas Petazzoni Nov. 22, 2019, 11:05 a.m. UTC | #8
Hello,

On Fri, 22 Nov 2019 10:40:42 +0000
Jerry Huang <jerry.huang@nxp.com> wrote:

> > There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
> > should be renamed and used here.  
> 
> I changed this codes accordance with freescale-imx, create new option FREESCALE_QORIQ_EXTRACT_HELPER
> Will post it to maillist marked "v3"

Could you wait a bit before sending v3, so that some time is given for
people to review the patch series? Maybe wait until Monday.

Thanks!

Thomas
Jerry Huang Nov. 25, 2019, 2:40 a.m. UTC | #9
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Friday, November 22, 2019 7:00 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot@busybox.net; geomatsi@gmail.com;
> matthew.weber@collins.com; thomas.petazzoni@bootlin.com
> Subject: Re: [EXT] Re: [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Hi,
> >> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> >> > +     cd $(@D); \
> >> > +             sh
> >> >
> >>
> $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SO
> >> URCE)
> >> > --auto-accept;
> >> > +endef
> >>
> >> There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
> >> should be renamed and used here.
> >
> > I changed this codes accordance with freescale-imx, create new option
> > FREESCALE_QORIQ_EXTRACT_HELPER
> 
> why FREESCALE_QORIQ_EXTRACT_HELPER? are there two different ones now?
> Shouldn't it be just FREESCALE_EXTRACT_HELPER? and the definition of the
> macro should be moved out of the freescale-imx.mk?
> 
> or of course, there might be another subdirectory structure like:
> packages/freescale/imx
> packages/freescale/qoriq
> pacakges/freescale/helper.mk
I think it makes sense to create another subdirectory like this.

> Or..
> 
> packages/freescale/fsl-imx-<package>
> packages/freescale/fsl-qoriq-<package>
> pacakges/freescale/helper.mk
> 
> And the macro might end up in the pacakges/freescale/helper.mk file.
> 
> TBH. I guess there have to be a cleanup before adding the qoriq stuff.
> Thomas? Matthew?
> 
> -michael
Jerry Huang Nov. 25, 2019, 6:25 a.m. UTC | #10
Hi, Thomas and all guys,

I got some feedback from internal company, because Freescale is merged into NXP, we need to use the company NXP, instead of Freescale.
So, need some modification for all patches of the board ls1028ardb:
board/nxp
configs/nxp_ls1028ardb*
package/nxp-qoriq/

any comment about that?

Best Regards
Jerry Huang

> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Sent: Friday, November 22, 2019 7:06 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: Michael Walle <michael@walle.cc>; buildroot@busybox.net;
> geomatsi@gmail.com; matthew.weber@collins.com
> Subject: Re: [EXT] Re: [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Hello,
> 
> On Fri, 22 Nov 2019 10:40:42 +0000
> Jerry Huang <jerry.huang@nxp.com> wrote:
> 
> > > There is already an FREESCALE_IMX_EXTRACT_HELPER macro. I guess that
> > > should be renamed and used here.
> >
> > I changed this codes accordance with freescale-imx, create new option
> > FREESCALE_QORIQ_EXTRACT_HELPER Will post it to maillist marked "v3"
> 
> Could you wait a bit before sending v3, so that some time is given for people to
> review the patch series? Maybe wait until Monday.
> 
> Thanks!
> 
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
> om&amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ce3bcae6699d7446e1
> 20d08d76f3bf133%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637
> 100175553574097&amp;sdata=nymmd1QloyWLS8NkxwcTksguJfxjL7%2FafehtP
> tc%2B%2FFE%3D&amp;reserved=0
Thomas Petazzoni Nov. 25, 2019, 10:12 p.m. UTC | #11
Hello,

On Thu, 21 Nov 2019 18:23:21 +0800
Changming Huang <jerry.huang@nxp.com> wrote:

> From: Jerry Huang <jerry.huang@nxp.com>
> 
> This package provides the firmware for LS1028ARDB DP (display port).
> 
> Signed-off-by: Jerry Huang <jerry.huang@nxp.com>

Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to
use the nxp branding.

> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9fbe229eb7..b15115f507 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2545,3 +2545,6 @@ F:	package/qjson/
>  F:	package/quazip/
>  F:	package/shapelib/
>  F:	package/tinc/
> +
> +N:	Changming Huang <jerry.huang@nxp.com>

Please sort your name at the right place in the DEVELOPERS file
(alphabetic ordering).

> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> new file mode 100644
> index 0000000000..9259776750
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> +	bool "FSL QorIQ cadence DP firmware"

Just:

	bool "fsl-qorirq-cadence-dp-fw

> +	help
> +	  FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> +	  link: http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin

One empty line between the description and the upstream URL, and no
"link: " before the link. Also, pointing to the binary file itself is
not useful, we need an actual web page. If none exist, just don't
provide an upstream URL.

> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> new file mode 100644
> index 0000000000..bee912bee1
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58  firmware-cadence-lsdk1909.bin

Hash of the license file is missing.

> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> new file mode 100644
> index 0000000000..d0d112e25f
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# fsl-qoriq-cadence-dp-fw
> +#
> +################################################################################
> +
> +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SOURCE = firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no

Should be "NO" (upper_case)

> +
> +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> +	cd $(@D); \
> +		sh $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept;

Final semi-colon not needed.

> +endef
> +
> +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
> +	$(INSTALL) -D -m 0644 $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
> +endef
> +
> +$(eval $(generic-package))

Thanks!

Thomas
Jerry Huang Nov. 26, 2019, 8:09 a.m. UTC | #12
Best Regards
Jerry Huang

> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Sent: Tuesday, November 26, 2019 6:12 AM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: buildroot@busybox.net; michael@walle.cc; matthew.weber@collins.com;
> geomatsi@gmail.com
> Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Hello,
> 
> On Thu, 21 Nov 2019 18:23:21 +0800
> Changming Huang <jerry.huang@nxp.com> wrote:
> 
> > From: Jerry Huang <jerry.huang@nxp.com>
> >
> > This package provides the firmware for LS1028ARDB DP (display port).
> >
> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> 
> Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to use the nxp
> branding.
Sure, I will rename it.

> > diff --git a/DEVELOPERS b/DEVELOPERS
> > index 9fbe229eb7..b15115f507 100644
> > --- a/DEVELOPERS
> > +++ b/DEVELOPERS
> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
> >  F:   package/quazip/
> >  F:   package/shapelib/
> >  F:   package/tinc/
> > +
> > +N:   Changming Huang <jerry.huang@nxp.com>
> 
> Please sort your name at the right place in the DEVELOPERS file (alphabetic
> ordering).
sure

> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > new file mode 100644
> > index 0000000000..9259776750
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> > @@ -0,0 +1,5 @@
> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> > +     bool "FSL QorIQ cadence DP firmware"
> 
> Just:
> 
>         bool "fsl-qorirq-cadence-dp-fw
Sure,

> > +     help
> > +       FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> > +       link:
> > + https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
> >
> + .nxp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
> > +
> amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ce1898ecb342d4abee75c0
> 8d77
> > +
> 1f48c4c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63710316744
> 6779
> > +
> 441&amp;sdata=%2FM0R2H%2BoS5qxxyzQLATgP7ndtCyNkzyxkFxTHgNuk2o%3
> D&amp
> > + ;reserved=0
> 
> One empty line between the description and the upstream URL, and no
> "link: " before the link. Also, pointing to the binary file itself is not useful, we
> need an actual web page. If none exist, just don't provide an upstream URL.
Remove this link

> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.hash
> > new file mode 100644
> > index 0000000000..bee912bee1
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
> > +++ e-dp-fw.hash
> > @@ -0,0 +1,2 @@
> > +# Locally calculated
> > +sha256
> >
> +5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
> > +firmware-cadence-lsdk1909.bin
> 
> Hash of the license file is missing.
Will add the hash in v3

> > diff --git
> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
> > -fw.mk
> > new file mode 100644
> > index 0000000000..d0d112e25f
> > --- /dev/null
> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
> > +++ e-dp-fw.mk
> > @@ -0,0 +1,24 @@
> >
> +###############################################################
> ######
> > +###########
> > +#
> > +# fsl-qoriq-cadence-dp-fw
> > +#
> >
> +###############################################################
> ######
> > +###########
> > +
> > +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> > +FSL_QORIQ_CADENCE_DP_FW_SITE =
> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
> >
> +nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&amp;data=02%7C01%7Cjerry.huang%
> 40n
> >
> +xp.com%7Ce1898ecb342d4abee75c08d771f48c4c%7C686ea1d3bc2b4c6fa92c
> d99c5
> >
> +c301635%7C0%7C0%7C637103167446779441&amp;sdata=pVGrODu3jQDZKQ
> cKs1zXSq
> > +ihEBQUw7Rq6C%2FRm%2Bn8FKU%3D&amp;reserved=0
> > +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
> > +firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
> 
> Should be "NO" (upper_case)
Will correct it

> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> > +     cd $(@D); \
> > +             sh
> >
> +$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_S
> OURCE)
> > +--auto-accept;
> 
> Final semi-colon not needed.
Will use below command in v3:
define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
        $(call NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE))
endef

> > +endef
> > +
> > +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
> > +     $(INSTALL) -D -m 0644
> > +$(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin
> > +$(BINARIES_DIR)/ls1028a-dp-fw.bin endef
> > +
> > +$(eval $(generic-package))
> 
> Thanks!
> 
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
> om&amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ce1898ecb342d4abee
> 75c08d771f48c4c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637
> 103167446779441&amp;sdata=VhPk%2Bg9xWrIX%2B9RTaiC3r7KJdiChr2mQ1d
> h56QLbRyA%3D&amp;reserved=0
Michael Walle Nov. 26, 2019, 9:21 a.m. UTC | #13
Am 2019-11-26 09:09, schrieb Jerry Huang:
> Best Regards
> Jerry Huang
> 
>> -----Original Message-----
>> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Sent: Tuesday, November 26, 2019 6:12 AM
>> To: Jerry Huang <jerry.huang@nxp.com>
>> Cc: buildroot@busybox.net; michael@walle.cc; 
>> matthew.weber@collins.com;
>> geomatsi@gmail.com
>> Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10]
>> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
>> 
>> Caution: EXT Email
>> 
>> Hello,
>> 
>> On Thu, 21 Nov 2019 18:23:21 +0800
>> Changming Huang <jerry.huang@nxp.com> wrote:
>> 
>> > From: Jerry Huang <jerry.huang@nxp.com>
>> >
>> > This package provides the firmware for LS1028ARDB DP (display port).
>> >
>> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
>> 
>> Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to 
>> use the nxp
>> branding.
> Sure, I will rename it.
> 
>> > diff --git a/DEVELOPERS b/DEVELOPERS
>> > index 9fbe229eb7..b15115f507 100644
>> > --- a/DEVELOPERS
>> > +++ b/DEVELOPERS
>> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
>> >  F:   package/quazip/
>> >  F:   package/shapelib/
>> >  F:   package/tinc/
>> > +
>> > +N:   Changming Huang <jerry.huang@nxp.com>
>> 
>> Please sort your name at the right place in the DEVELOPERS file 
>> (alphabetic
>> ordering).
> sure
> 
>> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>> > new file mode 100644
>> > index 0000000000..9259776750
>> > --- /dev/null
>> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>> > @@ -0,0 +1,5 @@
>> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
>> > +     bool "FSL QorIQ cadence DP firmware"
>> 
>> Just:
>> 
>>         bool "fsl-qorirq-cadence-dp-fw
> Sure,

Sorry about being so pedantic about this.. but like I said before, 
almost all (there is one exception, "murata-cyw-fw") firmware packages 
have a -firmware suffix.

-michael
Michael Walle Nov. 26, 2019, 9:29 a.m. UTC | #14
[sorry for the second mail]

Am 2019-11-26 09:09, schrieb Jerry Huang:
> Best Regards
> Jerry Huang
> 
>> -----Original Message-----
>> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>> Sent: Tuesday, November 26, 2019 6:12 AM
>> To: Jerry Huang <jerry.huang@nxp.com>
>> Cc: buildroot@busybox.net; michael@walle.cc; 
>> matthew.weber@collins.com;
>> geomatsi@gmail.com
>> Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10]
>> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
>> 
>> Caution: EXT Email
>> 
>> Hello,
>> 
>> On Thu, 21 Nov 2019 18:23:21 +0800
>> Changming Huang <jerry.huang@nxp.com> wrote:
>> 
>> > From: Jerry Huang <jerry.huang@nxp.com>
>> >
>> > This package provides the firmware for LS1028ARDB DP (display port).
>> >
>> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
>> 
>> Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to 
>> use the nxp
>> branding.
> Sure, I will rename it.
> 
>> > diff --git a/DEVELOPERS b/DEVELOPERS
>> > index 9fbe229eb7..b15115f507 100644
>> > --- a/DEVELOPERS
>> > +++ b/DEVELOPERS
>> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
>> >  F:   package/quazip/
>> >  F:   package/shapelib/
>> >  F:   package/tinc/
>> > +
>> > +N:   Changming Huang <jerry.huang@nxp.com>
>> 
>> Please sort your name at the right place in the DEVELOPERS file 
>> (alphabetic
>> ordering).
> sure
> 
>> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>> > new file mode 100644
>> > index 0000000000..9259776750
>> > --- /dev/null
>> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
>> > @@ -0,0 +1,5 @@
>> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
>> > +     bool "FSL QorIQ cadence DP firmware"
>> 
>> Just:
>> 
>>         bool "fsl-qorirq-cadence-dp-fw
> Sure,
> 
>> > +     help
>> > +       FSL QorIQ cadence DP firmware, a resident EL3 firmware.
>> > +       link:
>> > + https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww
>> >
>> + .nxp.com%2Flgfiles%2Fsdk%2Flsdk1909%2Ffirmware-cadence-lsdk1909.bin&
>> > +
>> amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ce1898ecb342d4abee75c0
>> 8d77
>> > +
>> 1f48c4c%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63710316744
>> 6779
>> > +
>> 441&amp;sdata=%2FM0R2H%2BoS5qxxyzQLATgP7ndtCyNkzyxkFxTHgNuk2o%3
>> D&amp
>> > + ;reserved=0
>> 
>> One empty line between the description and the upstream URL, and no
>> "link: " before the link. Also, pointing to the binary file itself is 
>> not useful, we
>> need an actual web page. If none exist, just don't provide an upstream 
>> URL.
> Remove this link
> 
>> > diff --git
>> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
>> > -fw.hash
>> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
>> > -fw.hash
>> > new file mode 100644
>> > index 0000000000..bee912bee1
>> > --- /dev/null
>> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
>> > +++ e-dp-fw.hash
>> > @@ -0,0 +1,2 @@
>> > +# Locally calculated
>> > +sha256
>> >
>> +5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58
>> > +firmware-cadence-lsdk1909.bin
>> 
>> Hash of the license file is missing.
> Will add the hash in v3
> 
>> > diff --git
>> > a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
>> > -fw.mk
>> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp
>> > -fw.mk
>> > new file mode 100644
>> > index 0000000000..d0d112e25f
>> > --- /dev/null
>> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadenc
>> > +++ e-dp-fw.mk
>> > @@ -0,0 +1,24 @@
>> >
>> +###############################################################
>> ######
>> > +###########
>> > +#
>> > +# fsl-qoriq-cadence-dp-fw
>> > +#
>> >
>> +###############################################################
>> ######
>> > +###########
>> > +
>> > +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
>> > +FSL_QORIQ_CADENCE_DP_FW_SITE =
>> > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.
>> >
>> +nxp.com%2Flgfiles%2Fsdk%2Flsdk1909&amp;data=02%7C01%7Cjerry.huang%
>> 40n
>> >
>> +xp.com%7Ce1898ecb342d4abee75c08d771f48c4c%7C686ea1d3bc2b4c6fa92c
>> d99c5
>> >
>> +c301635%7C0%7C0%7C637103167446779441&amp;sdata=pVGrODu3jQDZKQ
>> cKs1zXSq
>> > +ihEBQUw7Rq6C%2FRm%2Bn8FKU%3D&amp;reserved=0
>> > +FSL_QORIQ_CADENCE_DP_FW_SOURCE =
>> > +firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
>> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
>> > +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
>> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
>> > +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
>> 
>> Should be "NO" (upper_case)
> Will correct it
> 
>> > +
>> > +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
>> > +     cd $(@D); \
>> > +             sh
>> >
>> +$(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_S
>> OURCE)
>> > +--auto-accept;
>> 
>> Final semi-colon not needed.
> Will use below command in v3:
> define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
>         $(call
> NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE))
> endef

please don't duplicate that piece of code.. it should really be
NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx
and nxp-qoriq directories. IMHO both should be named consistently.
Thomas? Matthew?

-michael
Thomas Petazzoni Nov. 26, 2019, 10:12 a.m. UTC | #15
On Tue, 26 Nov 2019 10:29:18 +0100
Michael Walle <michael@walle.cc> wrote:

> >> Final semi-colon not needed.  
> > Will use below command in v3:
> > define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
> >         $(call
> > NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE))
> > endef  
> 
> please don't duplicate that piece of code.. it should really be
> NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx
> and nxp-qoriq directories. IMHO both should be named consistently.
> Thomas? Matthew?

What are you suggesting? A single package/nxp/ folder, with everything
in there?

If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still
the question of where to put this common NXP_EXTRACT_HELPER macro

Thomas
Jerry Huang Nov. 26, 2019, 10:13 a.m. UTC | #16
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Tuesday, November 26, 2019 5:22 PM
> To: Jerry Huang <jerry.huang@nxp.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>;
> buildroot@busybox.net; matthew.weber@collins.com; geomatsi@gmail.com
> Subject: Re: [EXT] Re: [Buildroot] [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Am 2019-11-26 09:09, schrieb Jerry Huang:
> > Best Regards
> > Jerry Huang
> >
> >> -----Original Message-----
> >> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> >> Sent: Tuesday, November 26, 2019 6:12 AM
> >> To: Jerry Huang <jerry.huang@nxp.com>
> >> Cc: buildroot@busybox.net; michael@walle.cc;
> >> matthew.weber@collins.com; geomatsi@gmail.com
> >> Subject: [EXT] Re: [Buildroot] [PATCH v2 07/10]
> >> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> >>
> >> Caution: EXT Email
> >>
> >> Hello,
> >>
> >> On Thu, 21 Nov 2019 18:23:21 +0800
> >> Changming Huang <jerry.huang@nxp.com> wrote:
> >>
> >> > From: Jerry Huang <jerry.huang@nxp.com>
> >> >
> >> > This package provides the firmware for LS1028ARDB DP (display port).
> >> >
> >> > Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
> >>
> >> Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to
> >> use the nxp branding.
> > Sure, I will rename it.
> >
> >> > diff --git a/DEVELOPERS b/DEVELOPERS
> >> > index 9fbe229eb7..b15115f507 100644
> >> > --- a/DEVELOPERS
> >> > +++ b/DEVELOPERS
> >> > @@ -2545,3 +2545,6 @@ F:      package/qjson/
> >> >  F:   package/quazip/
> >> >  F:   package/shapelib/
> >> >  F:   package/tinc/
> >> > +
> >> > +N:   Changming Huang <jerry.huang@nxp.com>
> >>
> >> Please sort your name at the right place in the DEVELOPERS file
> >> (alphabetic
> >> ordering).
> > sure
> >
> >> > diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >> > b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >> > new file mode 100644
> >> > index 0000000000..9259776750
> >> > --- /dev/null
> >> > +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> >> > @@ -0,0 +1,5 @@
> >> > +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> >> > +     bool "FSL QorIQ cadence DP firmware"
> >>
> >> Just:
> >>
> >>         bool "fsl-qorirq-cadence-dp-fw
> > Sure,
> 
> Sorry about being so pedantic about this.. but like I said before,
> almost all (there is one exception, "murata-cyw-fw") firmware packages
> have a -firmware suffix.
Yes, it has been changed to " qoriq-cadence-dp-firmware " in v3

> -michael
Michael Walle Nov. 26, 2019, 10:31 a.m. UTC | #17
Am 2019-11-26 11:12, schrieb Thomas Petazzoni:
> On Tue, 26 Nov 2019 10:29:18 +0100
> Michael Walle <michael@walle.cc> wrote:
> 
>> >> Final semi-colon not needed.
>> > Will use below command in v3:
>> > define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
>> >         $(call
>> > NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/$(QORIQ_CADENCE_DP_FIRMWARE_SOURCE))
>> > endef
>> 
>> please don't duplicate that piece of code.. it should really be
>> NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx
>> and nxp-qoriq directories. IMHO both should be named consistently.
>> Thomas? Matthew?
> 
> What are you suggesting? A single package/nxp/ folder, with everything
> in there?

correct. that would also solve the NXP_EXTRACT_HELPER thing. which would 
end up in
package/nxp/helper.mk or something like that.

> If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still
> the question of where to put this common NXP_EXTRACT_HELPER macro

yes. see above.

-michael
Jerry Huang Nov. 26, 2019, 12:10 p.m. UTC | #18
Best Regards
Jerry Huang

> -----Original Message-----
> From: Michael Walle <michael@walle.cc>
> Sent: Tuesday, November 26, 2019 6:31 PM
> To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Jerry Huang <jerry.huang@nxp.com>; buildroot@busybox.net;
> matthew.weber@collins.com; geomatsi@gmail.com
> Subject: Re: [EXT] Re: [Buildroot] [PATCH v2 07/10]
> package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
> 
> Caution: EXT Email
> 
> Am 2019-11-26 11:12, schrieb Thomas Petazzoni:
> > On Tue, 26 Nov 2019 10:29:18 +0100
> > Michael Walle <michael@walle.cc> wrote:
> >
> >> >> Final semi-colon not needed.
> >> > Will use below command in v3:
> >> > define QORIQ_CADENCE_DP_FIRMWARE_EXTRACT_CMDS
> >> >         $(call
> >> >
> NXP_QORIQ_EXTRACT_HELPER,$(QORIQ_CADENCE_DP_FIRMWARE_DL_DIR)/
> $(QORI
> >> > Q_CADENCE_DP_FIRMWARE_SOURCE))
> >> > endef
> >>
> >> please don't duplicate that piece of code.. it should really be
> >> NXP_EXTRACT_HELPER. which leads to the cleanup of the freescale-imx
> >> and nxp-qoriq directories. IMHO both should be named consistently.
> >> Thomas? Matthew?
> >
> > What are you suggesting? A single package/nxp/ folder, with everything
> > in there?
> 
> correct. that would also solve the NXP_EXTRACT_HELPER thing. which would
> end up in package/nxp/helper.mk or something like that.
So, first, create directory "package/nxp" and push all ls1028ardb codes (including qoriq-rcw, qoriq-cadence-dp-firmware).
Then, move all packages under package/freescale-imx into package/nxp in One separate patch?

> > If we do package/nxp-imx/ and package/nxp-qoirq/, then there is still
> > the question of where to put this common NXP_EXTRACT_HELPER macro
> 
> yes. see above.
> 
> -michael

Patch
diff mbox series

diff --git a/DEVELOPERS b/DEVELOPERS
index 9fbe229eb7..b15115f507 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2545,3 +2545,6 @@  F:	package/qjson/
 F:	package/quazip/
 F:	package/shapelib/
 F:	package/tinc/
+
+N:	Changming Huang <jerry.huang@nxp.com>
+F:	package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/
diff --git a/package/freescale-qoriq/Config.in b/package/freescale-qoriq/Config.in
index 51497c588e..89f575a344 100644
--- a/package/freescale-qoriq/Config.in
+++ b/package/freescale-qoriq/Config.in
@@ -1,4 +1,6 @@ 
 menu "Freescale QorIQ libraries"
 	depends on BR2_aarch64 || BR2_arm || BR2_powerpc64 || BR2_powerpc
 
+source "package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in"
+
 endmenu
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
new file mode 100644
index 0000000000..9259776750
--- /dev/null
+++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
@@ -0,0 +1,5 @@ 
+config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
+	bool "FSL QorIQ cadence DP firmware"
+	help
+	  FSL QorIQ cadence DP firmware, a resident EL3 firmware.
+	  link: http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
new file mode 100644
index 0000000000..bee912bee1
--- /dev/null
+++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
@@ -0,0 +1,2 @@ 
+# Locally calculated
+sha256 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58  firmware-cadence-lsdk1909.bin
diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
new file mode 100644
index 0000000000..d0d112e25f
--- /dev/null
+++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
@@ -0,0 +1,24 @@ 
+################################################################################
+#
+# fsl-qoriq-cadence-dp-fw
+#
+################################################################################
+
+FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
+FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909
+FSL_QORIQ_CADENCE_DP_FW_SOURCE = firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
+FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
+FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
+FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
+FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
+
+define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
+	cd $(@D); \
+		sh $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept;
+endef
+
+define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
+	$(INSTALL) -D -m 0644 $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
+endef
+
+$(eval $(generic-package))