diff mbox series

Re: [PATCH v2 01/13] selftest: add mmap-write support

Message ID 20191120203935.GG20235@breakpoint.cc
State Accepted, archived
Delegated to: Matthieu Baerts
Headers show
Series Re: [PATCH v2 01/13] selftest: add mmap-write support | expand

Commit Message

Florian Westphal Nov. 20, 2019, 8:39 p.m. UTC 
Matthieu Baerts <matthieu.baerts@tessares.net> wrote:
> > diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> > index b5367fe2c6ea..478bc47c3d60 100755
> > --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> > +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
> > @@ -3,7 +3,7 @@
> >   time_start=$(date +%s)
> > -optstring="d:e:l:r:h6c"
> > +optstring="b:d:e:l:r:h6c:m:"
> 
> Just a small detail but the capture (-c) option doesn't any argument. I
> guess we should also apply this:

> -optstring="b:d:e:l:r:h4c:m:"
> +optstring="b:d:e:l:r:h4cm:"
>  ret=0
>  sin=""
>  sout=""

Oh, absolutely.

Can you also apply this fixlet that Mat pointed out?

mptcp mailing list -- mptcp@lists.01.org
To unsubscribe send an email to mptcp-leave@lists.01.org

Comments

Matthieu Baerts Nov. 21, 2019, 12:41 p.m. UTC | #1 
Hi Florian,

On 20/11/2019 21:39, Florian Westphal wrote:
> Matthieu Baerts <matthieu.baerts@tessares.net> wrote:
>>> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.sh b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
>>> index b5367fe2c6ea..478bc47c3d60 100755
>>> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.sh
>>> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.sh
>>> @@ -3,7 +3,7 @@
>>>    time_start=$(date +%s)
>>> -optstring="d:e:l:r:h6c"
>>> +optstring="b:d:e:l:r:h6c:m:"
>>
>> Just a small detail but the capture (-c) option doesn't any argument. I
>> guess we should also apply this:
> 
>> -optstring="b:d:e:l:r:h4c:m:"
>> +optstring="b:d:e:l:r:h4cm:"
>>   ret=0
>>   sin=""
>>   sout=""
> 
> Oh, absolutely.

Great!

- 8c39e2086d0f: selftests:mptcp: fix typo in opts

> Can you also apply this fixlet that Mat pointed out?
> 
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c
> --- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
> +++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
> @@ -391,7 +391,7 @@ static int do_recvfile(int infd, int outfd)
>          ssize_t r;
>   
>          do {
> -               char buf[16536];
> +               char buf[16384];

Just did:

- 2acf87c192a7: selftests:mptcp: buf with a power 2 size
- c35e69234be2..39d0ec7ab1eb: result

Tests + export are in progress.

Cheers,
Matt
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
@@ -391,7 +391,7 @@  static int do_recvfile(int infd, int outfd)
        ssize_t r;
 
        do {
-               char buf[16536];
+               char buf[16384];

Thanks!
_______________________________________________