From patchwork Wed Nov 20 17:39:44 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Preston X-Patchwork-Id: 1198405 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.136; helo=silver.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=codethink.co.uk Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47J9M025hPz9sPJ for ; Thu, 21 Nov 2019 04:54:52 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B5B46245E3; Wed, 20 Nov 2019 17:54:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FEZccjHaHmgZ; Wed, 20 Nov 2019 17:54:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id A8EA42474E; Wed, 20 Nov 2019 17:54:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 561A81BF3D0 for ; Wed, 20 Nov 2019 17:54:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 52B6586DEA for ; Wed, 20 Nov 2019 17:54:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f-i2jw9R4lLr for ; Wed, 20 Nov 2019 17:54:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from imap1.codethink.co.uk (imap1.codethink.co.uk [176.9.8.82]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 4E0E086DE1 for ; Wed, 20 Nov 2019 17:54:46 +0000 (UTC) Received: from [167.98.27.226] (helo=ts007-build.ts007.codethink.co.uk) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iXTxN-0008QV-4l; Wed, 20 Nov 2019 17:39:57 +0000 From: Thomas Preston To: buildroot@buildroot.org Date: Wed, 20 Nov 2019 17:39:44 +0000 Message-Id: <20191120173944.130142-31-thomas.preston@codethink.co.uk> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191120173944.130142-1-thomas.preston@codethink.co.uk> References: <20191120173944.130142-1-thomas.preston@codethink.co.uk> MIME-Version: 1.0 Subject: [Buildroot] [RFC PATCH v3 30/30] package/libcef: Add v8 Snapshot option. X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jon duSaint , Michael Drake , Patrick Glaser , Thomas Preston , Enis Lavery Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Michael Drake This is an optimisation for JavaScript context creation (e.g. opening new tabs). Coauthored-by: Thomas Preston Cc: Patrick Glaser Cc: Jon duSaint Cc: Enis Lavery Signed-off-by: Michael Drake Signed-off-by: Thomas Preston --- package/libcef/Config.in | 31 +++++++++++++++++++++++++++++++ package/libcef/libcef.mk | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 65 insertions(+) diff --git a/package/libcef/Config.in b/package/libcef/Config.in index e0a70e626c..7bc84fa294 100644 --- a/package/libcef/Config.in +++ b/package/libcef/Config.in @@ -95,6 +95,37 @@ config BR2_PACKAGE_LIBCEF_CEFSIMPLE help Enables libcef example application cefsimple. +comment "libcef v8 snapshots depends on a 64-bit target arch" + depends on !BR2_aarch64 && !BR2_x86_64 + +config BR2_PACKAGE_LIBCEF_V8_SNAPSHOTS + bool "Enable v8 snapshots in libcef" + depends on BR2_aarch64 || BR2_x86_64 + select BR2_PACKAGE_HOST_DBUS + select BR2_PACKAGE_HOST_FFMPEG + select BR2_PACKAGE_HOST_LIBXCB + select BR2_PACKAGE_HOST_PCIUTILS + select BR2_PACKAGE_HOST_XCB_UTIL + select BR2_PACKAGE_HOST_XLIB_LIBXTST + help + Enables V8 snapshots. This is an optimisation for + JavaScript context creation (e.g. opening new tabs). + It avoids needing to execute a whole load of JavaScript + code that gets run on context initialisation. + It works by building a browser for the host, creating + a JavaScript context, and saving the JavaScript heap + to file. The target browser can then load the recorded + JavaScript heap from file, instead of executing the + JavaScript code. + + Note that since this requires building a browser for + the host, it requires a lot of extra host packages + to be built. These host library packages need to have + the same memory architecture (32 vs. 64 bit) as the + target, because for the captured heap snapshot to be + valid for the target, it must be captured with a binary + which shares the same memory architecture. + config BR2_PACKAGE_LIBCEF_WIDEVINE bool "Enable Widevine support in libcef." select BR2_PACKAGE_WIDEVINE diff --git a/package/libcef/libcef.mk b/package/libcef/libcef.mk index 0bd80f65d4..126f5b0c14 100644 --- a/package/libcef/libcef.mk +++ b/package/libcef/libcef.mk @@ -214,6 +214,29 @@ else LIBCEF_GN_DEFINES += use_pulseaudio=false endif +ifeq ($(BR2_PACKAGE_LIBCEF_V8_SNAPSHOTS),y) +LIBCEF_GN_DEFINES += \ + v8_snapshot_toolchain=\"//build/toolchain/linux/unbundle:host\" \ + v8_use_snapshot=true +LIBCEF_DEPENDENCIES += \ + host-alsa-lib \ + host-dbus \ + host-ffmpeg \ + host-libxcb \ + host-mesa3d \ + host-pciutils \ + host-xcb-util \ + host-xlib_libXcomposite \ + host-xlib_libXcursor \ + host-xlib_libXrandr \ + host-xlib_libXScrnSaver \ + host-xlib_libXtst +else +LIBCEF_GN_DEFINES += \ + v8_snapshot_toolchain=\"//build/toolchain/linux/unbundle:host\" \ + v8_use_snapshot=false +endif + ifeq ($(BR2_PACKAGE_LIBCEF_WIDEVINE),y) LIBCEF_GN_DEFINES += enable_widevine=true LIBCEF_DEPENDENCIES += widevine @@ -237,6 +260,17 @@ endef LIBCEF_POST_INSTALL_TARGET_HOOKS += LIBCEF_INSTALL_CEFSIMPLE endif +ifeq ($(BR2_PACKAGE_LIBCEF_V8_SNAPSHOTS),y) +define LIBCEF_INSTALL_V8_SNAPSHOT_BINARIES + # v8 snapshot binaries + $(INSTALL) -m 0644 -D -t $(TARGET_DIR)/usr/lib \ + $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/natives_blob.bin \ + $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/snapshot_blob.bin \ + $(@D)/$(LIBCEF_BUILD_OUTPUT_DIR)/v8_context_snapshot.bin +endef +LIBCEF_POST_INSTALL_TARGET_HOOKS += LIBCEF_INSTALL_V8_SNAPSHOT_BINARIES +endif + # To build libcef, the CEF project source must be extracted in a # `cef` directory inside the Chromium source tree. We override # the buildroot default extract commands to get the desired source