[next] package/rpcbind: add systemd dependency when cfg for systemd
diff mbox series

Message ID 20191120150015.54771-1-matthew.weber@rockwellcollins.com
State Accepted
Headers show
Series
  • [next] package/rpcbind: add systemd dependency when cfg for systemd
Related show

Commit Message

Matthew Weber Nov. 20, 2019, 3 p.m. UTC
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
---
 package/rpcbind/rpcbind.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Petazzoni Nov. 20, 2019, 4:59 p.m. UTC | #1
On Wed, 20 Nov 2019 09:00:15 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

The commit log is too short. Does it fix a build issue? Why does it
need to have systemd built before? Is it using a library provided by
systemd?

Thomas
Matthew Weber Nov. 20, 2019, 5:13 p.m. UTC | #2
Thomas,


On Wed, Nov 20, 2019 at 10:59 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Wed, 20 Nov 2019 09:00:15 -0600
> Matt Weber <matthew.weber@rockwellcollins.com> wrote:
>
> > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
>
> The commit log is too short. Does it fix a build issue? Why does it
> need to have systemd built before? Is it using a library provided by
> systemd?

When building using top level parallel build and the init system is
set to systemd, it is possible for the rpcbind package to build before
systemd.  This is an issue as rpcbind sets a library dependency
conditionally on systemd when "RPCBIND_CONF_OPTS +=
--with-systemdsystemunitdir=/usr/lib/systemd/system" is set.

Matt
Thomas Petazzoni Nov. 20, 2019, 8:16 p.m. UTC | #3
On Wed, 20 Nov 2019 11:13:11 -0600
Matthew Weber <matthew.weber@collins.com> wrote:

> > The commit log is too short. Does it fix a build issue? Why does it
> > need to have systemd built before? Is it using a library provided by
> > systemd?  
> 
> When building using top level parallel build and the init system is
> set to systemd, it is possible for the rpcbind package to build before
> systemd.  This is an issue as rpcbind sets a library dependency
> conditionally on systemd when "RPCBIND_CONF_OPTS +=
> --with-systemdsystemunitdir=/usr/lib/systemd/system" is set.

So, this is really a bug, and should be fixed in master, and not in
next. Do you agree?

Without top-level parallel build, you should be able to reproduce the
same bug by running "make rpcbind" from a completely clean tree. Is it
the case ?

Best regards,

Thomas
Matthew Weber Nov. 20, 2019, 8:34 p.m. UTC | #4
Thomas,

On Wed, Nov 20, 2019 at 2:16 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Wed, 20 Nov 2019 11:13:11 -0600
> Matthew Weber <matthew.weber@collins.com> wrote:
>
> > > The commit log is too short. Does it fix a build issue? Why does it
> > > need to have systemd built before? Is it using a library provided by
> > > systemd?
> >
> > When building using top level parallel build and the init system is
> > set to systemd, it is possible for the rpcbind package to build before
> > systemd.  This is an issue as rpcbind sets a library dependency
> > conditionally on systemd when "RPCBIND_CONF_OPTS +=
> > --with-systemdsystemunitdir=/usr/lib/systemd/system" is set.
>
> So, this is really a bug, and should be fixed in master, and not in
> next. Do you agree?

Good point, I setup the following build now to test.

BR2_aarch64=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_INIT_SYSTEMD=y

$ make rpc-bind

checking pkg-config is at least version 0.9.0... yes
checking for SYSTEMD... no
checking for SYSTEMD... no
configure: error: libsystemd support requested but found
package/pkg-generic.mk:228: recipe for target
'/accts/mlweber1/tmp.BwI6Sa4k2G-buildroot/output/build/rpcbind-1.2.5/.stamp_configured'
failed
make[1]: *** [/accts/mlweber1/tmp.BwI6Sa4k2G-buildroot/output/build/rpcbind-1.2.5/.stamp_configured]
Error 1
Makefile:84: recipe for target '_all' failed
make: *** [_all] Error 2

Looks like it should go on master as  bugfix.

Regards,
Matt
Thomas Petazzoni Nov. 20, 2019, 9:34 p.m. UTC | #5
On Wed, 20 Nov 2019 09:00:15 -0600
Matt Weber <matthew.weber@rockwellcollins.com> wrote:

> Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
> ---
>  package/rpcbind/rpcbind.mk | 1 +
>  1 file changed, 1 insertion(+)

As discussed in the thread, I've improved the commit log and applied to
master.

Thanks!

Thomas
Peter Korsgaard Nov. 29, 2019, 3:06 p.m. UTC | #6
>>>>> "Matt" == Matt Weber <matthew.weber@rockwellcollins.com> writes:

 > Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>

Committed to 2019.02.x and 2019.08.x, thanks.

Patch
diff mbox series

diff --git a/package/rpcbind/rpcbind.mk b/package/rpcbind/rpcbind.mk
index 0f5011e522..46e5b27d35 100644
--- a/package/rpcbind/rpcbind.mk
+++ b/package/rpcbind/rpcbind.mk
@@ -17,6 +17,7 @@  RPCBIND_CONF_OPTS += --with-rpcuser=root
 
 ifeq ($(BR2_INIT_SYSTEMD),y)
 RPCBIND_CONF_OPTS += --with-systemdsystemunitdir=/usr/lib/systemd/system
+RPCBIND_DEPENDENCIES += systemd
 else
 RPCBIND_CONF_OPTS += --with-systemdsystemunitdir=no
 endif