[v2,1/2] support/testing: add assertRunOk method to BRTest class
diff mbox series

Message ID 20191120133952.22978-1-patrick.havelange@essensium.com
State Accepted
Headers show
Series
  • [v2,1/2] support/testing: add assertRunOk method to BRTest class
Related show

Commit Message

Patrick Havelange Nov. 20, 2019, 1:39 p.m. UTC
This method asserts that the given command ran successfully.
The goal is for it to be used by the different tests when needed.

Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>

---
Changes
v1 -> v2
[Thomas
 - Moved this function to the BRTest class
 - Removed unnecessary "sh -c"
---
 support/testing/infra/basetest.py | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Thomas Petazzoni Nov. 20, 2019, 10:20 p.m. UTC | #1
On Wed, 20 Nov 2019 14:39:51 +0100
Patrick Havelange <patrick.havelange@essensium.com> wrote:

> This method asserts that the given command ran successfully.
> The goal is for it to be used by the different tests when needed.
> 
> Signed-off-by: Patrick Havelange <patrick.havelange@essensium.com>
> 
> ---
> Changes
> v1 -> v2
> [Thomas
>  - Moved this function to the BRTest class
>  - Removed unnecessary "sh -c"
> ---
>  support/testing/infra/basetest.py | 6 ++++++
>  1 file changed, 6 insertions(+)

Applied to next, thanks.

Thomas

Patch
diff mbox series

diff --git a/support/testing/infra/basetest.py b/support/testing/infra/basetest.py
index a176bc328a..023039f6af 100644
--- a/support/testing/infra/basetest.py
+++ b/support/testing/infra/basetest.py
@@ -84,3 +84,9 @@  class BRTest(BRConfigTest):
         if self.emulator:
             self.emulator.stop()
         super(BRTest, self).tearDown()
+
+    # Run the given 'cmd' with a 'timeout' on the target and 
+    # assert that the command succeeded
+    def assertRunOk(self, cmd, timeout=-1):
+        _, exit_code = self.emulator.run(cmd, timeout)
+        self.assertEqual(exit_code, 0)