Patchwork [v2] mtd: provide an alias for the redboot module name

login
register
mail settings
Submitter Andres Salomon
Date Oct. 14, 2011, 2:33 p.m.
Message ID <20111014073320.140fb4b2@debxo>
Download mbox | patch
Permalink /patch/119803/
State New
Headers show

Comments

Andres Salomon - Oct. 14, 2011, 2:33 p.m.
parse_mtd_partitions takes a list of partition types; if the driver
isn't loaded, it attempts to load it, and then it grabs the partition
parser.  For redboot, the module name is "redboot.ko", while the parser
name is "RedBoot".  Since modprobe is case-sensitive, attempting to
modprobe "RedBoot" will never work.  I suspect the embedded systems that
make use of redboot just always manually loaded redboot prior to loading
their specific nand chip drivers (or statically compiled it in).

Signed-off-by: Andres Salomon <dilinger@queued.net>
Cc: stable@kernel.org
---
 drivers/mtd/redboot.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

v2: instead of renaming the module, use a module_alias.  Duh.  Thanks,
Artem Bityutskiy!
Artem Bityutskiy - Oct. 16, 2011, 12:03 p.m.
On Fri, 2011-10-14 at 07:33 -0700, Andres Salomon wrote:
> parse_mtd_partitions takes a list of partition types; if the driver
> isn't loaded, it attempts to load it, and then it grabs the partition
> parser.  For redboot, the module name is "redboot.ko", while the parser
> name is "RedBoot".  Since modprobe is case-sensitive, attempting to
> modprobe "RedBoot" will never work.  I suspect the embedded systems that
> make use of redboot just always manually loaded redboot prior to loading
> their specific nand chip drivers (or statically compiled it in).
> 
> Signed-off-by: Andres Salomon <dilinger@queued.net>
> Cc: stable@kernel.org
> ---
>  drivers/mtd/redboot.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> v2: instead of renaming the module, use a module_alias.  Duh.  Thanks,
> Artem Bityutskiy!

Pushed to l2-mtd-2.6.git, thanks!

Patch

diff --git a/drivers/mtd/redboot.c b/drivers/mtd/redboot.c
index 7a87d07..4938bd0 100644
--- a/drivers/mtd/redboot.c
+++ b/drivers/mtd/redboot.c
@@ -297,6 +297,9 @@  static struct mtd_part_parser redboot_parser = {
 	.name = "RedBoot",
 };
 
+/* mtd parsers will request the module by parser name */
+MODULE_ALIAS("RedBoot");
+
 static int __init redboot_parser_init(void)
 {
 	return register_mtd_parser(&redboot_parser);