[1/9] package/rcw: upgrade the rcw version to LSDK-19.09
diff mbox series

Message ID 20191120040725.32207-2-jerry.huang@nxp.com
State Superseded
Headers show
Series
  • new board ls1028ardb introduced
Related show

Commit Message

Jerry Huang Nov. 20, 2019, 4:07 a.m. UTC
Change the RCW version to LSDK-19.09.

Signed-off-by: Changming Huang <jerry.huang@nxp.com>
---
 package/rcw/rcw.hash | 3 +--
 package/rcw/rcw.mk   | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

Comments

Thomas Petazzoni Nov. 20, 2019, 7:59 a.m. UTC | #1
Hello Jerry,

First of all, thanks a lot for this patch series, it is very nice to
see NXP directly contributing to Buildroot some support for the LS1028
platform. See below one question about this patch.

On Wed, 20 Nov 2019 12:07:17 +0800
Changming Huang <jerry.huang@nxp.com> wrote:

> Change the RCW version to LSDK-19.09.
> 
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
>  package/rcw/rcw.hash | 3 +--
>  package/rcw/rcw.mk   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash
> index 7de1ec659a..3fbb5d167f 100644
> --- a/package/rcw/rcw.hash
> +++ b/package/rcw/rcw.hash
> @@ -1,3 +1,2 @@
>  # Locally calculated
> -sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz
> -sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE

Why are you removing the hash of the license file here ?

Best regards,

Thomas
Jerry Huang Nov. 20, 2019, 8:04 a.m. UTC | #2
Thanks for your reply, Thomas.
I will add-back the hash of license file in next version.

Best Regards
Jerry Huang

-----Original Message-----
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com> 
Sent: Wednesday, November 20, 2019 4:00 PM
To: Jerry Huang <jerry.huang@nxp.com>
Cc: buildroot@busybox.net
Subject: [EXT] Re: [Buildroot] [PATCH 1/9] package/rcw: upgrade the rcw version to LSDK-19.09

Caution: EXT Email

Hello Jerry,

First of all, thanks a lot for this patch series, it is very nice to see NXP directly contributing to Buildroot some support for the LS1028 platform. See below one question about this patch.

On Wed, 20 Nov 2019 12:07:17 +0800
Changming Huang <jerry.huang@nxp.com> wrote:

> Change the RCW version to LSDK-19.09.
>
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
>  package/rcw/rcw.hash | 3 +--
>  package/rcw/rcw.mk   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash index 
> 7de1ec659a..3fbb5d167f 100644
> --- a/package/rcw/rcw.hash
> +++ b/package/rcw/rcw.hash
> @@ -1,3 +1,2 @@
>  # Locally calculated
> -sha256 
> 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 
> rcw-LSDK-18.12.tar.gz
> -sha256 
> a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd 
> LICENSE

Why are you removing the hash of the license file here ?

Best regards,

Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.com&amp;data=02%7C01%7Cjerry.huang%40nxp.com%7C386c6a3dbcc941510fa508d76d8f9be5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637098335879692477&amp;sdata=i4kLTZ4FkszCKJEZ7sBpbJ4h%2BcsrrFe5HbjJzB3jz1I%3D&amp;reserved=0
Michael Walle Nov. 20, 2019, 9:21 a.m. UTC | #3
Am 2019-11-20 05:07, schrieb Changming Huang:
> Change the RCW version to LSDK-19.09.
> 
> Signed-off-by: Changming Huang <jerry.huang@nxp.com>
> ---
>  package/rcw/rcw.hash | 3 +--
>  package/rcw/rcw.mk   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash
> index 7de1ec659a..3fbb5d167f 100644
> --- a/package/rcw/rcw.hash
> +++ b/package/rcw/rcw.hash

sorry for missing the initial commit.. but IMHO the package name "rcw" 
is _really_ bad. because its too generic. what if another SoC also has a 
package rcw. So if it is still possible, could it be renamed to 
rcw-qoriq ?

-michael
Thomas Petazzoni Nov. 20, 2019, 9:32 a.m. UTC | #4
Hello,

On Wed, 20 Nov 2019 10:21:12 +0100
Michael Walle <michael@walle.cc> wrote:

> > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash
> > index 7de1ec659a..3fbb5d167f 100644
> > --- a/package/rcw/rcw.hash
> > +++ b/package/rcw/rcw.hash  
> 
> sorry for missing the initial commit.. but IMHO the package name "rcw" 
> is _really_ bad. because its too generic. what if another SoC also has a 
> package rcw. So if it is still possible, could it be renamed to 
> rcw-qoriq ?

True, rcw is very short and quite generic. Matt, what do you think?

Thomas
Matthew Weber Nov. 20, 2019, 9:38 a.m. UTC | #5
Thomas, Michael,

On Wed, Nov 20, 2019 at 3:32 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello,
>
> On Wed, 20 Nov 2019 10:21:12 +0100
> Michael Walle <michael@walle.cc> wrote:
>
> > > diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash
> > > index 7de1ec659a..3fbb5d167f 100644
> > > --- a/package/rcw/rcw.hash
> > > +++ b/package/rcw/rcw.hash
> >
> > sorry for missing the initial commit.. but IMHO the package name "rcw"
> > is _really_ bad. because its too generic. what if another SoC also has a
> > package rcw. So if it is still possible, could it be renamed to
> > rcw-qoriq ?
>
> True, rcw is very short and quite generic. Matt, what do you think?
>

Michael, good points, maybe we could append a prefix to make it
freescale-qoriq-rcw?

Matt
Thomas Petazzoni Nov. 20, 2019, 9:45 a.m. UTC | #6
On Wed, 20 Nov 2019 03:38:40 -0600
Matthew Weber <matthew.weber@collins.com> wrote:

> > True, rcw is very short and quite generic. Matt, what do you think?
> 
> Michael, good points, maybe we could append a prefix to make it
> freescale-qoriq-rcw?

Yes, freescale-qorqiq-rcw is good.

Thomas
Matthew Weber Nov. 20, 2019, 9:51 a.m. UTC | #7
Changming,

On Wed, Nov 20, 2019 at 3:45 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Wed, 20 Nov 2019 03:38:40 -0600
> Matthew Weber <matthew.weber@collins.com> wrote:
>
> > > True, rcw is very short and quite generic. Matt, what do you think?
> >
> > Michael, good points, maybe we could append a prefix to make it
> > freescale-qoriq-rcw?
>
> Yes, freescale-qorqiq-rcw is good.
>

I can send a patch, however do you want to add this rename as a patch
in your current layerscape devkit series as you touch lots of RCW
variables?  Let me know your plan, I can send it but I don't want to
do it in the middle of your work :).

Matt
Jerry Huang Nov. 20, 2019, 9:54 a.m. UTC | #8
Best Regards
Jerry Huang

> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Sent: Wednesday, November 20, 2019 5:46 PM
> To: Matthew Weber <matthew.weber@collins.com>
> Cc: Michael Walle <michael@walle.cc>; Jerry Huang <jerry.huang@nxp.com>;
> buildroot mailing list <buildroot@busybox.net>
> Subject: [EXT] Re: [Buildroot] [PATCH 1/9] package/rcw: upgrade the rcw version
> to LSDK-19.09
> 
> Caution: EXT Email
> 
> On Wed, 20 Nov 2019 03:38:40 -0600
> Matthew Weber <matthew.weber@collins.com> wrote:
> 
> > > True, rcw is very short and quite generic. Matt, what do you think?
> >
> > Michael, good points, maybe we could append a prefix to make it
> > freescale-qoriq-rcw?
> 
> Yes, freescale-qorqiq-rcw is good.
I create sub-directory " freescale-qoriq" in patch 0005-package-freescale-qoriq-xxx, so the RCW package can be moved into that?
Because RCW is related with hardware for QorIQ serial platforms.

> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbootlin.c
> om&amp;data=02%7C01%7Cjerry.huang%40nxp.com%7Ca79baf082b6c4b3d45
> 3c08d76d9e67fa%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6370
> 98399419780949&amp;sdata=egdHxRKFOKtMuW2CusUxAU%2BLiAMXdZQ85m
> bUBJGCRPw%3D&amp;reserved=0
Jerry Huang Nov. 20, 2019, 9:57 a.m. UTC | #9
Hi, Matt,

Best Regards
Jerry Huang

> -----Original Message-----
> From: Matthew Weber <matthew.weber@collins.com>
> Sent: Wednesday, November 20, 2019 5:52 PM
> To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Michael Walle <michael@walle.cc>; Jerry Huang <jerry.huang@nxp.com>;
> buildroot mailing list <buildroot@busybox.net>
> Subject: [EXT] Re: [External] Re: [Buildroot] [PATCH 1/9] package/rcw: upgrade
> the rcw version to LSDK-19.09
> 
> Caution: EXT Email
> 
> Changming,
> 
> On Wed, Nov 20, 2019 at 3:45 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
> >
> > On Wed, 20 Nov 2019 03:38:40 -0600
> > Matthew Weber <matthew.weber@collins.com> wrote:
> >
> > > > True, rcw is very short and quite generic. Matt, what do you think?
> > >
> > > Michael, good points, maybe we could append a prefix to make it
> > > freescale-qoriq-rcw?
> >
> > Yes, freescale-qorqiq-rcw is good.
> >
> 
> I can send a patch, however do you want to add this rename as a patch in your
> current layerscape devkit series as you touch lots of RCW variables?  Let me
> know your plan, I can send it but I don't want to do it in the middle of your
> work :).
I can add this rename as a patch
I created one sub-directory " freescale-qoriq" for all hardware related,
So, can I move RCW after rename into this directory?

> Matt
Michael Walle Nov. 20, 2019, 10 a.m. UTC | #10
Hi,

Am 2019-11-20 10:51, schrieb Matthew Weber:
> Changming,
> 
> On Wed, Nov 20, 2019 at 3:45 AM Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> wrote:
>> 
>> On Wed, 20 Nov 2019 03:38:40 -0600
>> Matthew Weber <matthew.weber@collins.com> wrote:
>> 
>> > > True, rcw is very short and quite generic. Matt, what do you think?
>> >
>> > Michael, good points, maybe we could append a prefix to make it
>> > freescale-qoriq-rcw?
>> 
>> Yes, freescale-qorqiq-rcw is good.

sounds good. but also see below.

>> 
> 
> I can send a patch, however do you want to add this rename as a patch
> in your current layerscape devkit series as you touch lots of RCW
> variables?  Let me know your plan, I can send it but I don't want to
> do it in the middle of your work :).

The RCW is really board dependent. I can imagine some OEMs are using the 
ones from freescale, but most likely they won't fit their boards. For 
example, we have our own RCW repository (although only binary for now) 
for our board. Therefore, wouldn't it be better to have different rcw 
config(s) in the board directories?

TBH I just had a quick look at the package makefile and saw that it 
copies the RCWs to /usr/share. Most likely, you (also?) need them in a 
flash/sdcard image, though.

-michael
Matthew Weber Nov. 20, 2019, 10:23 a.m. UTC | #11
Michael,


On Wed, Nov 20, 2019 at 4:00 AM Michael Walle <michael@walle.cc> wrote:
>
> Hi,
>
> Am 2019-11-20 10:51, schrieb Matthew Weber:
> > Changming,
> >
> > On Wed, Nov 20, 2019 at 3:45 AM Thomas Petazzoni
> > <thomas.petazzoni@bootlin.com> wrote:
> >>
> >> On Wed, 20 Nov 2019 03:38:40 -0600
> >> Matthew Weber <matthew.weber@collins.com> wrote:
> >>
> >> > > True, rcw is very short and quite generic. Matt, what do you think?
> >> >
> >> > Michael, good points, maybe we could append a prefix to make it
> >> > freescale-qoriq-rcw?
> >>
> >> Yes, freescale-qorqiq-rcw is good.
>
> sounds good. but also see below.

I see Changming's email about nesting this in the folder as well.  No
issue with that as long as the maintainers support it (similar to
freescale-imx)

>
> >>
> >
> > I can send a patch, however do you want to add this rename as a patch
> > in your current layerscape devkit series as you touch lots of RCW
> > variables?  Let me know your plan, I can send it but I don't want to
> > do it in the middle of your work :).
>
> The RCW is really board dependent. I can imagine some OEMs are using the
> ones from freescale, but most likely they won't fit their boards. For
> example, we have our own RCW repository (although only binary for now)
> for our board. Therefore, wouldn't it be better to have different rcw
> config(s) in the board directories?

On the next branch there is a patch applied that allows custom board
rcws to meet that need.

>
> TBH I just had a quick look at the package makefile and saw that it
> copies the RCWs to /usr/share. Most likely, you (also?) need them in a
> flash/sdcard image, though.

Agree, the package was originally setup to stage all the pieces the
user needs to use the tool outside of the build from a deployed SDK
for creating images (mainly a board bringup/hardware developer use
case).  REcently a patch was applied to Next that allows customized
boards and with Changming's patch you can stage pre-defined board rcw
binaries for use.

Matt

Patch
diff mbox series

diff --git a/package/rcw/rcw.hash b/package/rcw/rcw.hash
index 7de1ec659a..3fbb5d167f 100644
--- a/package/rcw/rcw.hash
+++ b/package/rcw/rcw.hash
@@ -1,3 +1,2 @@ 
 # Locally calculated
-sha256 1421ada9fec10b12ff21cd9ad82f0a835b191cb2dde80f03547764574b1346c3 rcw-LSDK-18.12.tar.gz
-sha256 a531b3146425e592db17a51ff39c4801cb01fb4055ffdaada0572decc0655bcd LICENSE
+sha256 b69a6a8b187ba794e0af716a509ced2bbac83da0f6e94b5c7331a34619db21b1  rcw-LSDK-19.09.tar.gz
diff --git a/package/rcw/rcw.mk b/package/rcw/rcw.mk
index 36d2da61b5..3a8cf5c444 100644
--- a/package/rcw/rcw.mk
+++ b/package/rcw/rcw.mk
@@ -4,7 +4,7 @@ 
 #
 ################################################################################
 
-RCW_VERSION = LSDK-18.12
+RCW_VERSION = LSDK-19.09
 RCW_SITE = https://source.codeaurora.org/external/qoriq/qoriq-components/rcw
 RCW_SITE_METHOD = git
 RCW_LICENSE = BSD-3-Clause