[SRU,XENIAL,1/1] UBUNTU: [Debian]: include i40evf in generic
diff mbox series

Message ID CAMsNC+s4KOjadipbBDoUzkBYU_gdu5xcMOqXY1hUQ0Vv-h_=tw@mail.gmail.com
State New
Headers show
Series
  • Fix for LP:#1848481
Related show

Commit Message

Gerald Yang Nov. 20, 2019, 12:39 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1848481

Intel's VF drivers such as igbvf and ixgbevf are already available in
generic. It makes sense to add i40evf especially for SR-IOV enabled
clouds with Intel X710/XXV710/XL710.
The module was renamed from i40evf to iavf since kernel 4.20, so there
will be a separate SRU for other series

Signed-off-by: Gerald Yang <gerald.yang at canonical.com
<https://lists.ubuntu.com/mailman/listinfo/kernel-team>>
---
 debian.master/control.d/generic.inclusion-list | 1 +
 1 file changed, 1 insertion(+)

Comments

Stefan Bader Nov. 28, 2019, 2:50 p.m. UTC | #1
On 20.11.19 01:39, Gerald Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> The module was renamed from i40evf to iavf since kernel 4.20, so there
> will be a separate SRU for other series
> 
> Signed-off-by: Gerald Yang <gerald.yang at canonical.com <https://lists.ubuntu.com/mailman/listinfo/kernel-team>>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---

I think this should be "UBUNTU: [Packaging]: ..." and probably needs some manual
fixup in the SOB area (at least my mail client seems to do funny things in
there). Somehow I also do not get the patch and cover email threaded, so acking
directly the patch.

>  debian.master/control.d/generic.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> index 96f2c05950f2..ebe2f75e30cf 100644
> --- a/debian.master/control.d/generic.inclusion-list
> +++ b/debian.master/control.d/generic.inclusion-list
> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>  drivers/net/ethernet/intel/e1000/e1000.ko
>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>  drivers/net/ethernet/intel/i40e/*
> +drivers/net/ethernet/intel/i40evf/*
>  drivers/net/ethernet/intel/igb/*
>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>  drivers/net/ethernet/intel/ixgbe/*
> -- 
> 2.17.1
> 
>
Kleber Souza Nov. 29, 2019, 5:16 p.m. UTC | #2
On 20.11.19 01:39, Gerald Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> The module was renamed from i40evf to iavf since kernel 4.20, so there
> will be a separate SRU for other series
> 
> Signed-off-by: Gerald Yang <gerald.yang at canonical.com <https://lists.ubuntu.com/mailman/listinfo/kernel-team>>
> ---
>  debian.master/control.d/generic.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> index 96f2c05950f2..ebe2f75e30cf 100644
> --- a/debian.master/control.d/generic.inclusion-list
> +++ b/debian.master/control.d/generic.inclusion-list
> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>  drivers/net/ethernet/intel/e1000/e1000.ko
>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>  drivers/net/ethernet/intel/i40e/*
> +drivers/net/ethernet/intel/i40evf/*
>  drivers/net/ethernet/intel/igb/*
>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>  drivers/net/ethernet/intel/ixgbe/*
> -- 
> 2.17.1
> 
> 

With the changes mentioned by Stefan.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Khaled Elmously Dec. 2, 2019, 8:15 a.m. UTC | #3
This patch is *already* applied:  https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial/commit/?h=master-next&id=faddb48da7e751bc68607257af7a867104e42c75


I'm not sure how that happened



On 2019-11-19 16:39:20 , Gerald Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> The module was renamed from i40evf to iavf since kernel 4.20, so there
> will be a separate SRU for other series
> 
> Signed-off-by: Gerald Yang <gerald.yang at canonical.com
> <https://lists.ubuntu.com/mailman/listinfo/kernel-team>>
> ---
>  debian.master/control.d/generic.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.d/generic.inclusion-list
> b/debian.master/control.d/generic.inclusion-list
> index 96f2c05950f2..ebe2f75e30cf 100644
> --- a/debian.master/control.d/generic.inclusion-list
> +++ b/debian.master/control.d/generic.inclusion-list
> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>  drivers/net/ethernet/intel/e1000/e1000.ko
>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>  drivers/net/ethernet/intel/i40e/*
> +drivers/net/ethernet/intel/i40evf/*
>  drivers/net/ethernet/intel/igb/*
>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>  drivers/net/ethernet/intel/ixgbe/*
> -- 
> 2.17.1

> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Stefan Bader Dec. 2, 2019, 10:33 a.m. UTC | #4
On 02.12.19 09:15, Khaled Elmously wrote:
> This patch is *already* applied:  https://git.launchpad.net/~ubuntu-kernel/ubuntu/+source/linux/+git/xenial/commit/?h=master-next&id=faddb48da7e751bc68607257af7a867104e42c75
> 
> 
> I'm not sure how that happened

That commit sha1 is pointing to a 4.15 tree for me (hwe). Not the master-next
which does not have the commit.

> 
> 
> 
> On 2019-11-19 16:39:20 , Gerald Yang wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1848481
>>
>> Intel's VF drivers such as igbvf and ixgbevf are already available in
>> generic. It makes sense to add i40evf especially for SR-IOV enabled
>> clouds with Intel X710/XXV710/XL710.
>> The module was renamed from i40evf to iavf since kernel 4.20, so there
>> will be a separate SRU for other series
>>
>> Signed-off-by: Gerald Yang <gerald.yang at canonical.com
>> <https://lists.ubuntu.com/mailman/listinfo/kernel-team>>
>> ---
>>  debian.master/control.d/generic.inclusion-list | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/debian.master/control.d/generic.inclusion-list
>> b/debian.master/control.d/generic.inclusion-list
>> index 96f2c05950f2..ebe2f75e30cf 100644
>> --- a/debian.master/control.d/generic.inclusion-list
>> +++ b/debian.master/control.d/generic.inclusion-list
>> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>>  drivers/net/ethernet/intel/e1000/e1000.ko
>>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>>  drivers/net/ethernet/intel/i40e/*
>> +drivers/net/ethernet/intel/i40evf/*
>>  drivers/net/ethernet/intel/igb/*
>>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>>  drivers/net/ethernet/intel/ixgbe/*
>> -- 
>> 2.17.1
> 
>> -- 
>> kernel-team mailing list
>> kernel-team@lists.ubuntu.com
>> https://lists.ubuntu.com/mailman/listinfo/kernel-team
> 
>
Stefan Bader Dec. 2, 2019, 10:58 a.m. UTC | #5
On 20.11.19 01:39, Gerald Yang wrote:
> BugLink: https://bugs.launchpad.net/bugs/1848481
> 
> Intel's VF drivers such as igbvf and ixgbevf are already available in
> generic. It makes sense to add i40evf especially for SR-IOV enabled
> clouds with Intel X710/XXV710/XL710.
> The module was renamed from i40evf to iavf since kernel 4.20, so there
> will be a separate SRU for other series
> 
> Signed-off-by: Gerald Yang <gerald.yang at canonical.com <https://lists.ubuntu.com/mailman/listinfo/kernel-team>>
> ---

Applied to xenial/master-next. But the patch did not apply as is because the
context in Xenial is different. Please make sure in future to test this in the
correct branch. Thanks.

-Stefan

>  debian.master/control.d/generic.inclusion-list | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/debian.master/control.d/generic.inclusion-list b/debian.master/control.d/generic.inclusion-list
> index 96f2c05950f2..ebe2f75e30cf 100644
> --- a/debian.master/control.d/generic.inclusion-list
> +++ b/debian.master/control.d/generic.inclusion-list
> @@ -93,6 +93,7 @@ drivers/net/ethernet/ibm/*
>  drivers/net/ethernet/intel/e1000/e1000.ko
>  drivers/net/ethernet/intel/e1000e/e1000e.ko
>  drivers/net/ethernet/intel/i40e/*
> +drivers/net/ethernet/intel/i40evf/*
>  drivers/net/ethernet/intel/igb/*
>  drivers/net/ethernet/intel/igbvf/igbvf.ko
>  drivers/net/ethernet/intel/ixgbe/*
> -- 
> 2.17.1
> 
>

Patch
diff mbox series

diff --git a/debian.master/control.d/generic.inclusion-list
b/debian.master/control.d/generic.inclusion-list
index 96f2c05950f2..ebe2f75e30cf 100644
--- a/debian.master/control.d/generic.inclusion-list
+++ b/debian.master/control.d/generic.inclusion-list
@@ -93,6 +93,7 @@  drivers/net/ethernet/ibm/*
 drivers/net/ethernet/intel/e1000/e1000.ko
 drivers/net/ethernet/intel/e1000e/e1000e.ko
 drivers/net/ethernet/intel/i40e/*
+drivers/net/ethernet/intel/i40evf/*
 drivers/net/ethernet/intel/igb/*
 drivers/net/ethernet/intel/igbvf/igbvf.ko
 drivers/net/ethernet/intel/ixgbe/*