[U-Boot,1/1] arm: fix -march for ARM11
diff mbox series

Message ID 20191119221557.138500-1-xypron.glpk@gmx.de
State Superseded, archived
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot,1/1] arm: fix -march for ARM11
Related show

Commit Message

Heinrich Schuchardt Nov. 19, 2019, 10:15 p.m. UTC
-march v5 is invalid for GCC 9.2.1. ARM11 is an armv6 implementation. So
change the architecture flag for the compiler to armv6.
Cf. https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html

Suggested-by: Fabio Estevam <festevam@gmail.com>
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 arch/arm/Makefile | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.24.0

Comments

Linus Walleij Nov. 20, 2019, 1:06 p.m. UTC | #1
On Tue, Nov 19, 2019 at 11:16 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> -march v5 is invalid for GCC 9.2.1. ARM11 is an armv6 implementation. So
> change the architecture flag for the compiler to armv6.
> Cf. https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
>
> Suggested-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Linus Walleij Nov. 22, 2019, 8:02 a.m. UTC | #2
On Tue, Nov 19, 2019 at 11:16 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:

> -march v5 is invalid for GCC 9.2.1. ARM11 is an armv6 implementation. So
> change the architecture flag for the compiler to armv6.
> Cf. https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
>
> Suggested-by: Fabio Estevam <festevam@gmail.com>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

After I read up on it I would add something to the commit saying
that the first -march=armv5 must have been wrong all the time
since there are no known implementations of
armv5, only armv5t, armv5te and armv5tej. Maybe add a link
to this:
https://gcc.gnu.org/gcc-9/changes.html

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/arch/arm/Makefile b/arch/arm/Makefile
index 5384981c17..60af7e3199 100644
--- a/arch/arm/Makefile
+++ b/arch/arm/Makefile
@@ -12,8 +12,8 @@  arch-$(CONFIG_CPU_ARM926EJS)	=-march=armv5te
 arch-$(CONFIG_CPU_ARM946ES)	=-march=armv5te
 arch-$(CONFIG_CPU_SA1100)	=-march=armv4
 arch-$(CONFIG_CPU_PXA)		=
-arch-$(CONFIG_CPU_ARM1136)	=-march=armv5
-arch-$(CONFIG_CPU_ARM1176)	=-march=armv5t
+arch-$(CONFIG_CPU_ARM1136)	=-march=armv6
+arch-$(CONFIG_CPU_ARM1176)	=-march=armv6
 arch-$(CONFIG_CPU_V7A)		=$(call cc-option, -march=armv7-a, \
 				 $(call cc-option, -march=armv7))
 arch-$(CONFIG_CPU_V7M)		=-march=armv7-m