[U-Boot] arm: ti: dra7: move BOOTP_DNS2 and PHY_TI in defconfig
diff mbox series

Message ID 20191119184417.27615-1-grygorii.strashko@ti.com
State Superseded
Delegated to: Tom Rini
Headers show
Series
  • [U-Boot] arm: ti: dra7: move BOOTP_DNS2 and PHY_TI in defconfig
Related show

Commit Message

Grygorii Strashko Nov. 19, 2019, 6:44 p.m. UTC
Move BOOTP_DNS2 and PHY_TI from dra7xx_evm.h to
dra7xx_evm_defconfig.

Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
 configs/dra7xx_evm_defconfig        | 2 ++
 configs/dra7xx_hs_evm_defconfig     | 2 ++
 configs/dra7xx_hs_evm_usb_defconfig | 2 ++
 include/configs/dra7xx_evm.h        | 2 --
 4 files changed, 6 insertions(+), 2 deletions(-)

Comments

Lokesh Vutla Nov. 20, 2019, 4:30 a.m. UTC | #1
On 20/11/19 12:14 AM, Grygorii Strashko wrote:
> Move BOOTP_DNS2 and PHY_TI from dra7xx_evm.h to
> dra7xx_evm_defconfig.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
>  configs/dra7xx_evm_defconfig        | 2 ++
>  configs/dra7xx_hs_evm_defconfig     | 2 ++
>  configs/dra7xx_hs_evm_usb_defconfig | 2 ++
>  include/configs/dra7xx_evm.h        | 2 --
>  4 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
> index cb2cdcb350..cae8431bc6 100644
> --- a/configs/dra7xx_evm_defconfig
> +++ b/configs/dra7xx_evm_defconfig
> @@ -117,3 +117,5 @@ CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x0451
>  CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
> +CONFIG_BOOTP_DNS2=y
> +CONFIG_PHY_TI=y

Is this done using savedefconfig?

Thanks and regards,
Lokesh

> diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig
> index 1dff889975..f57c249f90 100644
> --- a/configs/dra7xx_hs_evm_defconfig
> +++ b/configs/dra7xx_hs_evm_defconfig
> @@ -120,3 +120,5 @@ CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x0451
>  CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
> +CONFIG_BOOTP_DNS2=y
> +CONFIG_PHY_TI=y
> diff --git a/configs/dra7xx_hs_evm_usb_defconfig b/configs/dra7xx_hs_evm_usb_defconfig
> index fa18e1d076..1385782567 100644
> --- a/configs/dra7xx_hs_evm_usb_defconfig
> +++ b/configs/dra7xx_hs_evm_usb_defconfig
> @@ -115,3 +115,5 @@ CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
>  CONFIG_USB_GADGET_VENDOR_NUM=0x0451
>  CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
> +CONFIG_BOOTP_DNS2=y
> +CONFIG_PHY_TI=y
> diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
> index 0ad23ce4b9..0eb1cff33e 100644
> --- a/include/configs/dra7xx_evm.h
> +++ b/include/configs/dra7xx_evm.h
> @@ -64,10 +64,8 @@
>  #define CONFIG_HSMMC2_8BIT
>  
>  /* CPSW Ethernet */
> -#define CONFIG_BOOTP_DNS2
>  #define CONFIG_BOOTP_SEND_HOSTNAME
>  #define CONFIG_NET_RETRY_COUNT		10
> -#define CONFIG_PHY_TI
>  
>  /*
>   * Default to using SPI for environment, etc.
>
Grygorii Strashko Nov. 20, 2019, 9:16 a.m. UTC | #2
On 20/11/2019 06:30, Lokesh Vutla wrote:
> 
> 
> On 20/11/19 12:14 AM, Grygorii Strashko wrote:
>> Move BOOTP_DNS2 and PHY_TI from dra7xx_evm.h to
>> dra7xx_evm_defconfig.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>> ---
>>   configs/dra7xx_evm_defconfig        | 2 ++
>>   configs/dra7xx_hs_evm_defconfig     | 2 ++
>>   configs/dra7xx_hs_evm_usb_defconfig | 2 ++
>>   include/configs/dra7xx_evm.h        | 2 --
>>   4 files changed, 6 insertions(+), 2 deletions(-)
>>
>> diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
>> index cb2cdcb350..cae8431bc6 100644
>> --- a/configs/dra7xx_evm_defconfig
>> +++ b/configs/dra7xx_evm_defconfig
>> @@ -117,3 +117,5 @@ CONFIG_USB_GADGET=y
>>   CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0451
>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
>> +CONFIG_BOOTP_DNS2=y
>> +CONFIG_PHY_TI=y
> 
> Is this done using savedefconfig?

No. I'll update and resend



[...]
Vignesh Raghavendra Nov. 20, 2019, 10:30 a.m. UTC | #3
On 20/11/19 2:46 PM, Grygorii Strashko wrote:
> 
> 
> On 20/11/2019 06:30, Lokesh Vutla wrote:
>>
>>
>> On 20/11/19 12:14 AM, Grygorii Strashko wrote:
>>> Move BOOTP_DNS2 and PHY_TI from dra7xx_evm.h to
>>> dra7xx_evm_defconfig.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>> ---
>>>   configs/dra7xx_evm_defconfig        | 2 ++
>>>   configs/dra7xx_hs_evm_defconfig     | 2 ++
>>>   configs/dra7xx_hs_evm_usb_defconfig | 2 ++
>>>   include/configs/dra7xx_evm.h        | 2 --
>>>   4 files changed, 6 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
>>> index cb2cdcb350..cae8431bc6 100644
>>> --- a/configs/dra7xx_evm_defconfig
>>> +++ b/configs/dra7xx_evm_defconfig
>>> @@ -117,3 +117,5 @@ CONFIG_USB_GADGET=y
>>>   CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
>>>   CONFIG_USB_GADGET_VENDOR_NUM=0x0451
>>>   CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
>>> +CONFIG_BOOTP_DNS2=y
>>> +CONFIG_PHY_TI=y
>>
>> Is this done using savedefconfig?
> 
> No. I'll update and resend
> 

Not sure if you are aware of, but there is ./tools/moveconfig.py that
helps in moving configs from headers to Kconfig

> 
> 
> [...]
>

Patch
diff mbox series

diff --git a/configs/dra7xx_evm_defconfig b/configs/dra7xx_evm_defconfig
index cb2cdcb350..cae8431bc6 100644
--- a/configs/dra7xx_evm_defconfig
+++ b/configs/dra7xx_evm_defconfig
@@ -117,3 +117,5 @@  CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
 CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
+CONFIG_BOOTP_DNS2=y
+CONFIG_PHY_TI=y
diff --git a/configs/dra7xx_hs_evm_defconfig b/configs/dra7xx_hs_evm_defconfig
index 1dff889975..f57c249f90 100644
--- a/configs/dra7xx_hs_evm_defconfig
+++ b/configs/dra7xx_hs_evm_defconfig
@@ -120,3 +120,5 @@  CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
 CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
+CONFIG_BOOTP_DNS2=y
+CONFIG_PHY_TI=y
diff --git a/configs/dra7xx_hs_evm_usb_defconfig b/configs/dra7xx_hs_evm_usb_defconfig
index fa18e1d076..1385782567 100644
--- a/configs/dra7xx_hs_evm_usb_defconfig
+++ b/configs/dra7xx_hs_evm_usb_defconfig
@@ -115,3 +115,5 @@  CONFIG_USB_GADGET=y
 CONFIG_USB_GADGET_MANUFACTURER="Texas Instruments"
 CONFIG_USB_GADGET_VENDOR_NUM=0x0451
 CONFIG_USB_GADGET_PRODUCT_NUM=0xd022
+CONFIG_BOOTP_DNS2=y
+CONFIG_PHY_TI=y
diff --git a/include/configs/dra7xx_evm.h b/include/configs/dra7xx_evm.h
index 0ad23ce4b9..0eb1cff33e 100644
--- a/include/configs/dra7xx_evm.h
+++ b/include/configs/dra7xx_evm.h
@@ -64,10 +64,8 @@ 
 #define CONFIG_HSMMC2_8BIT
 
 /* CPSW Ethernet */
-#define CONFIG_BOOTP_DNS2
 #define CONFIG_BOOTP_SEND_HOSTNAME
 #define CONFIG_NET_RETRY_COUNT		10
-#define CONFIG_PHY_TI
 
 /*
  * Default to using SPI for environment, etc.