| Message ID | 20191119144930.227241-2-tali.perry1@gmail.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | i2c: npcm7xx: new driver for I2C controller | expand |
On 2019-11-19 15:49, Tali Perry wrote: > dt-bindings: i2c: npcm7xx: * add binding for i2c controller I missing an empty line before the block of tags, but the bigger problem is the repeated subject line. Also, the '*' in the subject makes no sense to me. > Signed-off-by: Tali Perry <tali.perry1@gmail.com> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/i2c/i2c-npcm7xx.txt | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt > > diff --git a/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt > new file mode 100644 > index 000000000000..0ecae950748b > --- /dev/null > +++ b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt > @@ -0,0 +1,29 @@ > +Nuvoton NPCM7XX I2C bus > + > +The NPCM750x includes sixteen I2C bus controllers. All Controllers support > +both master and slave mode. Each controller has two 16 byte HW FIFO for TX and > +RX. > + > +Required properties: > +- compatible : must be "nuvoton,npcm750-i2c" > +- reg : Offset and length of the register set for the device. > +- interrupts : Contain the I2C interrupt with flags for falling edge. > +- clocks : phandle of I2C reference clock. > + > +Optional: > +- bus-frequency : Contain the I2C bus frequency, > + the default I2C bus frequency is 100000. > +- pinctrl-0 : must be <&smbX_pins>, X is module number > + (on NPCM7XX it's 0 to 15) Isn't this a strange requirement? Am I, as a device tree author, not free to use any label names I want? Surely, what is important is what the label refers to and not its name? Cheers, Peter > +- pinctrl-names : should be set to "default" > +Example: > + > + i2c0: i2c@80000 { > + compatible = "nuvoton,npcm750-i2c"; > + reg = <0x80000 0x1000>; > + clocks = <&clk NPCM7XX_CLK_APB2>; > + bus-frequency = <100000>; > + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&smb0_pins>; > + }; >
diff --git a/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt new file mode 100644 index 000000000000..0ecae950748b --- /dev/null +++ b/Documentation/devicetree/bindings/i2c/i2c-npcm7xx.txt @@ -0,0 +1,29 @@ +Nuvoton NPCM7XX I2C bus + +The NPCM750x includes sixteen I2C bus controllers. All Controllers support +both master and slave mode. Each controller has two 16 byte HW FIFO for TX and +RX. + +Required properties: +- compatible : must be "nuvoton,npcm750-i2c" +- reg : Offset and length of the register set for the device. +- interrupts : Contain the I2C interrupt with flags for falling edge. +- clocks : phandle of I2C reference clock. + +Optional: +- bus-frequency : Contain the I2C bus frequency, + the default I2C bus frequency is 100000. +- pinctrl-0 : must be <&smbX_pins>, X is module number + (on NPCM7XX it's 0 to 15) +- pinctrl-names : should be set to "default" +Example: + + i2c0: i2c@80000 { + compatible = "nuvoton,npcm750-i2c"; + reg = <0x80000 0x1000>; + clocks = <&clk NPCM7XX_CLK_APB2>; + bus-frequency = <100000>; + interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&smb0_pins>; + };