diff mbox

[Darwin/PR49992,1/2] remove ranlib special-casing from the darwin port.

Message ID 612C0CE1-5848-472C-85CA-6B58C5B36800@sandoe-acoustics.co.uk
State New
Headers show

Commit Message

Iain Sandoe Oct. 14, 2011, 9:36 a.m. UTC
As per the PR audit trail, there is no reason to retain this special- 
casing for Darwin.
  (given that current GCC is not build-able using Darwin toolsets of  
the vintage that required the case).

Mike has OK'd this off-list - but, since Ralf commented on the  
previous version, I'd like to give him the opportunity to comment here.
OK for trunk?
Iain

	* configure.ac: Remove ranlib special case for Darwin port.
	* gcc/configure.ac: Likewise.
	* configure: Regenerate.
	* gcc/configure: Regenerate.

Comments

Iain Sandoe Oct. 22, 2011, 7:36 a.m. UTC | #1
On 14 Oct 2011, at 10:36, Iain Sandoe wrote:

> As per the PR audit trail, there is no reason to retain this special- 
> casing for Darwin.
> (given that current GCC is not build-able using Darwin toolsets of  
> the vintage that required the case).
>
> Mike has OK'd this off-list - but, since Ralf commented on the  
> previous version, I'd like to give him the opportunity to comment  
> here.
> OK for trunk?
> Iain
>
> 	* configure.ac: Remove ranlib special case for Darwin port.
> 	* gcc/configure.ac: Likewise.
> 	* configure: Regenerate.
> 	* gcc/configure: Regenerate.
>
> Index: configure.ac
> ===================================================================
> --- configure.ac	(revision 179962)
> +++ configure.ac	(working copy)
> @@ -2274,10 +2274,6 @@ case "${target}" in
>     extra_arflags_for_target=" -X32_64"
>     extra_nmflags_for_target=" -B -X32_64"
>     ;;
> -  *-*-darwin[[3-9]]*)
> -    # ranlib before Darwin10 requires the -c flag to look at common  
> symbols.
> -    extra_ranlibflags_for_target=" -c"
> -    ;;
> esac
>
> alphaieee_frag=/dev/null
> Index: gcc/configure.ac
> ===================================================================
> --- gcc/configure.ac	(revision 179962)
> +++ gcc/configure.ac	(working copy)
> @@ -829,17 +829,7 @@ esac
> gcc_AC_PROG_LN_S
> ACX_PROG_LN($LN_S)
> AC_PROG_RANLIB
> -case "${host}" in
> -*-*-darwin*)
> -  # By default, the Darwin ranlib will not treat common symbols as
> -  # definitions when  building the archive table of contents.  Other
> -  # ranlibs do that; pass an option to the Darwin ranlib that makes
> -  # it behave similarly.
> -  ranlib_flags="-c"
> -  ;;
> -*)
> -  ranlib_flags=""
> -esac
> +ranlib_flags=""
> AC_SUBST(ranlib_flags)
>
> gcc_AC_PROG_INSTALL
>
>
>
Iain Sandoe Oct. 28, 2011, 3:41 p.m. UTC | #2
Since this is approved by Mike, if there is no further comment by  
Monday, I plan to apply it.

On 22 Oct 2011, at 08:36, Iain Sandoe wrote:

>
> On 14 Oct 2011, at 10:36, Iain Sandoe wrote:
>
>> As per the PR audit trail, there is no reason to retain this  
>> special-casing for Darwin.
>> (given that current GCC is not build-able using Darwin toolsets of  
>> the vintage that required the case).
>>
>> Mike has OK'd this off-list - but, since Ralf commented on the  
>> previous version, I'd like to give him the opportunity to comment  
>> here.
>> OK for trunk?
>> Iain
>>
>> 	* configure.ac: Remove ranlib special case for Darwin port.
>> 	* gcc/configure.ac: Likewise.
>> 	* configure: Regenerate.
>> 	* gcc/configure: Regenerate.
>>
>> Index: configure.ac
>> ===================================================================
>> --- configure.ac	(revision 179962)
>> +++ configure.ac	(working copy)
>> @@ -2274,10 +2274,6 @@ case "${target}" in
>>    extra_arflags_for_target=" -X32_64"
>>    extra_nmflags_for_target=" -B -X32_64"
>>    ;;
>> -  *-*-darwin[[3-9]]*)
>> -    # ranlib before Darwin10 requires the -c flag to look at  
>> common symbols.
>> -    extra_ranlibflags_for_target=" -c"
>> -    ;;
>> esac
>>
>> alphaieee_frag=/dev/null
>> Index: gcc/configure.ac
>> ===================================================================
>> --- gcc/configure.ac	(revision 179962)
>> +++ gcc/configure.ac	(working copy)
>> @@ -829,17 +829,7 @@ esac
>> gcc_AC_PROG_LN_S
>> ACX_PROG_LN($LN_S)
>> AC_PROG_RANLIB
>> -case "${host}" in
>> -*-*-darwin*)
>> -  # By default, the Darwin ranlib will not treat common symbols as
>> -  # definitions when  building the archive table of contents.  Other
>> -  # ranlibs do that; pass an option to the Darwin ranlib that makes
>> -  # it behave similarly.
>> -  ranlib_flags="-c"
>> -  ;;
>> -*)
>> -  ranlib_flags=""
>> -esac
>> +ranlib_flags=""
>> AC_SUBST(ranlib_flags)
>>
>> gcc_AC_PROG_INSTALL
>>
>>
>>
>
diff mbox

Patch

Index: configure.ac
===================================================================
--- configure.ac	(revision 179962)
+++ configure.ac	(working copy)
@@ -2274,10 +2274,6 @@  case "${target}" in
      extra_arflags_for_target=" -X32_64"
      extra_nmflags_for_target=" -B -X32_64"
      ;;
-  *-*-darwin[[3-9]]*)
-    # ranlib before Darwin10 requires the -c flag to look at common  
symbols.
-    extra_ranlibflags_for_target=" -c"
-    ;;
  esac

  alphaieee_frag=/dev/null
Index: gcc/configure.ac
===================================================================
--- gcc/configure.ac	(revision 179962)
+++ gcc/configure.ac	(working copy)
@@ -829,17 +829,7 @@  esac
  gcc_AC_PROG_LN_S
  ACX_PROG_LN($LN_S)
  AC_PROG_RANLIB
-case "${host}" in
-*-*-darwin*)
-  # By default, the Darwin ranlib will not treat common symbols as
-  # definitions when  building the archive table of contents.  Other
-  # ranlibs do that; pass an option to the Darwin ranlib that makes
-  # it behave similarly.
-  ranlib_flags="-c"
-  ;;
-*)
-  ranlib_flags=""
-esac
+ranlib_flags=""
  AC_SUBST(ranlib_flags)

  gcc_AC_PROG_INSTALL