Patchwork [U-Boot] hwmon: Provide dtt_init()

login
register
mail settings
Submitter Dirk Eibach
Date Oct. 14, 2011, 9:23 a.m.
Message ID <1318584192-3472-1-git-send-email-eibach@gdsys.de>
Download mbox | patch
Permalink /patch/119742/
State Accepted
Commit b88e7b3cc022241d6582733b0c389d3d1887335f
Headers show

Comments

Dirk Eibach - Oct. 14, 2011, 9:23 a.m.
Our boards rely on dtt for initialization of fan hardware.
dtt_init() was implemented to be called form board specific code.

Signed-off-by: Dirk Eibach <eibach@gdsys.de>
---
 common/cmd_dtt.c |   42 +++++++++++++++++++++++++++++++++---------
 include/dtt.h    |    1 +
 2 files changed, 34 insertions(+), 9 deletions(-)
Heiko Schocher - Oct. 19, 2011, 7:59 a.m.
Hello Dirk,

Dirk Eibach wrote:
> Our boards rely on dtt for initialization of fan hardware.
> dtt_init() was implemented to be called form board specific code.
> 
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
>  common/cmd_dtt.c |   42 +++++++++++++++++++++++++++++++++---------
>  include/dtt.h    |    1 +
>  2 files changed, 34 insertions(+), 9 deletions(-)

checkpatch clean, compiles clean and works on the enbw_cmc board, so:

Acked-by: Heiko Schocher <hs@denx.de>
Tested-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Wolfgang Denk - Oct. 21, 2011, 11:22 p.m.
Dear Dirk Eibach,

In message <1318584192-3472-1-git-send-email-eibach@gdsys.de> you wrote:
> Our boards rely on dtt for initialization of fan hardware.
> dtt_init() was implemented to be called form board specific code.
> 
> Signed-off-by: Dirk Eibach <eibach@gdsys.de>
> ---
>  common/cmd_dtt.c |   42 +++++++++++++++++++++++++++++++++---------
>  include/dtt.h    |    1 +
>  2 files changed, 34 insertions(+), 9 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/common/cmd_dtt.c b/common/cmd_dtt.c
index 5bba12d..cd94423 100644
--- a/common/cmd_dtt.c
+++ b/common/cmd_dtt.c
@@ -30,6 +30,36 @@ 
 
 static unsigned long sensor_initialized;
 
+static void _initialize_dtt(void)
+{
+	int i;
+	unsigned char sensors[] = CONFIG_DTT_SENSORS;
+
+	for (i = 0; i < sizeof(sensors); i++) {
+		if ((sensor_initialized & (1 << i)) == 0) {
+			if (dtt_init_one(sensors[i]) != 0) {
+				printf("DTT%d: Failed init!\n", i);
+				continue;
+			}
+			sensor_initialized |= (1 << i);
+		}
+	}
+}
+
+void dtt_init(void)
+{
+	int old_bus;
+
+	/* switch to correct I2C bus */
+	old_bus = I2C_GET_BUS();
+	I2C_SET_BUS(CONFIG_SYS_DTT_BUS_NUM);
+
+	_initialize_dtt();
+
+	/* switch back to original I2C bus */
+	I2C_SET_BUS(old_bus);
+}
+
 int do_dtt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 {
 	int i;
@@ -42,20 +72,14 @@  int do_dtt (cmd_tbl_t * cmdtp, int flag, int argc, char * const argv[])
 	old_bus = I2C_GET_BUS();
 	I2C_SET_BUS(CONFIG_SYS_DTT_BUS_NUM);
 
+	_initialize_dtt();
+
 	/*
 	 * Loop through sensors, read
 	 * temperature, and output it.
 	 */
-	for (i = 0; i < sizeof(sensors); i++) {
-		if ((sensor_initialized & (1 << i)) == 0) {
-			if (dtt_init_one(sensors[i]) != 0) {
-				printf("DTT%d: Failed init!\n", i);
-				continue;
-			}
-			sensor_initialized |= (1 << i);
-		}
+	for (i = 0; i < sizeof(sensors); i++)
 		printf("DTT%d: %i C\n", i + 1, dtt_get_temp(sensors[i]));
-	}
 
 	/* switch back to original I2C bus */
 	I2C_SET_BUS(old_bus);
diff --git a/include/dtt.h b/include/dtt.h
index 9e6c08c..6d5534d 100644
--- a/include/dtt.h
+++ b/include/dtt.h
@@ -52,6 +52,7 @@ 
 #endif
 #endif /* CONFIG_DTT_ADM1021 */
 
+extern void dtt_init(void);
 extern int dtt_init_one(int);
 extern int dtt_read(int sensor, int reg);
 extern int dtt_write(int sensor, int reg, int val);