[v1] travis: add ppc64le and s390x builds (issue: #615)
diff mbox series

Message ID 20191118105735.15012-1-cfamullaconrad@suse.de
State Accepted
Delegated to: Petr Vorel
Headers show
Series
  • [v1] travis: add ppc64le and s390x builds (issue: #615)
Related show

Commit Message

Clemens Famulla-Conrad Nov. 18, 2019, 10:57 a.m. UTC
Travis started to support ppc64le and s390x
https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z

This patch enable ppc64le and s390x build on debian:stable.

Remove `-i` switch from docker command as it isn't needed and caused
trouble running docker 'The input device is not a tty'.

Signed-off-by: Clemens Famulla-Conrad <cfamullaconrad@suse.de>
---
 .travis.yml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

Comments

Petr Vorel Nov. 18, 2019, 2:54 p.m. UTC | #1
Hi Clemens,

thanks a lot!
> Travis started to support ppc64le and s390x
> https://blog.travis-ci.com/2019-11-12-multi-cpu-architecture-ibm-power-ibm-z

> This patch enable ppc64le and s390x build on debian:stable.

> Remove `-i` switch from docker command as it isn't needed and caused
> trouble running docker 'The input device is not a tty'.
Interesting. Indeed, fails with -i. Don't remember, why I needed it.

LGTM, I'd just move these 2 jobs higher (above fedora), as these builds are not
usual so have higher priority to find a bug.
Change ppc64le to to debian:testing (we already have stable build for ppc64le
cross compilation).

Something like: 
https://travis-ci.org/pevik/ltp/builds/613539454
https://github.com/pevik/ltp/commit/2b69957b5838eb9f27e65ba172a71c24f15af6bd
(No need to resend a patch, both can do during merge.)

Kind regards,
Petr
Clemens Famulla-Conrad Nov. 18, 2019, 6:07 p.m. UTC | #2
Hi Petr,

On Mon, 2019-11-18 at 15:54 +0100, Petr Vorel wrote:
<snip>
> 
> LGTM, I'd just move these 2 jobs higher (above fedora), as these
> builds are not
> usual so have higher priority to find a bug.
> Change ppc64le to to debian:testing (we already have stable build for
> ppc64le
> cross compilation).

Makes sense
> 
> Something like: 
> https://travis-ci.org/pevik/ltp/builds/613539454
> https://github.com/pevik/ltp/commit/2b69957b5838eb9f27e65ba172a71c24f
> 15af6bd
> (No need to resend a patch, both can do during merge.)

Thanks a lot
looks good to me as well.
Petr Vorel Nov. 18, 2019, 8:22 p.m. UTC | #3
Hi Clements,

> > LGTM, I'd just move these 2 jobs higher (above fedora), as these
> > builds are not
> > usual so have higher priority to find a bug.
> > Change ppc64le to to debian:testing (we already have stable build for
> > ppc64le
> > cross compilation).

> Makes sense

> > Something like: 
> > https://travis-ci.org/pevik/ltp/builds/613539454
> > https://github.com/pevik/ltp/commit/2b69957b5838eb9f27e65ba172a71c24f
> > 15af6bd
> > (No need to resend a patch, both can do during merge.)

> Thanks a lot
> looks good to me as well.

Thanks for your ack, merged with slightly changed commit message.

Kind regards,
Petr

Patch
diff mbox series

diff --git a/.travis.yml b/.travis.yml
index b16a3872a..be1504b92 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -65,6 +65,16 @@  matrix:
           env: DISTRO=centos:latest
           compiler: gcc
 
+        - os: linux
+          arch: ppc64le
+          compiler: gcc
+          env: DISTRO=debian:stable
+
+        - os: linux
+          arch: s390x
+          compiler: gcc
+          env: DISTRO=debian:stable
+
 before_install:
     - DIR="/usr/src/ltp"
     - printf "FROM $DISTRO\nRUN mkdir -p $DIR\nWORKDIR $DIR\nCOPY . $DIR\n" > Dockerfile
@@ -76,4 +86,4 @@  script:
     - INSTALL="${INSTALL%%/*}"
     - if [ ! "$TREE" ]; then TREE="in"; fi
     - case $VARIANT in cross-compile*) BUILD="cross";; i386) BUILD="32";; *) BUILD="native";; esac
-    - docker run -it ltp /bin/sh -c "cd travis && ./$INSTALL.sh && if [ \"$VARIANT\" ]; then ./$INSTALL.$VARIANT.sh; fi && ../build.sh -o $TREE -t $BUILD -c $CC"
+    - docker run -t ltp /bin/sh -c "cd travis && ./$INSTALL.sh && if [ \"$VARIANT\" ]; then ./$INSTALL.$VARIANT.sh; fi && ../build.sh -o $TREE -t $BUILD -c $CC"