| Message ID | acbac03f409dd531ad58d094b1605e5752e5a17d.1574059625.git.matti.vaittinen@fi.rohmeurope.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Support ROHM BD71828 PMIC | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success |
On Mon, Nov 18, 2019 at 08:54:25AM +0200, Matti Vaittinen wrote: > Document ROHM BD71828 PMIC LED driver device tree bindings. > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > > No changes from v4 > > .../bindings/leds/rohm,bd71828-leds.yaml | 49 +++++++++++++++++++ > 1 file changed, 49 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml > > diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml > new file mode 100644 > index 000000000000..e72c9ae0fc2a > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml > @@ -0,0 +1,49 @@ > +# SPDX-License-Identifier: GPL-2.0-only Dual license please. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/rohm,bd71828-leds.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ROHM BD71828 Power Management Integrated Circuit LED driver > + > +maintainers: > + - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > + > +description: | > + This module is part of the ROHM BD71828 MFD device. For more details > + see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml. > + > + The LED controller is represented as a sub-node of the PMIC node on the device > + tree. > + > + The device has two LED outputs referred as GRNLED and AMBLED in data-sheet. Since you include this from the MFD schema, add a 'select: false' here or this node gets checked twice. > + > +properties: > + compatible: > + const: rohm,bd71828-leds > + > +patternProperties: > + "^led-[1-2]$": > + type: object > + description: > + Properties for a single LED. > + properties: > + #$ref: "common.yaml#" Will need to be: allOf: - $ref: ... > + rohm,led-compatible: > + description: LED identification string > + allOf: > + - $ref: "/schemas/types.yaml#/definitions/string" > + - oneOf: > + - const: bd71828-ambled > + - const: bd71828-grnled Use enum rather than oneOf+const > + function: > + description: > + Purpose of LED as defined in dt-bindings/leds/common.h > + $ref: "/schemas/types.yaml#/definitions/string" > + color: > + description: > + LED colour as defined in dt-bindings/leds/common.h > + $ref: "/schemas/types.yaml#/definitions/uint32" > + > +required: > + - compatible > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]
diff --git a/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml new file mode 100644 index 000000000000..e72c9ae0fc2a --- /dev/null +++ b/Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: GPL-2.0-only +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/rohm,bd71828-leds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: ROHM BD71828 Power Management Integrated Circuit LED driver + +maintainers: + - Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> + +description: | + This module is part of the ROHM BD71828 MFD device. For more details + see Documentation/devicetree/bindings/mfd/rohm,bd71828-pmic.yaml. + + The LED controller is represented as a sub-node of the PMIC node on the device + tree. + + The device has two LED outputs referred as GRNLED and AMBLED in data-sheet. + +properties: + compatible: + const: rohm,bd71828-leds + +patternProperties: + "^led-[1-2]$": + type: object + description: + Properties for a single LED. + properties: + #$ref: "common.yaml#" + rohm,led-compatible: + description: LED identification string + allOf: + - $ref: "/schemas/types.yaml#/definitions/string" + - oneOf: + - const: bd71828-ambled + - const: bd71828-grnled + function: + description: + Purpose of LED as defined in dt-bindings/leds/common.h + $ref: "/schemas/types.yaml#/definitions/string" + color: + description: + LED colour as defined in dt-bindings/leds/common.h + $ref: "/schemas/types.yaml#/definitions/uint32" + +required: + - compatible
Document ROHM BD71828 PMIC LED driver device tree bindings. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- No changes from v4 .../bindings/leds/rohm,bd71828-leds.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/rohm,bd71828-leds.yaml