[OpenWrt-Devel,17/17] ramips: disable ZyXel Keenetic by default
diff mbox series

Message ID 20191116202346.31885-18-jo@mein.io
State Accepted
Delegated to: Hauke Mehrtens
Headers show
Series
  • disable known broken device images for 19.07
Related show

Commit Message

Jo-Philipp Wich Nov. 16, 2019, 8:23 p.m. UTC
Disable the ZyXel Keenetic images by default as the device has
insufficient flash space for release build images.

Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---
 target/linux/ramips/image/rt305x.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Adrian Schmutzler Nov. 16, 2019, 11:32 p.m. UTC | #1
Hi,

this disables "Keenetic" and "Keenetic Start".

As there are so many keenetic variants flying around, I'd consider it helpful to mention both in the commit message/title.

Best

Adrian

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Jo-Philipp Wich
> Sent: Samstag, 16. November 2019 21:24
> To: openwrt-devel@lists.openwrt.org
> Cc: Jo-Philipp Wich <jo@mein.io>
> Subject: [OpenWrt-Devel] [PATCH 17/17] ramips: disable ZyXel Keenetic by
> default
> 
> Disable the ZyXel Keenetic images by default as the device has insufficient
> flash space for release build images.
> 
> Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72
> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
> ---
>  target/linux/ramips/image/rt305x.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target/linux/ramips/image/rt305x.mk
> b/target/linux/ramips/image/rt305x.mk
> index 9e599b4125..38fd1747a3 100644
> --- a/target/linux/ramips/image/rt305x.mk
> +++ b/target/linux/ramips/image/rt305x.mk
> @@ -908,6 +908,7 @@ define Device/kn
>    IMAGE_SIZE := $(ralink_default_fw_size_4M)
>    DEVICE_TITLE := ZyXEL Keenetic
>    DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ehci kmod-
> usb-ledtrig-usbport
> +  DEFAULT := n
>  endef
>  TARGET_DEVICES += kn
> 
> @@ -915,6 +916,7 @@ define Device/zyxel_keenetic-start
>    DTS := kn_st
>    IMAGE_SIZE := $(ralink_default_fw_size_4M)
>    DEVICE_TITLE := ZyXEL Keenetic Start
> +  DEFAULT := n
>  endef
>  TARGET_DEVICES += zyxel_keenetic-start
> 
> --
> 2.20.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hauke Mehrtens Nov. 29, 2019, 11 p.m. UTC | #2
On 11/17/19 12:32 AM, mail@adrianschmutzler.de wrote:
> Hi,
> 
> this disables "Keenetic" and "Keenetic Start".
> 
> As there are so many keenetic variants flying around, I'd consider it helpful to mention both in the commit message/title.
> 
> Best
> 
> Adrian

Thank you Adrian for the review.

The linked forum post only mentions the Keenetic v1 so I changed it to
do not remove the Keenetic start any more. The Keenetic Start  does not
have the USB packages in.

Hauke

> 
>> -----Original Message-----
>> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
>> On Behalf Of Jo-Philipp Wich
>> Sent: Samstag, 16. November 2019 21:24
>> To: openwrt-devel@lists.openwrt.org
>> Cc: Jo-Philipp Wich <jo@mein.io>
>> Subject: [OpenWrt-Devel] [PATCH 17/17] ramips: disable ZyXel Keenetic by
>> default
>>
>> Disable the ZyXel Keenetic images by default as the device has insufficient
>> flash space for release build images.
>>
>> Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72
>> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
>> ---
>>  target/linux/ramips/image/rt305x.mk | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/target/linux/ramips/image/rt305x.mk
>> b/target/linux/ramips/image/rt305x.mk
>> index 9e599b4125..38fd1747a3 100644
>> --- a/target/linux/ramips/image/rt305x.mk
>> +++ b/target/linux/ramips/image/rt305x.mk
>> @@ -908,6 +908,7 @@ define Device/kn
>>    IMAGE_SIZE := $(ralink_default_fw_size_4M)
>>    DEVICE_TITLE := ZyXEL Keenetic
>>    DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ehci kmod-
>> usb-ledtrig-usbport
>> +  DEFAULT := n
>>  endef
>>  TARGET_DEVICES += kn
>>
>> @@ -915,6 +916,7 @@ define Device/zyxel_keenetic-start
>>    DTS := kn_st
>>    IMAGE_SIZE := $(ralink_default_fw_size_4M)
>>    DEVICE_TITLE := ZyXEL Keenetic Start
>> +  DEFAULT := n
>>  endef
>>  TARGET_DEVICES += zyxel_keenetic-start
>>
>> --
>> 2.20.1

Patch
diff mbox series

diff --git a/target/linux/ramips/image/rt305x.mk b/target/linux/ramips/image/rt305x.mk
index 9e599b4125..38fd1747a3 100644
--- a/target/linux/ramips/image/rt305x.mk
+++ b/target/linux/ramips/image/rt305x.mk
@@ -908,6 +908,7 @@  define Device/kn
   IMAGE_SIZE := $(ralink_default_fw_size_4M)
   DEVICE_TITLE := ZyXEL Keenetic
   DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-ehci kmod-usb-ledtrig-usbport
+  DEFAULT := n
 endef
 TARGET_DEVICES += kn
 
@@ -915,6 +916,7 @@  define Device/zyxel_keenetic-start
   DTS := kn_st
   IMAGE_SIZE := $(ralink_default_fw_size_4M)
   DEVICE_TITLE := ZyXEL Keenetic Start
+  DEFAULT := n
 endef
 TARGET_DEVICES += zyxel_keenetic-start