[OpenWrt-Devel,13/17] brcm47xx: disable Netgear WNR2000 v2 by default
diff mbox series

Message ID 20191116202346.31885-14-jo@mein.io
State Under Review
Delegated to: Jo-Philipp Wich
Headers show
Series
  • disable known broken device images for 19.07
Related show

Commit Message

Jo-Philipp Wich Nov. 16, 2019, 8:23 p.m. UTC
Disable the Netgear WNR2000 v2 image by default as the device has
insufficient flash space for release build images.

Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
---
 target/linux/brcm47xx/image/Makefile | 2 ++
 1 file changed, 2 insertions(+)

Comments

Adrian Schmutzler Nov. 16, 2019, 11:30 p.m. UTC | #1
Hi,

this actually additionally disables netgear-wnr3500l-v1-na without a comment about it.

Best

Adrian

> -----Original Message-----
> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
> On Behalf Of Jo-Philipp Wich
> Sent: Samstag, 16. November 2019 21:24
> To: openwrt-devel@lists.openwrt.org
> Cc: Jo-Philipp Wich <jo@mein.io>
> Subject: [OpenWrt-Devel] [PATCH 13/17] brcm47xx: disable Netgear
> WNR2000 v2 by default
> 
> Disable the Netgear WNR2000 v2 image by default as the device has
> insufficient flash space for release build images.
> 
> Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72
> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
> ---
>  target/linux/brcm47xx/image/Makefile | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/target/linux/brcm47xx/image/Makefile
> b/target/linux/brcm47xx/image/Makefile
> index c2bf9d41d5..969d523956 100644
> --- a/target/linux/brcm47xx/image/Makefile
> +++ b/target/linux/brcm47xx/image/Makefile
> @@ -916,6 +916,7 @@ define Device/netgear-wnr2000v2
>    $(Device/netgear)
>    NETGEAR_BOARD_ID := U12H114T00_NETGEAR
>    NETGEAR_REGION := 2
> +  DEFAULT := n
>  endef
>  TARGET_DEVICES += netgear-wnr2000v2
> 
> @@ -925,6 +926,7 @@ define Device/netgear-wnr3500l-v1-na
>    $(Device/netgear)
>    NETGEAR_BOARD_ID := U12H136T99_NETGEAR
>    NETGEAR_REGION := 2
> +  DEFAULT := n
>  endef
>  TARGET_DEVICES += netgear-wnr3500l-v1-na
> 
> --
> 2.20.1
> 
> 
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel@lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel
Hauke Mehrtens Nov. 29, 2019, 11:01 p.m. UTC | #2
On 11/17/19 12:30 AM, mail@adrianschmutzler.de wrote:
> Hi,
> 
> this actually additionally disables netgear-wnr3500l-v1-na without a comment about it.
> 
> Best
> 
> Adrian
Thank you Adrian for the review.

The linked forum post only mentions the wnr2000v2 and not the wnr3500l
which has 8MB of flash, I only remove the wnr2000v2.

Hauke

> 
>> -----Original Message-----
>> From: openwrt-devel [mailto:openwrt-devel-bounces@lists.openwrt.org]
>> On Behalf Of Jo-Philipp Wich
>> Sent: Samstag, 16. November 2019 21:24
>> To: openwrt-devel@lists.openwrt.org
>> Cc: Jo-Philipp Wich <jo@mein.io>
>> Subject: [OpenWrt-Devel] [PATCH 13/17] brcm47xx: disable Netgear
>> WNR2000 v2 by default
>>
>> Disable the Netgear WNR2000 v2 image by default as the device has
>> insufficient flash space for release build images.
>>
>> Ref: https://forum.openwrt.org/t/devices-too-big-to-save-overlay/18161/72
>> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
>> ---
>>  target/linux/brcm47xx/image/Makefile | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/target/linux/brcm47xx/image/Makefile
>> b/target/linux/brcm47xx/image/Makefile
>> index c2bf9d41d5..969d523956 100644
>> --- a/target/linux/brcm47xx/image/Makefile
>> +++ b/target/linux/brcm47xx/image/Makefile
>> @@ -916,6 +916,7 @@ define Device/netgear-wnr2000v2
>>    $(Device/netgear)
>>    NETGEAR_BOARD_ID := U12H114T00_NETGEAR
>>    NETGEAR_REGION := 2
>> +  DEFAULT := n
>>  endef
>>  TARGET_DEVICES += netgear-wnr2000v2
>>
>> @@ -925,6 +926,7 @@ define Device/netgear-wnr3500l-v1-na
>>    $(Device/netgear)
>>    NETGEAR_BOARD_ID := U12H136T99_NETGEAR
>>    NETGEAR_REGION := 2
>> +  DEFAULT := n
>>  endef
>>  TARGET_DEVICES += netgear-wnr3500l-v1-na
>>
>> --
>> 2.20.1

Patch
diff mbox series

diff --git a/target/linux/brcm47xx/image/Makefile b/target/linux/brcm47xx/image/Makefile
index c2bf9d41d5..969d523956 100644
--- a/target/linux/brcm47xx/image/Makefile
+++ b/target/linux/brcm47xx/image/Makefile
@@ -916,6 +916,7 @@  define Device/netgear-wnr2000v2
   $(Device/netgear)
   NETGEAR_BOARD_ID := U12H114T00_NETGEAR
   NETGEAR_REGION := 2
+  DEFAULT := n
 endef
 TARGET_DEVICES += netgear-wnr2000v2
 
@@ -925,6 +926,7 @@  define Device/netgear-wnr3500l-v1-na
   $(Device/netgear)
   NETGEAR_BOARD_ID := U12H136T99_NETGEAR
   NETGEAR_REGION := 2
+  DEFAULT := n
 endef
 TARGET_DEVICES += netgear-wnr3500l-v1-na