[libgpiod,19/19] treewide: change "correspond with" to "correspond to"
diff mbox series

Message ID 20191115144355.975-20-warthog618@gmail.com
State New
Headers show
Series
  • Add support for bias flags and SET_CONFIG
Related show

Commit Message

Kent Gibson Nov. 15, 2019, 2:43 p.m. UTC
Trivial grammar fix. "correspond with" can mean either being in agreement
with, happening at the same time, or communication between parties.
"correspond to" is used to mean equivalance, which is the intended use
throughout the documentation.

Signed-off-by: Kent Gibson <warthog618@gmail.com>
---
 bindings/python/gpiodmodule.c | 6 +++---
 include/gpiod.h               | 2 +-
 lib/core.c                    | 2 +-
 tests/mockup/gpio-mockup.c    | 2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

Comments

Bartosz Golaszewski Nov. 18, 2019, 1:52 p.m. UTC | #1
pt., 15 lis 2019 o 15:45 Kent Gibson <warthog618@gmail.com> napisał(a):
>
> Trivial grammar fix. "correspond with" can mean either being in agreement
> with, happening at the same time, or communication between parties.
> "correspond to" is used to mean equivalance, which is the intended use
> throughout the documentation.
>

Thanks for this. I'm not a native English speaker, so if you see any
other language issues, please let me know, or feel free to fix them.

Bart

> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>  bindings/python/gpiodmodule.c | 6 +++---
>  include/gpiod.h               | 2 +-
>  lib/core.c                    | 2 +-
>  tests/mockup/gpio-mockup.c    | 2 +-
>  4 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/bindings/python/gpiodmodule.c b/bindings/python/gpiodmodule.c
> index 4949b14..74fbea3 100644
> --- a/bindings/python/gpiodmodule.c
> +++ b/bindings/python/gpiodmodule.c
> @@ -1330,7 +1330,7 @@ PyDoc_STRVAR(gpiod_LineBulk_get_values_doc,
>  "get_values() -> list of integers\n"
>  "\n"
>  "Read the values of all the lines held by this LineBulk object. The index\n"
> -"of each value in the returned list corresponds with the index of the line\n"
> +"of each value in the returned list corresponds to the index of the line\n"
>  "in this gpiod.LineBulk object.");
>
>  static PyObject *gpiod_LineBulk_get_values(gpiod_LineBulkObject *self,
> @@ -1385,7 +1385,7 @@ PyDoc_STRVAR(gpiod_LineBulk_set_values_doc,
>  "\n"
>  "The number of values in the list passed as argument must be the same as\n"
>  "the number of lines held by this gpiod.LineBulk object. The index of each\n"
> -"value corresponds with the index of each line in the object.\n");
> +"value corresponds to the index of each line in the object.\n");
>
>  static PyObject *gpiod_LineBulk_set_values(gpiod_LineBulkObject *self,
>                                            PyObject *args)
> @@ -1408,7 +1408,7 @@ static PyObject *gpiod_LineBulk_set_values(gpiod_LineBulkObject *self,
>         num_vals = PyObject_Size(val_list);
>         if (self->num_lines != num_vals) {
>                 PyErr_SetString(PyExc_TypeError,
> -                               "Number of values must correspond with the number of lines");
> +                               "Number of values must correspond to the number of lines");
>                 return NULL;
>         }
>
> diff --git a/include/gpiod.h b/include/gpiod.h
> index 4053fd2..6776852 100644
> --- a/include/gpiod.h
> +++ b/include/gpiod.h
> @@ -779,7 +779,7 @@ gpiod_line_bulk_num_lines(struct gpiod_line_bulk *bulk)
>   *
>   * This is a variant of ::gpiod_line_bulk_foreach_line which uses an integer
>   * variable (either signed or unsigned) to store the loop state. This offset
> - * variable is guaranteed to correspond with the offset of the current line in
> + * variable is guaranteed to correspond to the offset of the current line in
>   * the bulk->lines array.
>   */
>  #define gpiod_line_bulk_foreach_line_off(bulk, line, offset)           \
> diff --git a/lib/core.c b/lib/core.c
> index 2e54def..54ae09c 100644
> --- a/lib/core.c
> +++ b/lib/core.c
> @@ -111,7 +111,7 @@ static bool is_gpiochip_cdev(const char *path)
>
>         /*
>          * Make sure the major and minor numbers of the character device
> -        * correspond with the ones in the dev attribute in sysfs.
> +        * correspond to the ones in the dev attribute in sysfs.
>          */
>         snprintf(devstr, sizeof(devstr), "%u:%u",
>                  major(statbuf.st_rdev), minor(statbuf.st_rdev));
> diff --git a/tests/mockup/gpio-mockup.c b/tests/mockup/gpio-mockup.c
> index e3a53da..fa27bd7 100644
> --- a/tests/mockup/gpio-mockup.c
> +++ b/tests/mockup/gpio-mockup.c
> @@ -333,7 +333,7 @@ EXPORT int gpio_mockup_probe(struct gpio_mockup *ctx, unsigned int num_chips,
>         /*
>          * We can't assume that the order in which the mockup gpiochip
>          * devices are created will be deterministic, yet we want the
> -        * index passed to the test_chip_*() functions to correspond with the
> +        * index passed to the test_chip_*() functions to correspond to the
>          * order in which the chips were defined in the TEST_DEFINE()
>          * macro.
>          *
> --
> 2.24.0
>
Kent Gibson Nov. 18, 2019, 3:01 p.m. UTC | #2
On Mon, Nov 18, 2019 at 02:52:56PM +0100, Bartosz Golaszewski wrote:
> pt., 15 lis 2019 o 15:45 Kent Gibson <warthog618@gmail.com> napisał(a):
> >
> > Trivial grammar fix. "correspond with" can mean either being in agreement
> > with, happening at the same time, or communication between parties.
> > "correspond to" is used to mean equivalance, which is the intended use
> > throughout the documentation.
> >
> 
> Thanks for this. I'm not a native English speaker, so if you see any
> other language issues, please let me know, or feel free to fix them.
> 

In general usage you most often see "correspond with" in the
communication sense. Using it in the other senses is rare.
Ironically I wasn't totally sure on the usage without looking it up, but
it felt wrong as it was.  There are one or two cases in the documentation
where the "in agreement with" interpretation might work, but even there
the "correspond to" felt more appropriate to me.

Cheers,
Kent.

Patch
diff mbox series

diff --git a/bindings/python/gpiodmodule.c b/bindings/python/gpiodmodule.c
index 4949b14..74fbea3 100644
--- a/bindings/python/gpiodmodule.c
+++ b/bindings/python/gpiodmodule.c
@@ -1330,7 +1330,7 @@  PyDoc_STRVAR(gpiod_LineBulk_get_values_doc,
 "get_values() -> list of integers\n"
 "\n"
 "Read the values of all the lines held by this LineBulk object. The index\n"
-"of each value in the returned list corresponds with the index of the line\n"
+"of each value in the returned list corresponds to the index of the line\n"
 "in this gpiod.LineBulk object.");
 
 static PyObject *gpiod_LineBulk_get_values(gpiod_LineBulkObject *self,
@@ -1385,7 +1385,7 @@  PyDoc_STRVAR(gpiod_LineBulk_set_values_doc,
 "\n"
 "The number of values in the list passed as argument must be the same as\n"
 "the number of lines held by this gpiod.LineBulk object. The index of each\n"
-"value corresponds with the index of each line in the object.\n");
+"value corresponds to the index of each line in the object.\n");
 
 static PyObject *gpiod_LineBulk_set_values(gpiod_LineBulkObject *self,
 					   PyObject *args)
@@ -1408,7 +1408,7 @@  static PyObject *gpiod_LineBulk_set_values(gpiod_LineBulkObject *self,
 	num_vals = PyObject_Size(val_list);
 	if (self->num_lines != num_vals) {
 		PyErr_SetString(PyExc_TypeError,
-				"Number of values must correspond with the number of lines");
+				"Number of values must correspond to the number of lines");
 		return NULL;
 	}
 
diff --git a/include/gpiod.h b/include/gpiod.h
index 4053fd2..6776852 100644
--- a/include/gpiod.h
+++ b/include/gpiod.h
@@ -779,7 +779,7 @@  gpiod_line_bulk_num_lines(struct gpiod_line_bulk *bulk)
  *
  * This is a variant of ::gpiod_line_bulk_foreach_line which uses an integer
  * variable (either signed or unsigned) to store the loop state. This offset
- * variable is guaranteed to correspond with the offset of the current line in
+ * variable is guaranteed to correspond to the offset of the current line in
  * the bulk->lines array.
  */
 #define gpiod_line_bulk_foreach_line_off(bulk, line, offset)		\
diff --git a/lib/core.c b/lib/core.c
index 2e54def..54ae09c 100644
--- a/lib/core.c
+++ b/lib/core.c
@@ -111,7 +111,7 @@  static bool is_gpiochip_cdev(const char *path)
 
 	/*
 	 * Make sure the major and minor numbers of the character device
-	 * correspond with the ones in the dev attribute in sysfs.
+	 * correspond to the ones in the dev attribute in sysfs.
 	 */
 	snprintf(devstr, sizeof(devstr), "%u:%u",
 		 major(statbuf.st_rdev), minor(statbuf.st_rdev));
diff --git a/tests/mockup/gpio-mockup.c b/tests/mockup/gpio-mockup.c
index e3a53da..fa27bd7 100644
--- a/tests/mockup/gpio-mockup.c
+++ b/tests/mockup/gpio-mockup.c
@@ -333,7 +333,7 @@  EXPORT int gpio_mockup_probe(struct gpio_mockup *ctx, unsigned int num_chips,
 	/*
 	 * We can't assume that the order in which the mockup gpiochip
 	 * devices are created will be deterministic, yet we want the
-	 * index passed to the test_chip_*() functions to correspond with the
+	 * index passed to the test_chip_*() functions to correspond to the
 	 * order in which the chips were defined in the TEST_DEFINE()
 	 * macro.
 	 *