From patchwork Fri Nov 15 09:47:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aleksander Morgado X-Patchwork-Id: 1195506 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.138; helo=whitealder.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=aleksander.es Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=aleksander-es.20150623.gappssmtp.com header.i=@aleksander-es.20150623.gappssmtp.com header.b="ItJU84sc"; dkim-atps=neutral Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47DtnT5D7nz9sP6 for ; Fri, 15 Nov 2019 20:47:55 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 2CEF388BB2; Fri, 15 Nov 2019 09:47:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Qiougj5-0jEt; Fri, 15 Nov 2019 09:47:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id B8C0688B77; Fri, 15 Nov 2019 09:47:50 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 80E051BF3AA for ; Fri, 15 Nov 2019 09:47:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 777B8894D1 for ; Fri, 15 Nov 2019 09:47:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WPo6ssK8qW-9 for ; Fri, 15 Nov 2019 09:47:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by hemlock.osuosl.org (Postfix) with ESMTPS id 00E5789489 for ; Fri, 15 Nov 2019 09:47:47 +0000 (UTC) Received: by mail-wr1-f67.google.com with SMTP id e6so10261144wrw.1 for ; Fri, 15 Nov 2019 01:47:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aleksander-es.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JZCybH2MTJfK+kd/YMLErO8GlXOS6+ADJeoyBCwFrpE=; b=ItJU84sc7BvQm317lwVljbRAHtqleQqNSGq/4St2zTSrN33QTCvnh/1ou9LisR9ciY L2jNCqjMK5Mnho77VQ80L8YnqsJalaDifDg/cPh/VN8k0n8SK3oEEnpkNrW858nbADi7 /oQ+Qsr2BFkGzyUBQJyTSGZ6vLCb0eNQGV3tAVZL1U2Pc8QZtTzF14NU8hybROK34+Q+ y0aakuj5YxjQBlWwVeMRbDC46HGz/IRDR477e25P9KZn+g6IOKOtr3YMi4GdpiN9oZv1 hyJWnsEbHBAfBJXygyf/3QC3YCZHGVgiSR1c77lpLFWGCzDUeW7CrDfO6IImGJYeCBlE oYKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=JZCybH2MTJfK+kd/YMLErO8GlXOS6+ADJeoyBCwFrpE=; b=KgzmY9M0gBmFKR7gfAXR74gok88rfxDJ1dJu1SXL0/8VKZbXcGI5SYNOFxEl0VRU+s EmJPXbp6IQtwh5sy/2LKZFlULXm0+7VQLIOnOeUOq0S0XkwEIEPivHY+5ogwzVN2saO9 6l94Vy31JtGFTNjTfADLsUgIsCWbGFIYwW7FgdUdi+HKZsLjFacCiV0QPpbqz9LgiBUb jnYT9RMFL0HiKHpIvN63aEwZbpfVukvj01ub41SGH0cbKvORmfE4FyqKE/mDzdS/LV5f YueT4DDMiKUbG5V0Y0l0FDVZKiJ6LAWZ4yELUqB8bIRS0uVUC4NwTS4iXdJgN0/slXSN cXHA== X-Gm-Message-State: APjAAAX7bNaA9RFEkgS1L01RW1bkQdQieSGIURFl9hLq8pz9dFhajFGB YnYuOV8KZkNfpg68KhAl59tv54L3gL4= X-Google-Smtp-Source: APXvYqzrhh/w/NyHovS9LIcAqTNiYeWwa5E4dBS43i05FreTDWTslM7GLu+cGX2N17scg2Fm0DfXlA== X-Received: by 2002:adf:e78d:: with SMTP id n13mr12896251wrm.59.1573811265555; Fri, 15 Nov 2019 01:47:45 -0800 (PST) Received: from ares.lan (232.red-88-3-18.dynamicip.rima-tde.net. [88.3.18.232]) by smtp.gmail.com with ESMTPSA id t5sm10412405wro.76.2019.11.15.01.47.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2019 01:47:44 -0800 (PST) From: Aleksander Morgado To: unixmania@gmail.com, yegorslists@googlemail.com, thomas.petazzoni@bootlin.com Date: Fri, 15 Nov 2019 10:47:41 +0100 Message-Id: <20191115094741.59903-1-aleksander@aleksander.es> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH/next] modem-manager: fix order of libraries when linking X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aleksander Morgado , buildroot@buildroot.org Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Fixes the following build failure: http://autobuild.buildroot.net/results/2386d296fd00fca506053d213806200f4bca80d7/build-end.log Signed-off-by: Aleksander Morgado --- Hey Thomas, Haven't been able to locally reproduce this build failure, not even playing with --as-needed, but I believe this patch should solve it (applicable to next branch!) Cheers! --- ...test-fix-order-of-included-libraries.patch | 40 +++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 package/modem-manager/0001-build-test-fix-order-of-included-libraries.patch -- 2.24.0 diff --git a/package/modem-manager/0001-build-test-fix-order-of-included-libraries.patch b/package/modem-manager/0001-build-test-fix-order-of-included-libraries.patch new file mode 100644 index 0000000000..de3918fec0 --- /dev/null +++ b/package/modem-manager/0001-build-test-fix-order-of-included-libraries.patch @@ -0,0 +1,40 @@ +From 64b31d64c6824e33082cd947989f060be4b87d2f Mon Sep 17 00:00:00 2001 +From: Aleksander Morgado +Date: Fri, 15 Nov 2019 09:52:39 +0100 +Subject: [PATCH] build,test: fix order of included libraries + +Symbols are resolved forward, so if libhelpers depends on libmm-glib, +it needs to be specified first. + +(cherry picked from commit 42dab8e827d84b86d0f7253ce68748758f29aef1) +--- + test/Makefile.am | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +diff --git a/test/Makefile.am b/test/Makefile.am +index 20e2a068..ba737bc5 100644 +--- a/test/Makefile.am ++++ b/test/Makefile.am +@@ -87,8 +87,8 @@ mmsmspdu_CPPFLAGS = \ + + mmsmspdu_LDADD = \ + $(MM_LIBS) \ +- $(top_builddir)/libmm-glib/libmm-glib.la \ + $(top_builddir)/src/libhelpers.la \ ++ $(top_builddir)/libmm-glib/libmm-glib.la \ + $(NULL) + + ################################################################################ +@@ -112,8 +112,8 @@ mmsmsmonitor_CPPFLAGS = \ + + mmsmsmonitor_LDADD = \ + $(MM_LIBS) \ +- $(top_builddir)/libmm-glib/libmm-glib.la \ + $(top_builddir)/src/libhelpers.la \ ++ $(top_builddir)/libmm-glib/libmm-glib.la \ + $(NULL) + + ################################################################################ +-- +2.24.0 +