Patchwork [U-Boot] mpc5200: digsy_mtc: fix detection of Coral-PA

login
register
mail settings
Submitter Anatolij Gustschin
Date Oct. 13, 2011, 3:19 p.m.
Message ID <1318519157-4945-1-git-send-email-agust@denx.de>
Download mbox | patch
Permalink /patch/119549/
State Accepted
Commit 4fc823ddb43ab26a393da49f356fcad208e7064f
Headers show

Comments

Anatolij Gustschin - Oct. 13, 2011, 3:19 p.m.
A delay of approximately 250 ms after PCI bus reset in
pci_mpc5xxx_init() is needed to recognize the Coral-PA
controller on the graphic extention board.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
To make it actually work another patch
"pci: move pcidelay code to new location just before PCI bus scan"
is also required. It has been submitted earlier [1] and there is
already some positive feedback.

[1] http://patchwork.ozlabs.org/patch/119171/

 include/configs/digsy_mtc.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Detlev Zundel - Oct. 14, 2011, 8:19 a.m.
Hi Anatolij,

> A delay of approximately 250 ms after PCI bus reset in
> pci_mpc5xxx_init() is needed to recognize the Coral-PA
> controller on the graphic extention board.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> To make it actually work another patch
> "pci: move pcidelay code to new location just before PCI bus scan"
> is also required. It has been submitted earlier [1] and there is
> already some positive feedback.
>
> [1] http://patchwork.ozlabs.org/patch/119171/

Acked-by: Detlev Zundel <dzu@denx.de>
Wolfgang Denk - Oct. 15, 2011, 8:19 p.m.
Dear Anatolij Gustschin,

In message <1318519157-4945-1-git-send-email-agust@denx.de> you wrote:
> A delay of approximately 250 ms after PCI bus reset in
> pci_mpc5xxx_init() is needed to recognize the Coral-PA
> controller on the graphic extention board.
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> To make it actually work another patch
> "pci: move pcidelay code to new location just before PCI bus scan"
> is also required. It has been submitted earlier [1] and there is
> already some positive feedback.
> 
> [1] http://patchwork.ozlabs.org/patch/119171/
> 
>  include/configs/digsy_mtc.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/include/configs/digsy_mtc.h b/include/configs/digsy_mtc.h
index 522ec57..d0d1eda 100644
--- a/include/configs/digsy_mtc.h
+++ b/include/configs/digsy_mtc.h
@@ -70,6 +70,7 @@ 
 #define CONFIG_PCI		1
 #define CONFIG_PCI_PNP		1
 #define CONFIG_PCI_SCAN_SHOW	1
+#define CONFIG_PCI_BOOTDELAY	250
 
 #define CONFIG_PCI_MEM_BUS	0x40000000
 #define CONFIG_PCI_MEM_PHYS	CONFIG_PCI_MEM_BUS