| Message ID | 20191115062454.7025-1-hslester96@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | net: gemini: add missed free_netdev | expand |
On Fri, Nov 15, 2019 at 7:25 AM Chuhong Yuan <hslester96@gmail.com> wrote: > This driver forgets to free allocated netdev in remove like > what is done in probe failure. > Add the free to fix it. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Looks correct! Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
From: Chuhong Yuan <hslester96@gmail.com> Date: Fri, 15 Nov 2019 14:24:54 +0800 > This driver forgets to free allocated netdev in remove like > what is done in probe failure. > Add the free to fix it. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Applied and queued up for -stable, thank you.
diff --git a/drivers/net/ethernet/cortina/gemini.c b/drivers/net/ethernet/cortina/gemini.c index e736ce2c58ca..a8f4c69252ff 100644 --- a/drivers/net/ethernet/cortina/gemini.c +++ b/drivers/net/ethernet/cortina/gemini.c @@ -2524,6 +2524,7 @@ static int gemini_ethernet_port_remove(struct platform_device *pdev) struct gemini_ethernet_port *port = platform_get_drvdata(pdev); gemini_port_remove(port); + free_netdev(port->netdev); return 0; }
This driver forgets to free allocated netdev in remove like what is done in probe failure. Add the free to fix it. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/net/ethernet/cortina/gemini.c | 1 + 1 file changed, 1 insertion(+)