[GIT,PULL,v2] firmware: arm_scmi: fix for v5.5
mbox series

Message ID 20191114164555.GA19398@bogus
State New
Headers show
Series
  • [GIT,PULL,v2] firmware: arm_scmi: fix for v5.5
Related show

Pull-request

git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git tags/scmi-fix-5.5

Message

Sudeep Holla Nov. 14, 2019, 4:45 p.m. UTC
Hi ARM SoC Team,

Stephen Rothwell reported issue[1] with fixes tag in the commit. I have
fixed the same and re-tagged it. Please drop the earlier PR and use
this one based on your preference(I am not sure if want to ignore or
fix it). Sorry for the silly mistake.

Please pull !

Regards,
Sudeep

[1] https://lore.kernel.org/lkml/20191114202122.0f38eab6@canb.auug.org.au/

-->8

The following changes since commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c:

  Linux 5.4-rc1 (2019-09-30 10:35:40 -0700)

are available in the Git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux.git tags/scmi-fix-5.5

for you to fetch changes up to 7bd39bc6bfdf96f5df0f92199bbc1a3ee2f2adb8:

  firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT (2019-11-14 11:13:50 +0000)

----------------------------------------------------------------
ARM SCMI fix for v5.5

Just a single fix to correct the SCMI fast channel doorbell ring logic
when CONFIG_64BIT is not set.

----------------------------------------------------------------
Sudeep Holla (1):
      firmware: arm_scmi: Fix doorbell ring logic for !CONFIG_64BIT

 drivers/firmware/arm_scmi/perf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Olof Johansson Nov. 16, 2019, 11:34 p.m. UTC | #1
On Thu, Nov 14, 2019 at 04:45:55PM +0000, Sudeep Holla wrote:
> Hi ARM SoC Team,
> 
> Stephen Rothwell reported issue[1] with fixes tag in the commit. I have
> fixed the same and re-tagged it. Please drop the earlier PR and use
> this one based on your preference(I am not sure if want to ignore or
> fix it). Sorry for the silly mistake.

Usually we don't re-merge once we pick something up, but in this case it's at
the top of the branch so I did rebase with this version.

We should be running linters on the pull requests in patchwork so this is
caught before we merge, it's on the todo list but not done yet.

-Olof
Sudeep Holla Nov. 18, 2019, 10:31 a.m. UTC | #2
On Sat, Nov 16, 2019 at 03:34:52PM -0800, Olof Johansson wrote:
> On Thu, Nov 14, 2019 at 04:45:55PM +0000, Sudeep Holla wrote:
> > Hi ARM SoC Team,
> >
> > Stephen Rothwell reported issue[1] with fixes tag in the commit. I have
> > fixed the same and re-tagged it. Please drop the earlier PR and use
> > this one based on your preference(I am not sure if want to ignore or
> > fix it). Sorry for the silly mistake.
>
> Usually we don't re-merge once we pick something up, but in this case it's at
> the top of the branch so I did rebase with this version.
>

I understand, thanks. Sorry for the trouble.

> We should be running linters on the pull requests in patchwork so this is
> caught before we merge, it's on the todo list but not done yet.
>

I think even checkpatch reports such issues, I must have ignored it by
accident. I will be more careful in the future.

--
Regards,
Sudeep