diff mbox series

[1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension

Message ID 1573738166-12850-1-git-send-email-michael.schenk@noser.com
State Changes Requested
Headers show
Series [1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension | expand

Commit Message

Schenk Michael Nov. 14, 2019, 1:29 p.m. UTC
Signed-off-by: Michael Schenk <michael.schenk@noser.com>
---
 boot/arm-trusted-firmware/Config.in               | 7 +++++++
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
 2 files changed, 10 insertions(+), 1 deletion(-)

Comments

Sergey Matyukevich Nov. 15, 2019, 7:29 a.m. UTC | #1
> Signed-off-by: Michael Schenk <michael.schenk@noser.com>
> ---
>  boot/arm-trusted-firmware/Config.in               | 7 +++++++
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)

Reviewed-by: Sergey Matyukevich <geomatsi@gmail.com>

Regards,
Sergey
Yegor Yefremov Nov. 15, 2019, 7:36 a.m. UTC | #2
Hi Michael,

could you fix the patch title/commit log?

Title: add pattern based copy for ATF as already used for u-boot

Commit log: This adds support for different platforms where the
binaries have different extensions.


On Thu, Nov 14, 2019 at 4:02 PM Schenk Michael <michael.schenk@noser.com> wrote:
>
> Signed-off-by: Michael Schenk <michael.schenk@noser.com>
> ---
>  boot/arm-trusted-firmware/Config.in               | 7 +++++++
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
> index beb95fb..78c0301 100644
> --- a/boot/arm-trusted-firmware/Config.in
> +++ b/boot/arm-trusted-firmware/Config.in
> @@ -135,4 +135,11 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
>         help
>           Enable this option to build ATF with DEBUG=1.
>
> +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
> +       string "Binary boot images"
> +       default "*.bin"
> +       help
> +         Names of generated image files that are installed in the
> +         output images/ directory.

Please precise the list type. Is it space separated or comma separated.

Regards,
Yegor

> +
>  endif
> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index a7814e5..e528686 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -146,7 +146,9 @@ define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
>  endef
>
>  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
> -       cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
> +       $(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
> +               cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
> +       )
>         $(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
>         $(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
>  endef
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
diff mbox series

Patch

diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
index beb95fb..78c0301 100644
--- a/boot/arm-trusted-firmware/Config.in
+++ b/boot/arm-trusted-firmware/Config.in
@@ -135,4 +135,11 @@  config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
 	help
 	  Enable this option to build ATF with DEBUG=1.
 
+config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
+	string "Binary boot images"
+	default "*.bin"
+	help
+	  Names of generated image files that are installed in the
+	  output images/ directory.
+
 endif
diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index a7814e5..e528686 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -146,7 +146,9 @@  define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
 endef
 
 define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
-	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
+	$(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
+		cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
+	)
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
 endef