| Message ID | 20191114073946.46340-1-yuehaibing@huawei.com |
|---|---|
| State | Accepted |
| Delegated to: | David Miller |
| Headers | show |
| Series | [net-next] net/tls: Fix unused function warning | expand |
On Thu, 14 Nov 2019 15:39:46 +0800, YueHaibing wrote: > If PROC_FS is not set, gcc warning this: > > net/tls/tls_proc.c:23:12: warning: > 'tls_statistics_seq_show' defined but not used [-Wunused-function] > > Use #ifdef to guard this. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
From: YueHaibing <yuehaibing@huawei.com> Date: Thu, 14 Nov 2019 15:39:46 +0800 > If PROC_FS is not set, gcc warning this: > > net/tls/tls_proc.c:23:12: warning: > 'tls_statistics_seq_show' defined but not used [-Wunused-function] > > Use #ifdef to guard this. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Signed-off-by: YueHaibing <yuehaibing@huawei.com> Applied.
diff --git a/net/tls/tls_proc.c b/net/tls/tls_proc.c index 83d9c80..3a5dd1e 100644 --- a/net/tls/tls_proc.c +++ b/net/tls/tls_proc.c @@ -6,6 +6,7 @@ #include <net/snmp.h> #include <net/tls.h> +#ifdef CONFIG_PROC_FS static const struct snmp_mib tls_mib_list[] = { SNMP_MIB_ITEM("TlsCurrTxSw", LINUX_MIB_TLSCURRTXSW), SNMP_MIB_ITEM("TlsCurrRxSw", LINUX_MIB_TLSCURRRXSW), @@ -32,6 +33,7 @@ static int tls_statistics_seq_show(struct seq_file *seq, void *v) return 0; } +#endif int __net_init tls_proc_init(struct net *net) {
If PROC_FS is not set, gcc warning this: net/tls/tls_proc.c:23:12: warning: 'tls_statistics_seq_show' defined but not used [-Wunused-function] Use #ifdef to guard this. Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- net/tls/tls_proc.c | 2 ++ 1 file changed, 2 insertions(+)