[-next] ubi: remove unused variable 'err'
diff mbox series

Message ID 20191114072236.15104-1-yuehaibing@huawei.com
State Superseded
Headers show
Series
  • [-next] ubi: remove unused variable 'err'
Related show

Commit Message

YueHaibing Nov. 14, 2019, 7:22 a.m. UTC
drivers/mtd/ubi/debug.c:512:6: warning: unused variable 'err' [-Wunused-variable]

commit 3427dd213259 ("mtd: no need to check return value
of debugfs_create functions") leave this variable not used.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/mtd/ubi/debug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Miquel Raynal Nov. 14, 2019, 10 a.m. UTC | #1
Hi Yue,

YueHaibing <yuehaibing@huawei.com> wrote on Thu, 14 Nov 2019 15:22:36
+0800:

> drivers/mtd/ubi/debug.c:512:6: warning: unused variable 'err' [-Wunused-variable]
> 
> commit 3427dd213259 ("mtd: no need to check return value
> of debugfs_create functions") leave this variable not used.

Thanks for the fix but I already fixed this trivial issue, I just
did not had time yesterday night to push it, now it is done. It will
be part of tomorrow's linux-next release.

Cheers,
Miquèl
YueHaibing Nov. 14, 2019, 1:13 p.m. UTC | #2
On 2019/11/14 18:00, Miquel Raynal wrote:
> Hi Yue,
> 
> YueHaibing <yuehaibing@huawei.com> wrote on Thu, 14 Nov 2019 15:22:36
> +0800:
> 
>> drivers/mtd/ubi/debug.c:512:6: warning: unused variable 'err' [-Wunused-variable]
>>
>> commit 3427dd213259 ("mtd: no need to check return value
>> of debugfs_create functions") leave this variable not used.
> 
> Thanks for the fix but I already fixed this trivial issue, I just
> did not had time yesterday night to push it, now it is done. It will
> be part of tomorrow's linux-next release.

Ok, thanks for the info.

> 
> Cheers,
> Miquèl
> 
> .
>

Patch
diff mbox series

diff --git a/drivers/mtd/ubi/debug.c b/drivers/mtd/ubi/debug.c
index f8d3752..8dba1b5 100644
--- a/drivers/mtd/ubi/debug.c
+++ b/drivers/mtd/ubi/debug.c
@@ -509,7 +509,7 @@  static const struct file_operations eraseblk_count_fops = {
  */
 int ubi_debugfs_init_dev(struct ubi_device *ubi)
 {
-	int err, n;
+	int n;
 	unsigned long ubi_num = ubi->ubi_num;
 	struct ubi_debug_info *d = &ubi->dbg;