[OpenWrt-Devel] build: support python 3.8
diff mbox series

Message ID 20191113200931.106783-1-thomas@t-8ch.de
State Accepted
Delegated to: Petr Štetiar
Headers show
Series
  • [OpenWrt-Devel] build: support python 3.8
Related show

Commit Message

Thomas Weißschuh Nov. 13, 2019, 8:09 p.m. UTC
Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---
 include/prereq-build.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Paul Spooren Nov. 13, 2019, 9:37 p.m. UTC | #1
LGTM

On 11/13/19 10:09 AM, Thomas Weißschuh wrote:
> Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
> ---
>   include/prereq-build.mk | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/include/prereq-build.mk b/include/prereq-build.mk
> index 4c59910056..65baf1f5e5 100644
> --- a/include/prereq-build.mk
> +++ b/include/prereq-build.mk
> @@ -144,12 +144,14 @@ $(eval $(call SetupHostCommand,perl,Please install Perl 5.x, \
>   $(eval $(call CleanupPython2))
>   
>   $(eval $(call SetupHostCommand,python,Please install Python >= 3.5, \
> +	python3.8 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3.7 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3.6 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3.5 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?'))
>   
>   $(eval $(call SetupHostCommand,python3,Please install Python >= 3.5, \
> +	python3.8 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3.7 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3.6 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
>   	python3.5 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
Petr Štetiar Nov. 14, 2019, 4:03 p.m. UTC | #2
Thomas Weißschuh <thomas@t-8ch.de> [2019-11-13 21:09:31]:

Hi,

please next time don't forget to add commit description https://git.openwrt.org/b2960a952d1c204712519ba91819e25764a72fd4

-- ynezz

Patch
diff mbox series

diff --git a/include/prereq-build.mk b/include/prereq-build.mk
index 4c59910056..65baf1f5e5 100644
--- a/include/prereq-build.mk
+++ b/include/prereq-build.mk
@@ -144,12 +144,14 @@  $(eval $(call SetupHostCommand,perl,Please install Perl 5.x, \
 $(eval $(call CleanupPython2))
 
 $(eval $(call SetupHostCommand,python,Please install Python >= 3.5, \
+	python3.8 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3.7 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3.6 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3.5 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?'))
 
 $(eval $(call SetupHostCommand,python3,Please install Python >= 3.5, \
+	python3.8 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3.7 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3.6 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \
 	python3.5 -V 2>&1 | grep -E 'Python 3\.[5-9]\.?', \