Message ID | 201110131309.26032.bzolnier@gmail.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Thu, 13 Oct 2011 13:09:25 +0200 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] pata_ali: cleanup ali_set_piomode() > > Merge ali_fifo_control() calls. > > This changes behavior but there shouldn't be any problems with it. > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> It's not really much of a 'clean' and the old behaviour matches the documentation. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_ali.c =================================================================== --- a/drivers/ata/pata_ali.c +++ b/drivers/ata/pata_ali.c @@ -222,12 +222,9 @@ static void ali_set_piomode(struct ata_p } /* PIO FIFO is only permitted on ATA disk */ - if (adev->class != ATA_DEV_ATA) - ali_fifo_control(ap, adev, 0x00); - ali_program_modes(ap, adev, &t, 0); - if (adev->class == ATA_DEV_ATA) - ali_fifo_control(ap, adev, 0x05); + ali_fifo_control(ap, adev, (adev->class == ATA_DEV_ATA) ? 0x05 : 0x00); + ali_program_modes(ap, adev, &t, 0); } /**