| Message ID | 1573660292-10629-4-git-send-email-fabrizio.castro@bp.renesas.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | Add LCD panel support to iwg20d | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | warning | "total: 0 errors, 1 warnings, 26 lines checked" |
| robh/dt-meta-schema | success |
On Wed, 13 Nov 2019 15:51:22 +0000, Fabrizio Castro wrote: > ti,ds90c185.txt documents LVDS encoders using the same driver > as the one documented by lvds-transmitter.yaml. > Since the properties listed in ti,ds90c185.txt are the same > as the ones listed in lvds-transmitter.yaml, absorb the dt-binding > into lvds-transmitter.yaml. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> > > --- > v3->v4: > * New patch > --- > .../bindings/display/bridge/lvds-transmitter.yaml | 14 +++--- > .../bindings/display/bridge/ti,ds90c185.txt | 55 ---------------------- > 2 files changed, 8 insertions(+), 61 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > Reviewed-by: Rob Herring <robh@kernel.org>
Hi Fabrizio, Thank you for the patch. On Wed, Nov 13, 2019 at 03:51:22PM +0000, Fabrizio Castro wrote: > ti,ds90c185.txt documents LVDS encoders using the same driver > as the one documented by lvds-transmitter.yaml. > Since the properties listed in ti,ds90c185.txt are the same > as the ones listed in lvds-transmitter.yaml, absorb the dt-binding > into lvds-transmitter.yaml. > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > v3->v4: > * New patch > --- > .../bindings/display/bridge/lvds-transmitter.yaml | 14 +++--- > .../bindings/display/bridge/ti,ds90c185.txt | 55 ---------------------- > 2 files changed, 8 insertions(+), 61 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > index 2484737..a8326ce 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > @@ -31,11 +31,13 @@ description: | > properties: > compatible: > description: | > - Any encoder compatible with this generic binding, but with additional > - properties not listed here, must define its own binding and list a device > - specific compatible first followed by the generic compatible. > - enum: > - - lvds-encoder > + Must list the device specific compatible string first, followed by the > + generic compatible string. > + items: > + - enum: > + - ti,ds90c185 # For the TI DS90C185 FPD-Link Serializer > + - ti,ds90c187 # For the TI DS90C187 FPD-Link Serializer > + - const: lvds-encoder # Generic LVDS encoder compatible fallback > > ports: > type: object > @@ -69,7 +71,7 @@ required: > examples: > - | > lvds-encoder { > - compatible = "lvds-encoder"; > + compatible = "ti,ds90c185", "lvds-encoder"; > > ports { > #address-cells = <1>; > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > deleted file mode 100644 > index e575f99..0000000 > --- a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > +++ /dev/null > @@ -1,55 +0,0 @@ > -Texas Instruments FPD-Link (LVDS) Serializer > --------------------------------------------- > - > -The DS90C185 and DS90C187 are low-power serializers for portable > -battery-powered applications that reduces the size of the RGB > -interface between the host GPU and the display. > - > -Required properties: > - > -- compatible: Should be > - "ti,ds90c185", "lvds-encoder" for the TI DS90C185 FPD-Link Serializer > - "ti,ds90c187", "lvds-encoder" for the TI DS90C187 FPD-Link Serializer > - > -Optional properties: > - > -- powerdown-gpios: Power down control GPIO (the PDB pin, active-low) > - > -Required nodes: > - > -The devices have two video ports. Their connections are modeled using the OF > -graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - > -- Video port 0 for parallel input > -- Video port 1 for LVDS output > - > - > -Example > -------- > - > -lvds-encoder { > - compatible = "ti,ds90c185", "lvds-encoder"; > - > - powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - lvds_enc_in: endpoint { > - remote-endpoint = <&lcdc_out_rgb>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - lvds_enc_out: endpoint { > - remote-endpoint = <&lvds_panel_in>; > - }; > - }; > - }; > -}; > -- > 2.7.4 >
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml index 2484737..a8326ce 100644 --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml @@ -31,11 +31,13 @@ description: | properties: compatible: description: | - Any encoder compatible with this generic binding, but with additional - properties not listed here, must define its own binding and list a device - specific compatible first followed by the generic compatible. - enum: - - lvds-encoder + Must list the device specific compatible string first, followed by the + generic compatible string. + items: + - enum: + - ti,ds90c185 # For the TI DS90C185 FPD-Link Serializer + - ti,ds90c187 # For the TI DS90C187 FPD-Link Serializer + - const: lvds-encoder # Generic LVDS encoder compatible fallback ports: type: object @@ -69,7 +71,7 @@ required: examples: - | lvds-encoder { - compatible = "lvds-encoder"; + compatible = "ti,ds90c185", "lvds-encoder"; ports { #address-cells = <1>; diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt deleted file mode 100644 index e575f99..0000000 --- a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt +++ /dev/null @@ -1,55 +0,0 @@ -Texas Instruments FPD-Link (LVDS) Serializer --------------------------------------------- - -The DS90C185 and DS90C187 are low-power serializers for portable -battery-powered applications that reduces the size of the RGB -interface between the host GPU and the display. - -Required properties: - -- compatible: Should be - "ti,ds90c185", "lvds-encoder" for the TI DS90C185 FPD-Link Serializer - "ti,ds90c187", "lvds-encoder" for the TI DS90C187 FPD-Link Serializer - -Optional properties: - -- powerdown-gpios: Power down control GPIO (the PDB pin, active-low) - -Required nodes: - -The devices have two video ports. Their connections are modeled using the OF -graph bindings specified in Documentation/devicetree/bindings/graph.txt. - -- Video port 0 for parallel input -- Video port 1 for LVDS output - - -Example -------- - -lvds-encoder { - compatible = "ti,ds90c185", "lvds-encoder"; - - powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; - - ports { - #address-cells = <1>; - #size-cells = <0>; - - port@0 { - reg = <0>; - - lvds_enc_in: endpoint { - remote-endpoint = <&lcdc_out_rgb>; - }; - }; - - port@1 { - reg = <1>; - - lvds_enc_out: endpoint { - remote-endpoint = <&lvds_panel_in>; - }; - }; - }; -};
ti,ds90c185.txt documents LVDS encoders using the same driver as the one documented by lvds-transmitter.yaml. Since the properties listed in ti,ds90c185.txt are the same as the ones listed in lvds-transmitter.yaml, absorb the dt-binding into lvds-transmitter.yaml. Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com> --- v3->v4: * New patch --- .../bindings/display/bridge/lvds-transmitter.yaml | 14 +++--- .../bindings/display/bridge/ti,ds90c185.txt | 55 ---------------------- 2 files changed, 8 insertions(+), 61 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt