[07/11] package/lvm2: drop optional readline dependency
diff mbox series

Message ID 20191113151724.12155-8-peter@korsgaard.com
State Accepted
Headers show
Series
  • Fix license incompatibility with readline
Related show

Commit Message

Peter Korsgaard Nov. 13, 2019, 3:17 p.m. UTC
lvm2 is licensed under GPL-2.0, which is not license compatible with
readline (GPL-3.0+), so drop the optional dependency and add a comment
explaining why.

Notice: The readline support is only used when the raw lvm tool is called
without arguments.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/lvm2/lvm2.mk | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Yann E. MORIN Nov. 13, 2019, 9 p.m. UTC | #1
Peter, All,

On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
> lvm2 is licensed under GPL-2.0, which is not license compatible with
> readline (GPL-3.0+), so drop the optional dependency and add a comment
> explaining why.
> 
> Notice: The readline support is only used when the raw lvm tool is called
> without arguments.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to master, thanks.

Regards,
Yann E. MORIN.

> ---
>  package/lvm2/lvm2.mk | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
> index 7fdb9a7e30..14575668a5 100644
> --- a/package/lvm2/lvm2.mk
> +++ b/package/lvm2/lvm2.mk
> @@ -28,13 +28,8 @@ LVM2_DEPENDENCIES += host-pkgconf libaio
>  # take into account the toolchain passed at configure time.
>  LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
>  
> -ifeq ($(BR2_PACKAGE_READLINE),y)
> -LVM2_DEPENDENCIES += readline
> -else
> -# v2.02.44: disable readline usage, or binaries are linked against provider
> -# of "tgetent" (=> ncurses) even if it's not used..
> +# package/readline is GPL-3.0+, so not license compatible
>  LVM2_CONF_OPTS += --disable-readline
> -endif
>  
>  ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
>  LVM2_CONF_OPTS += --enable-selinux
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Nov. 19, 2019, 7:39 a.m. UTC | #2
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > lvm2 is licensed under GPL-2.0, which is not license compatible with
 > readline (GPL-3.0+), so drop the optional dependency and add a comment
 > explaining why.

 > Notice: The readline support is only used when the raw lvm tool is called
 > without arguments.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2019.02.x and 2019.08.x, thanks.

Patch
diff mbox series

diff --git a/package/lvm2/lvm2.mk b/package/lvm2/lvm2.mk
index 7fdb9a7e30..14575668a5 100644
--- a/package/lvm2/lvm2.mk
+++ b/package/lvm2/lvm2.mk
@@ -28,13 +28,8 @@  LVM2_DEPENDENCIES += host-pkgconf libaio
 # take into account the toolchain passed at configure time.
 LVM2_MAKE_ENV = $(TARGET_CONFIGURE_OPTS)
 
-ifeq ($(BR2_PACKAGE_READLINE),y)
-LVM2_DEPENDENCIES += readline
-else
-# v2.02.44: disable readline usage, or binaries are linked against provider
-# of "tgetent" (=> ncurses) even if it's not used..
+# package/readline is GPL-3.0+, so not license compatible
 LVM2_CONF_OPTS += --disable-readline
-endif
 
 ifeq ($(BR2_PACKAGE_LIBSELINUX),y)
 LVM2_CONF_OPTS += --enable-selinux