[03/11] package/dropwatch: license is GPL-2.0+
diff mbox series

Message ID 20191113151724.12155-4-peter@korsgaard.com
State Accepted
Headers show
Series
  • Fix license incompatibility with readline
Related show

Commit Message

Peter Korsgaard Nov. 13, 2019, 3:17 p.m. UTC
Dropwatch links with readline, which is GPL-3.0+, so not compatible with
GPL-2.0.  When asked about this, upstream has clarified that the license
really is GPL-2.0+:

https://github.com/nhorman/dropwatch/issues/14

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/dropwatch/dropwatch.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Baruch Siach Nov. 13, 2019, 4:19 p.m. UTC | #1
Hi Peter,

On Wed, Nov 13 2019, Peter Korsgaard wrote:

> Dropwatch links with readline, which is GPL-3.0+, so not compatible with
> GPL-2.0.  When asked about this, upstream has clarified that the license
> really is GPL-2.0+:
>
> https://github.com/nhorman/dropwatch/issues/14
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
>  package/dropwatch/dropwatch.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/dropwatch/dropwatch.mk b/package/dropwatch/dropwatch.mk
> index 1af61458e0..53d3683c5a 100644
> --- a/package/dropwatch/dropwatch.mk
> +++ b/package/dropwatch/dropwatch.mk
> @@ -7,7 +7,7 @@
>  DROPWATCH_VERSION = 1.5.1
>  DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION))
>  DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES)
> -DROPWATCH_LICENSE = GPL-2.0
> +DROPWATCH_LICENSE = GPL-2.0+

Maybe add a link to upstream license clarification in a comment?

baruch

>  DROPWATCH_LICENSE_FILES = COPYING
>  # From git
>  DROPWATCH_AUTORECONF = YES
Yann E. MORIN Nov. 13, 2019, 7 p.m. UTC | #2
Peter, All,

On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
> Dropwatch links with readline, which is GPL-3.0+, so not compatible with
> GPL-2.0.  When asked about this, upstream has clarified that the license
> really is GPL-2.0+:
> 
> https://github.com/nhorman/dropwatch/issues/14
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to master, after adding a comment as suggested by Baruch,
thanks.

Regards,
Yann E. MORIN.

> ---
>  package/dropwatch/dropwatch.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/dropwatch/dropwatch.mk b/package/dropwatch/dropwatch.mk
> index 1af61458e0..53d3683c5a 100644
> --- a/package/dropwatch/dropwatch.mk
> +++ b/package/dropwatch/dropwatch.mk
> @@ -7,7 +7,7 @@
>  DROPWATCH_VERSION = 1.5.1
>  DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION))
>  DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES)
> -DROPWATCH_LICENSE = GPL-2.0
> +DROPWATCH_LICENSE = GPL-2.0+
>  DROPWATCH_LICENSE_FILES = COPYING
>  # From git
>  DROPWATCH_AUTORECONF = YES
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Peter Korsgaard Nov. 13, 2019, 7:15 p.m. UTC | #3
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:

 > Hi Peter,
 > On Wed, Nov 13 2019, Peter Korsgaard wrote:

 >> Dropwatch links with readline, which is GPL-3.0+, so not compatible with
 >> GPL-2.0.  When asked about this, upstream has clarified that the license
 >> really is GPL-2.0+:
 >> 
 >> https://github.com/nhorman/dropwatch/issues/14
 >> 
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
 >> ---
 >> package/dropwatch/dropwatch.mk | 2 +-
 >> 1 file changed, 1 insertion(+), 1 deletion(-)
 >> 
 >> diff --git a/package/dropwatch/dropwatch.mk b/package/dropwatch/dropwatch.mk
 >> index 1af61458e0..53d3683c5a 100644
 >> --- a/package/dropwatch/dropwatch.mk
 >> +++ b/package/dropwatch/dropwatch.mk
 >> @@ -7,7 +7,7 @@
 >> DROPWATCH_VERSION = 1.5.1
 >> DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION))
 >> DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES)
 >> -DROPWATCH_LICENSE = GPL-2.0
 >> +DROPWATCH_LICENSE = GPL-2.0+

 > Maybe add a link to upstream license clarification in a comment?

True, lets do that when committing. Upstream has not actually made any
changes to the repo yet though.
Peter Korsgaard Nov. 18, 2019, 1:08 p.m. UTC | #4
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > Dropwatch links with readline, which is GPL-3.0+, so not compatible with
 > GPL-2.0.  When asked about this, upstream has clarified that the license
 > really is GPL-2.0+:

 > https://github.com/nhorman/dropwatch/issues/14

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2019.08.x, thanks. 2019.02.x uses a different version, I
will try to get some feedback from upstream if GPL-2.0+ also applies
there.

Patch
diff mbox series

diff --git a/package/dropwatch/dropwatch.mk b/package/dropwatch/dropwatch.mk
index 1af61458e0..53d3683c5a 100644
--- a/package/dropwatch/dropwatch.mk
+++ b/package/dropwatch/dropwatch.mk
@@ -7,7 +7,7 @@ 
 DROPWATCH_VERSION = 1.5.1
 DROPWATCH_SITE = $(call github,nhorman,dropwatch,v$(DROPWATCH_VERSION))
 DROPWATCH_DEPENDENCIES = libnl readline host-pkgconf $(TARGET_NLS_DEPENDENCIES)
-DROPWATCH_LICENSE = GPL-2.0
+DROPWATCH_LICENSE = GPL-2.0+
 DROPWATCH_LICENSE_FILES = COPYING
 # From git
 DROPWATCH_AUTORECONF = YES