[02/11] package/connman: clarify license of client code
diff mbox series

Message ID 20191113151724.12155-3-peter@korsgaard.com
State Accepted
Headers show
Series
  • Fix license incompatibility with readline
Related show

Commit Message

Peter Korsgaard Nov. 13, 2019, 3:17 p.m. UTC
While the core connman code is licensed under GPL-2.0, the client code is
GPL-2.0+ for compatibility with readline (which is GPL-3.0+).

Extend the _LICENSE with this info to clarify that linking against
readline is OK licensing wise.

Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
 package/connman/connman.mk | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN Nov. 13, 2019, 6:56 p.m. UTC | #1
Peter, All,

On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
> While the core connman code is licensed under GPL-2.0, the client code is
> GPL-2.0+ for compatibility with readline (which is GPL-3.0+).
> 
> Extend the _LICENSE with this info to clarify that linking against
> readline is OK licensing wise.
> 
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Applied to master, thanks.

It's a pity they do not have a license file for it, though...

Regards,
Yann E. MORIN.

> ---
>  package/connman/connman.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
> index 839bc7a0e2..7ca49726dd 100644
> --- a/package/connman/connman.mk
> +++ b/package/connman/connman.mk
> @@ -39,6 +39,7 @@ define CONNMAN_INSTALL_INIT_SYSTEMD
>  endef
>  
>  ifeq ($(BR2_PACKAGE_CONNMAN_CLIENT),y)
> +CONNMAN_LICENSE += , GPL-2.0+ (client)
>  CONNMAN_CONF_OPTS += --enable-client
>  CONNMAN_DEPENDENCIES += readline
>  
> -- 
> 2.20.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Arnout Vandecappelle Nov. 17, 2019, 4:03 p.m. UTC | #2
On 13/11/2019 19:56, Yann E. MORIN wrote:
> Peter, All,
> 
> On 2019-11-13 16:17 +0100, Peter Korsgaard spake thusly:
>> While the core connman code is licensed under GPL-2.0, the client code is
>> GPL-2.0+ for compatibility with readline (which is GPL-3.0+).
>>
>> Extend the _LICENSE with this info to clarify that linking against
>> readline is OK licensing wise.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> 
> Applied to master, thanks.
> 
> It's a pity they do not have a license file for it, though...

 The license file would be identical, because the GPL license files don't
include the "or later" clause - that is only in the source files, and possibly
in a README or similar.

 Regards,
 Arnout

> 
> Regards,
> Yann E. MORIN.
> 
>> ---
>>  package/connman/connman.mk | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/package/connman/connman.mk b/package/connman/connman.mk
>> index 839bc7a0e2..7ca49726dd 100644
>> --- a/package/connman/connman.mk
>> +++ b/package/connman/connman.mk
>> @@ -39,6 +39,7 @@ define CONNMAN_INSTALL_INIT_SYSTEMD
>>  endef
>>  
>>  ifeq ($(BR2_PACKAGE_CONNMAN_CLIENT),y)
>> +CONNMAN_LICENSE += , GPL-2.0+ (client)
>>  CONNMAN_CONF_OPTS += --enable-client
>>  CONNMAN_DEPENDENCIES += readline
>>  
>> -- 
>> 2.20.1
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
Peter Korsgaard Nov. 18, 2019, 1:02 p.m. UTC | #3
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:

 > While the core connman code is licensed under GPL-2.0, the client code is
 > GPL-2.0+ for compatibility with readline (which is GPL-3.0+).

 > Extend the _LICENSE with this info to clarify that linking against
 > readline is OK licensing wise.

 > Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

Committed to 2019.02.x and 2019.08.x, thanks.

Patch
diff mbox series

diff --git a/package/connman/connman.mk b/package/connman/connman.mk
index 839bc7a0e2..7ca49726dd 100644
--- a/package/connman/connman.mk
+++ b/package/connman/connman.mk
@@ -39,6 +39,7 @@  define CONNMAN_INSTALL_INIT_SYSTEMD
 endef
 
 ifeq ($(BR2_PACKAGE_CONNMAN_CLIENT),y)
+CONNMAN_LICENSE += , GPL-2.0+ (client)
 CONNMAN_CONF_OPTS += --enable-client
 CONNMAN_DEPENDENCIES += readline