[DOC] Document -fallocation-dce.
diff mbox series

Message ID dd3b8d84-7cdc-0609-0bde-46c5d350a3e9@suse.cz
State New
Headers show
Series
  • [DOC] Document -fallocation-dce.
Related show

Commit Message

Martin Liška Nov. 13, 2019, 1:45 p.m. UTC
Hi.

The patch is about a documentation entry for a newly added
option in GCC 10.

Ready for trunk?
Martin

gcc/ChangeLog:

2019-11-13  Martin Liska  <mliska@suse.cz>

	PR other/92329
	* doc/invoke.texi: Document -fallocation-dce.
---
  gcc/doc/invoke.texi | 8 +++++++-
  1 file changed, 7 insertions(+), 1 deletion(-)

Comments

Sandra Loosemore Nov. 13, 2019, 3:25 p.m. UTC | #1
On 11/13/19 6:45 AM, Martin Liška wrote:
> Hi.
> 
> The patch is about a documentation entry for a newly added
> option in GCC 10.
> 
> Ready for trunk?

I thought this would be OK, until I saw:

> +Enabled by default.

At the beginning of invoke.texi where it is talking about options having 
both -foo and -fno-foo forms, it says "This manual documents
only one of these two forms, whichever one is not the default."  So I 
think you should be documenting -fno-allocation-dce here instead of the 
positive form.

-Sandra
Martin Liška Nov. 14, 2019, 8:43 a.m. UTC | #2
On 11/13/19 4:25 PM, Sandra Loosemore wrote:
> On 11/13/19 6:45 AM, Martin Liška wrote:
>> Hi.
>>
>> The patch is about a documentation entry for a newly added
>> option in GCC 10.
>>
>> Ready for trunk?
> 
> I thought this would be OK, until I saw:
> 
>> +Enabled by default.
> 
> At the beginning of invoke.texi where it is talking about options having both -foo and -fno-foo forms, it says "This manual documents
> only one of these two forms, whichever one is not the default."  So I think you should be documenting -fno-allocation-dce here instead of the positive form.

Thank you for the review.
I've changed that and I'm going to install the patch.

Martin

> 
> -Sandra

Patch
diff mbox series

diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi
index 00eb7e77808..eb8c505f17b 100644
--- a/gcc/doc/invoke.texi
+++ b/gcc/doc/invoke.texi
@@ -407,7 +407,7 @@  Objective-C and Objective-C++ Dialects}.
 -falign-jumps[=@var{n}[:@var{m}:[@var{n2}[:@var{m2}]]]] @gol
 -falign-labels[=@var{n}[:@var{m}:[@var{n2}[:@var{m2}]]]] @gol
 -falign-loops[=@var{n}[:@var{m}:[@var{n2}[:@var{m2}]]]] @gol
--fallow-store-data-races @gol
+-fallocation-dce -fallow-store-data-races @gol
 -fassociative-math  -fauto-profile  -fauto-profile[=@var{path}] @gol
 -fauto-inc-dec  -fbranch-probabilities @gol
 -fcaller-saves @gol
@@ -10267,6 +10267,12 @@  The maximum allowed @var{n} option value is 65536.
 
 Enabled at levels @option{-O2}, @option{-O3}.
 
+@item -fallocation-dce
+@opindex fallocation-dce
+Tell dead code elimination to remove unused C++ allocations.
+
+Enabled by default.
+
 @item -fallow-store-data-races
 @opindex fallow-store-data-races
 Allow the compiler to introduce new data races on stores.