Patchwork spi/tegra: fix compilation error in spi-tegra.c

login
register
mail settings
Submitter Marc Dietrich
Date Oct. 13, 2011, 9:01 a.m.
Message ID <1458857.A6MEb356Lm@fb07-iapwap2>
Download mbox | patch
Permalink /patch/119389/
State New, archived
Headers show

Comments

Marc Dietrich - Oct. 13, 2011, 9:01 a.m.
Add #include <linux/module.h> to spi-tegra.c to fix a compilation error
after the removal of module.h from device.h (in patch: "include: replace 
linux/module.h with "struct module" wherever possible").

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
Acked-by: Olof Johansson <olof@lixom.net>
---

Hi Grant,

this fixes the error below:

  CC      drivers/spi/spi-tegra.o
drivers/spi/spi-tegra.c:597: error: expected declaration specifiers or '...' before 
string constant
drivers/spi/spi-tegra.c:597: warning: data definition has no type or storage class
drivers/spi/spi-tegra.c:597: warning: type defaults to 'int' in declaration of 
'MODULE_ALIAS'
drivers/spi/spi-tegra.c:597: warning: function declaration isn't a prototype
drivers/spi/spi-tegra.c:604: warning: data definition has no type or storage class
drivers/spi/spi-tegra.c:604: warning: type defaults to 'int' in declaration of 
'MODULE_DEVICE_TABLE'
drivers/spi/spi-tegra.c:604: warning: parameter names (without types) in function 
declaration
drivers/spi/spi-tegra.c:612: error: 'THIS_MODULE' undeclared here (not in a function)
drivers/spi/spi-tegra.c:630: error: expected declaration specifiers or '...' before 
string constant
drivers/spi/spi-tegra.c:630: warning: data definition has no type or storage class
drivers/spi/spi-tegra.c:630: warning: type defaults to 'int' in declaration of 
'MODULE_LICENSE'
drivers/spi/spi-tegra.c:630: warning: function declaration isn't a prototype
make[2]: *** [drivers/spi/spi-tegra.o] Error 1

It is against linux-next (for 3.2). Please apply.

Thanks
			Marc

--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Grant Likely - Oct. 13, 2011, 7:27 p.m.
On Thu, Oct 13, 2011 at 11:01:33AM +0200, Marc Dietrich wrote:
> Add #include <linux/module.h> to spi-tegra.c to fix a compilation error
> after the removal of module.h from device.h (in patch: "include: replace 
> linux/module.h with "struct module" wherever possible").
> 
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> Acked-by: Olof Johansson <olof@lixom.net>

Applied, thanks

g.

> ---
> 
> Hi Grant,
> 
> this fixes the error below:
> 
>   CC      drivers/spi/spi-tegra.o
> drivers/spi/spi-tegra.c:597: error: expected declaration specifiers or '...' before 
> string constant
> drivers/spi/spi-tegra.c:597: warning: data definition has no type or storage class
> drivers/spi/spi-tegra.c:597: warning: type defaults to 'int' in declaration of 
> 'MODULE_ALIAS'
> drivers/spi/spi-tegra.c:597: warning: function declaration isn't a prototype
> drivers/spi/spi-tegra.c:604: warning: data definition has no type or storage class
> drivers/spi/spi-tegra.c:604: warning: type defaults to 'int' in declaration of 
> 'MODULE_DEVICE_TABLE'
> drivers/spi/spi-tegra.c:604: warning: parameter names (without types) in function 
> declaration
> drivers/spi/spi-tegra.c:612: error: 'THIS_MODULE' undeclared here (not in a function)
> drivers/spi/spi-tegra.c:630: error: expected declaration specifiers or '...' before 
> string constant
> drivers/spi/spi-tegra.c:630: warning: data definition has no type or storage class
> drivers/spi/spi-tegra.c:630: warning: type defaults to 'int' in declaration of 
> 'MODULE_LICENSE'
> drivers/spi/spi-tegra.c:630: warning: function declaration isn't a prototype
> make[2]: *** [drivers/spi/spi-tegra.o] Error 1
> 
> It is against linux-next (for 3.2). Please apply.
> 
> Thanks
> 			Marc
> 
> diff --git a/drivers/spi/spi-tegra.c b/drivers/spi/spi-tegra.c
> index a5a6302..e8cd58f 100644
> --- a/drivers/spi/spi-tegra.c
> +++ b/drivers/spi/spi-tegra.c
> @@ -18,6 +18,7 @@
>   */
>  
>  #include <linux/kernel.h>
> +#include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/err.h>
>  #include <linux/platform_device.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/spi/spi-tegra.c b/drivers/spi/spi-tegra.c
index a5a6302..e8cd58f 100644
--- a/drivers/spi/spi-tegra.c
+++ b/drivers/spi/spi-tegra.c
@@ -18,6 +18,7 @@ 
  */
 
 #include <linux/kernel.h>
+#include <linux/module.h>
 #include <linux/init.h>
 #include <linux/err.h>
 #include <linux/platform_device.h>