From patchwork Tue Nov 12 19:37:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Fontaine X-Patchwork-Id: 1193796 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="t/8N1ipQ"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47CJ2j2Kp7z9sNH for ; Wed, 13 Nov 2019 06:38:53 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 326C18560E; Tue, 12 Nov 2019 19:38:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rg5ynGlR0ZVR; Tue, 12 Nov 2019 19:38:50 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id AB75085775; Tue, 12 Nov 2019 19:38:50 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id A26FD1BF968 for ; Tue, 12 Nov 2019 19:38:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9F1ED85775 for ; Tue, 12 Nov 2019 19:38:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YlX9LWcFWBKd for ; Tue, 12 Nov 2019 19:38:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 46D4E8560E for ; Tue, 12 Nov 2019 19:38:48 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id w9so13081893wrr.0 for ; Tue, 12 Nov 2019 11:38:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WnTRxjdbsRlExqoaOIoGVEURK/PzR6xji7fgJnj/ndI=; b=t/8N1ipQUSePmdiOiViFJw4OKDtpzICfEnZxRKuQo2qCHMSSz59snMyK20AUInIiPa rtYTLjkGA6ODxzBsIh+K20bgT9Unw6MTQ/bndlq6aObXWVSCRWjXukmwBLz6ecN61dbX PLUb98/bBh7+DaHtMFEwa03SNbzzyBkQcKeTE9VoSl1s+zug9V2CJBg6zkdSp7TOYi/Q gqjXiddlNCutyYD5oZU/AyP8mq5lZqVNoAF/wvQSInIyF6qdRosN2ImJOrrZ5UcfSi+p TidRyupTS5VoOVUSBuZWwz0MIb9kxXu/As1R6JiVAEkhjdh+vofJVgXvjJJe8nYLFI84 E2rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WnTRxjdbsRlExqoaOIoGVEURK/PzR6xji7fgJnj/ndI=; b=P0ysY3GPwP/+AkiiYh5Zf+2RJiqY5L0hut0E7tk1aJVNUgzihasAh7y8OSVs/jv4ed KKq3yqCMX4XRRh00xWZtLMnQJN2FoNV8FDZvhlDZHB9VG5WUHUvyWmK1vkx8DB4/r1J7 Kv8Xl4Gu3iJql4zdhiysywJARAwkbXDs313nxb7EUg6W04ckxK85GtZmAtTuJ7D7qG4N Bs9I1mwUd2+7vIGrCD77M0JngFswhCwxGXe949cz7xa8cbYx0GAKDnoQFSZmxyMVBi2c mCFsRvTr7vCPLMbuS7P+YlkqsoYx/iaTE+8Wa6d6MgJkCYHM+JVoKz3wafdFJUsWti6M tfkA== X-Gm-Message-State: APjAAAUrQ/74gXfR+xQz7TcwEzPpGeUDZv378HfYiuiHFf75Esc7ohIr AK2IfwnlAti+1ZLwAMhRxCwL2kzO X-Google-Smtp-Source: APXvYqxJOgwzVYUh0r/Y96ADCkubUTpI7XqkRoGcgYSx+CAfEmD2B8L7YXH759/J09F70ulIqMiQZA== X-Received: by 2002:adf:9506:: with SMTP id 6mr28796784wrs.274.1573587526034; Tue, 12 Nov 2019 11:38:46 -0800 (PST) Received: from kali.home (lfbn-1-3732-187.w86-229.abo.wanadoo.fr. [86.229.230.187]) by smtp.gmail.com with ESMTPSA id 205sm6276065wmb.3.2019.11.12.11.38.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Nov 2019 11:38:45 -0800 (PST) From: Fabrice Fontaine To: buildroot@buildroot.org Date: Tue, 12 Nov 2019 20:37:56 +0100 Message-Id: <20191112193756.32212-1-fontaine.fabrice@gmail.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Subject: [Buildroot] [PATCH 1/1] package/gstreamer1/gst1-plugins-base: gl needs api, platform and window X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabrice Fontaine , Adam Duskett Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" Build will fail if gl is enabled without an api, a platform and a window: Message: No OpenGL Platforms found or requested Message: No OpenGL Window systems found or requested gst-libs/gst/gl/meson.build:948:2: ERROR: Problem encountered: GStreamer OpenGL integration required via options, but needed dependencies not found. This requirement is already specified in Config.in through a simple comment: comment "The opengl library needs an API, a platform and a window system" depends on !BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL Fixes: - http://autobuild.buildroot.org/results/d171059801adf8dea1a2116d7c729a2aa5767ac8 - http://autobuild.buildroot.org/results/b1bfa505bba534440d331c4948eea5eb2d165c97 Signed-off-by: Fabrice Fontaine --- .../gstreamer1/gst1-plugins-base/gst1-plugins-base.mk | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk index 21a29cbea2..108a19d7b0 100644 --- a/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk +++ b/package/gstreamer1/gst1-plugins-base/gst1-plugins-base.mk @@ -38,19 +38,22 @@ else GST1_PLUGINS_BASE_CONF_OPTS += -Dorc=disabled endif -ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API),y) +ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_API)$(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_PLATFORM)$(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_HAS_WINDOW),yyy) GST1_PLUGINS_BASE_CONF_OPTS += -Dgl=enabled +else +GST1_PLUGINS_BASE_CONF_OPTS += -Dgl=disabled +endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_OPENGL),y) GST1_PLUGINS_BASE_GL_API_LIST = opengl GST1_PLUGINS_BASE_DEPENDENCIES += libgl libglu endif + ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_GLES2),y) GST1_PLUGINS_BASE_GL_API_LIST += gles2 GST1_PLUGINS_BASE_DEPENDENCIES += libgles endif -else -GST1_PLUGINS_BASE_CONF_OPTS += -Dgl=disabled -endif + GST1_PLUGINS_BASE_CONF_OPTS += -Dgl_api='$(subst $(space),$(comma),$(GST1_PLUGINS_BASE_GL_API_LIST))' ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE_LIB_OPENGL_GLX),y)