[v3,1/2] dt-bindings: arm: realtek: Document RTD1619 and Realtek Mjolnir EVB
diff mbox series

Message ID d655415326064b079b9d1d791024c725@realtek.com
State Not Applicable
Headers show
Series
  • arm64: dts: Initial RTD1619 SoC and Realtek Mjolnir EVB support
Related show

Checks

Context Check Description
robh/checkpatch success

Commit Message

James Tai Nov. 12, 2019, 3:45 p.m. UTC
Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.

Signed-off-by: James Tai <james.tai@realtek.com>
---
 Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Andreas Färber Nov. 13, 2019, 9:01 p.m. UTC | #1
Am 12.11.19 um 16:45 schrieb James Tai:
> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
> 
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---

This is missing the requested change log here: What changed since v2?

If nothing changed, then you should've inserted my Reviewed-by from v2
before your Signed-off-by.

Regards,
Andreas

>  Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
> index ab59de17152d..2444eff2c3d5 100644
> --- a/Documentation/devicetree/bindings/arm/realtek.yaml
> +++ b/Documentation/devicetree/bindings/arm/realtek.yaml
> @@ -33,4 +33,10 @@ properties:
>            - enum:
>                - synology,ds418 # Synology DiskStation DS418
>            - const: realtek,rtd1296
> +
> +      # RTD1619 SoC based boards
> +      - items:
> +          - enum:
> +              - realtek,mjolnir # Realtek Mjolnir EVB
> +          - const: realtek,rtd1619
>  ...
>
James Tai Nov. 15, 2019, 2:42 p.m. UTC | #2
Hi Andreas,

> > Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
> >
> > Signed-off-by: James Tai <james.tai@realtek.com>
> > ---
> 
> This is missing the requested change log here: What changed since v2?
> 
> If nothing changed, then you should've inserted my Reviewed-by from v2
> before your Signed-off-by.
> 

There is nothing changed. I'll correct the mistakes in next version.
Rob Herring Nov. 18, 2019, 5:50 p.m. UTC | #3
On Tue, 12 Nov 2019 15:45:13 +0000, James Tai wrote:
> 
> Define compatible strings for Realtek RTD1619 SoC and Realtek Mjolnir EVB.
> 
> Signed-off-by: James Tai <james.tai@realtek.com>
> ---
>  Documentation/devicetree/bindings/arm/realtek.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
index ab59de17152d..2444eff2c3d5 100644
--- a/Documentation/devicetree/bindings/arm/realtek.yaml
+++ b/Documentation/devicetree/bindings/arm/realtek.yaml
@@ -33,4 +33,10 @@  properties:
           - enum:
               - synology,ds418 # Synology DiskStation DS418
           - const: realtek,rtd1296
+
+      # RTD1619 SoC based boards
+      - items:
+          - enum:
+              - realtek,mjolnir # Realtek Mjolnir EVB
+          - const: realtek,rtd1619
 ...