Patchwork [U-Boot,2/2] build: force migration away from $(AR)

login
register
mail settings
Submitter Mike Frysinger
Date Oct. 13, 2011, 5:25 a.m.
Message ID <1318483520-2035-2-git-send-email-vapier@gentoo.org>
Download mbox | patch
Permalink /patch/119351/
State Accepted
Commit 5968adc4146aac76e5597da3b52a51efb42d9179
Delegated to: Wolfgang Denk
Headers show

Comments

Mike Frysinger - Oct. 13, 2011, 5:25 a.m.
People keep adding new code that still uses $(AR) instead of
$(cmd_link_o_target), so turn it into a build time error.

We still use $(AR) locally, but we don't use $(ARFLAGS).

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 config.mk |    8 +++-----
 1 files changed, 3 insertions(+), 5 deletions(-)
Wolfgang Denk - Oct. 21, 2011, 11:19 p.m.
Dear Mike Frysinger,

In message <1318483520-2035-2-git-send-email-vapier@gentoo.org> you wrote:
> People keep adding new code that still uses $(AR) instead of
> $(cmd_link_o_target), so turn it into a build time error.
> 
> We still use $(AR) locally, but we don't use $(ARFLAGS).
> 
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  config.mk |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk

Patch

diff --git a/config.mk b/config.mk
index e2b440d..be9271e 100644
--- a/config.mk
+++ b/config.mk
@@ -157,11 +157,9 @@  endif
 
 #########################################################################
 
-ifneq (,$(findstring s,$(MAKEFLAGS)))
-ARFLAGS = cr
-else
-ARFLAGS = crv
-endif
+# We don't actually use $(ARFLAGS) anywhere anymore, so catch people
+# who are porting old code to latest mainline but not updating $(AR).
+ARFLAGS = $(error update your Makefile to use cmd_link_o_target and not AR)
 RELFLAGS= $(PLATFORM_RELFLAGS)
 DBGFLAGS= -g # -DDEBUG
 OPTFLAGS= -Os #-fomit-frame-pointer