Patchwork [U-Boot] Interrupt issue about bootvx command

login
register
mail settings
Submitter Peter Pan
Date Oct. 13, 2011, 2:40 a.m.
Message ID <CAGQXtZFp6oE_BjQGd6SSDAYk7kkg4-dy_1==LNK2Snh5h1Gfmg@mail.gmail.com>
Download mbox | patch
Permalink /patch/119341/
State Changes Requested
Headers show

Comments

Peter Pan - Oct. 13, 2011, 2:40 a.m.
Hi Wolfgang,

This is a customized board, which is very similar with Freescale's
P1020RDB (which is p1_p2_rdb in u-boot), only we replace the process
with a compatible one-core version.
And the board support files are mostly copied from the p1_p2_rdb.

And the following is my updated patch. My git does not have "git
send-mail" supported, so I have to paste the formatted commit below.
Sorry for that.

From 9758bc34e8459c8b906029105e41fe8adf9e79ca Mon Sep 17 00:00:00 2001
From: Ke Pan <pppeterpppan@gmail.com>
Date: Thu, 13 Oct 2011 10:34:23 +0800
Subject: [PATCH] common/cmd_elf : Disable interrupts before boot vxWorks

The vxWorks needs all interrupts to be disabled before its boot.
---
 common/cmd_elf.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

 	((void (*)(void)) addr) ();
Wolfgang Denk - Oct. 13, 2011, 8:20 p.m.
Dear Peter Pan,

please stop top posting / full quoting.


In message <CAGQXtZFp6oE_BjQGd6SSDAYk7kkg4-dy_1==LNK2Snh5h1Gfmg@mail.gmail.com> you wrote:
> 
> And the following is my updated patch. My git does not have "git
> send-mail" supported, so I have to paste the formatted commit below.
> Sorry for that.

Well, you'd better spend the time installing a full-featured version
of git.

> From 9758bc34e8459c8b906029105e41fe8adf9e79ca Mon Sep 17 00:00:00 2001
> From: Ke Pan <pppeterpppan@gmail.com>
> Date: Thu, 13 Oct 2011 10:34:23 +0800
> Subject: [PATCH] common/cmd_elf : Disable interrupts before boot vxWorks
> 
> The vxWorks needs all interrupts to be disabled before its boot.

Hm... And what exactly was not clear about the following statement:

> > Checkpatch says: total: 2 errors, 3 warnings, 10 lines checked
> >
> > Please see http://www.denx.de/wiki/U-Boot/Patches ; then clean up and
> > resubmit.

- Your commit message is mixed with text that belongs to the comment
  section only.

- Your SoB line is still missing

- There is a typo in "Disableing"; actually you should get rid of this
  printf().



Are there any testers out there?  I don't want to take this untested,
and I don't have any VxWorks anywhere around... (nor any other
proprietary code :-)

Best regards,

Wolfgang Denk

Patch

diff --git a/common/cmd_elf.c b/common/cmd_elf.c
index bf32612..a5ef9b4 100644
--- a/common/cmd_elf.c
+++ b/common/cmd_elf.c
@@ -228,6 +228,8 @@  int do_bootvx (cmd_tbl_t *cmdtp, int flag, int
argc, char * const argv[])

 	printf ("## Using bootline (@ 0x%lx): %s\n", bootaddr,
 			(char *) bootaddr);
+	printf("## Disableing interrupts ...\n");
+	disable_interrupts();
 	printf ("## Starting vxWorks at 0x%08lx ...\n", addr);