Patchwork [U-Boot,v6,1/5] tegra2: Use cmd_link_o_target in board Makefiles

login
register
mail settings
Submitter Stephen Warren
Date Oct. 12, 2011, 10:53 p.m.
Message ID <1318459989-24191-1-git-send-email-swarren@nvidia.com>
Download mbox | patch
Permalink /patch/119321/
State Not Applicable
Headers show

Comments

Stephen Warren - Oct. 12, 2011, 10:53 p.m.
v5: New patch

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Tested-by: Simon Glass <sjg@chromium.org>
---
 board/nvidia/harmony/Makefile  |    2 +-
 board/nvidia/seaboard/Makefile |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
Stephen Warren - Oct. 18, 2011, 6:14 p.m.
Stephen Warren wrote at Wednesday, October 12, 2011 4:53 PM:
> [Patch series relating to SD/MMC support on Tegra boards.]

Does this patch series look good?

Since these are my first U-Boot patches, I'm not sure exactly who would
pick these up and apply them (I assume the "ARM custodians", who are CC'd)
nor what I should expect in terms of when they'd be applied.

Thanks.
Simon Glass - Oct. 18, 2011, 6:31 p.m.
Hi Tom,

On Tue, Oct 18, 2011 at 11:14 AM, Stephen Warren <swarren@nvidia.com> wrote:
> Stephen Warren wrote at Wednesday, October 12, 2011 4:53 PM:
>> [Patch series relating to SD/MMC support on Tegra boards.]
>
> Does this patch series look good?
>
> Since these are my first U-Boot patches, I'm not sure exactly who would
> pick these up and apply them (I assume the "ARM custodians", who are CC'd)
> nor what I should expect in terms of when they'd be applied.

This patch set looks good to me, and is the next series that needs to
be applied to move Tegra along. I have based my latest series 'tegra2:
Tidy up boot path'  on your series.

Albert are you happy to apply Stephen's patch series?

Regards,
Simon

>
> Thanks.
>
> --
> nvpublic
>
>
Tom Warren - Oct. 18, 2011, 8:07 p.m.
s/Hi Tom/Hi Stephen/

> -----Original Message-----
> From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass
> Sent: Tuesday, October 18, 2011 11:31 AM
> To: Stephen Warren
> Cc: albert.u.boot@aribaud.net; afleming@gmail.com; Tom Warren; U-Boot
> Mailing List; Mike Frysinger
> Subject: Re: [PATCH v6 1/5] tegra2: Use cmd_link_o_target in board Makefiles
> 
> Hi Tom,
> 
> On Tue, Oct 18, 2011 at 11:14 AM, Stephen Warren <swarren@nvidia.com> wrote:
> > Stephen Warren wrote at Wednesday, October 12, 2011 4:53 PM:
> >> [Patch series relating to SD/MMC support on Tegra boards.]
> >
> > Does this patch series look good?
> >
> > Since these are my first U-Boot patches, I'm not sure exactly who would
> > pick these up and apply them (I assume the "ARM custodians", who are CC'd)
> > nor what I should expect in terms of when they'd be applied.
> 
> This patch set looks good to me, and is the next series that needs to
> be applied to move Tegra along. I have based my latest series 'tegra2:
> Tidy up boot path'  on your series.
> 
> Albert are you happy to apply Stephen's patch series?
> 
> Regards,
> Simon
> 
> >
> > Thanks.
> >
> > --
> > nvpublic
> >
> >
Simon Glass - Oct. 18, 2011, 8:51 p.m.
On Tue, Oct 18, 2011 at 1:07 PM, Tom Warren <TWarren@nvidia.com> wrote:
> s/Hi Tom/Hi Stephen/

Sorry! And my question was really directed to Albert.

Regards,
Simon

>
>> -----Original Message-----
>> From: sjg@google.com [mailto:sjg@google.com] On Behalf Of Simon Glass
>> Sent: Tuesday, October 18, 2011 11:31 AM
>> To: Stephen Warren
>> Cc: albert.u.boot@aribaud.net; afleming@gmail.com; Tom Warren; U-Boot
>> Mailing List; Mike Frysinger
>> Subject: Re: [PATCH v6 1/5] tegra2: Use cmd_link_o_target in board Makefiles
>>
>> Hi Tom,
>>
>> On Tue, Oct 18, 2011 at 11:14 AM, Stephen Warren <swarren@nvidia.com> wrote:
>> > Stephen Warren wrote at Wednesday, October 12, 2011 4:53 PM:
>> >> [Patch series relating to SD/MMC support on Tegra boards.]
>> >
>> > Does this patch series look good?
>> >
>> > Since these are my first U-Boot patches, I'm not sure exactly who would
>> > pick these up and apply them (I assume the "ARM custodians", who are CC'd)
>> > nor what I should expect in terms of when they'd be applied.
>>
>> This patch set looks good to me, and is the next series that needs to
>> be applied to move Tegra along. I have based my latest series 'tegra2:
>> Tidy up boot path'  on your series.
>>
>> Albert are you happy to apply Stephen's patch series?
>>
>> Regards,
>> Simon
>>
>> >
>> > Thanks.
>> >
>> > --
>> > nvpublic
>> >
>> >
>
Albert ARIBAUD - Oct. 28, 2011, 5:35 a.m.
Hi Simon,

Le 18/10/2011 22:51, Simon Glass a écrit :
> On Tue, Oct 18, 2011 at 1:07 PM, Tom Warren<TWarren@nvidia.com>  wrote:
>> s/Hi Tom/Hi Stephen/
>
> Sorry! And my question was really directed to Albert.

Going up my backlog... for 2/4 and 4/5, as their are touching MMC driver 
code, I'd like Andy to ack them as the the MMC custodian, then I can 
apply the whole set (pending the MAINTAINER addition).

> Regards,
> Simon

Amicalement,
Mike Frysinger - Oct. 28, 2011, 6:25 a.m.
On Fri, Oct 28, 2011 at 07:35, Albert ARIBAUD wrote:
> Going up my backlog... for 2/4 and 4/5, as their are touching MMC driver
> code, I'd like Andy to ack them as the the MMC custodian, then I can apply
> the whole set (pending the MAINTAINER addition).

i don't think this particular patch needs that much acknowledgement.
but at any rate, this patch is obsolete now as a newer one has already
been merged by Wolfgang.
-mike
Simon Glass - Oct. 29, 2011, midnight
Hi,

On Thu, Oct 27, 2011 at 11:25 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Fri, Oct 28, 2011 at 07:35, Albert ARIBAUD wrote:
>> Going up my backlog... for 2/4 and 4/5, as their are touching MMC driver
>> code, I'd like Andy to ack them as the the MMC custodian, then I can apply
>> the whole set (pending the MAINTAINER addition).
>
> i don't think this particular patch needs that much acknowledgement.
> but at any rate, this patch is obsolete now as a newer one has already
> been merged by Wolfgang.
> -mike
>

Yes this single patch can be dropped now, meaning that Stephen's series is now:

tegra2: Move MMC clock initialization into MMC driver
tegra2: Move board_mmc_init into board files
tegra2: Modify MMC driver to handle power and cd GPIOs
tegra2: Add support for Ventana

Regards,
Simon

Patch

diff --git a/board/nvidia/harmony/Makefile b/board/nvidia/harmony/Makefile
index ebd8e02..aab185e 100644
--- a/board/nvidia/harmony/Makefile
+++ b/board/nvidia/harmony/Makefile
@@ -37,7 +37,7 @@  SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
 
 $(LIB):	$(obj).depend $(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
 
 clean:
 	rm -f $(OBJS)
diff --git a/board/nvidia/seaboard/Makefile b/board/nvidia/seaboard/Makefile
index ebd8e02..aab185e 100644
--- a/board/nvidia/seaboard/Makefile
+++ b/board/nvidia/seaboard/Makefile
@@ -37,7 +37,7 @@  SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))
 
 $(LIB):	$(obj).depend $(OBJS)
-	$(AR) $(ARFLAGS) $@ $(OBJS)
+	$(call cmd_link_o_target, $(OBJS))
 
 clean:
 	rm -f $(OBJS)